From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Peng Fan <peng.fan@nxp.com> Cc: "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional Date: Wed, 19 Aug 2020 13:45:04 -0600 [thread overview] Message-ID: <20200819194504.GB3845366@xps15> (raw) In-Reply-To: <DB6PR0402MB276017AA0C124172D9BC3483885D0@DB6PR0402MB2760.eurprd04.prod.outlook.com> On Wed, Aug 19, 2020 at 12:51:27AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional > > > > Hi Peng, > > > > On Fri, Jul 24, 2020 at 04:08:07PM +0800, Peng Fan wrote: > > > Make syscon optional, since i.MX8QM/QXP/7ULP not have SRC to control > > M4. > > > But currently i.MX8QM/QXP/7ULP not added, so still check regmap when > > > start/stop to avoid unhappy things. > > > > On the i.MX8QM/QXP/7ULP processors, the remote processors are not > > handled by the remoteproc cores, as implemented in this patch. In such a > > scenario how does the remoteproc core know the remote processor has > > crashed and how does it recover from such a condition? > > For 7ULP dual boot case, A7 is under control of M4, so if m4 crash, I suppose > A7 would not work properly. In that case I assume the whole system gets rebooted, which puts the A7 in a state where it can "attach" with the M4 again. > > For 8QM/QXP partition case, M4 is in a standalone partition, if M4 crash or > reboot, the system controller unit will restart M4 and notify Acore that M4 > restart. And how does that notification work exactly? Does rproc_report_crash() get called somewhere in that process in order for the remoteproc core to attach to the M4 again? Many thanks for the help, Mathieu > > Thanks, > Peng. > > > > > Thanks, > > Mathieu > > > > > > > > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > drivers/remoteproc/imx_rproc.c | 11 +++++++++-- > > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 82594a800a1b..4fad5c0b1c05 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -162,6 +162,9 @@ static int imx_rproc_start(struct rproc *rproc) > > > struct device *dev = priv->dev; > > > int ret; > > > > > > + if (!priv->regmap) > > > + return -EOPNOTSUPP; > > > + > > > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > > > dcfg->src_mask, dcfg->src_start); > > > if (ret) > > > @@ -177,6 +180,9 @@ static int imx_rproc_stop(struct rproc *rproc) > > > struct device *dev = priv->dev; > > > int ret; > > > > > > + if (!priv->regmap) > > > + return -EOPNOTSUPP; > > > + > > > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > > > dcfg->src_mask, dcfg->src_stop); > > > if (ret) > > > @@ -325,9 +331,10 @@ static int imx_rproc_probe(struct platform_device > > *pdev) > > > regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > > > if (IS_ERR(regmap)) { > > > dev_err(dev, "failed to find syscon\n"); > > > - return PTR_ERR(regmap); > > > + regmap = NULL; > > > + } else { > > > + regmap_attach_dev(dev, regmap, &config); > > > } > > > - regmap_attach_dev(dev, regmap, &config); > > > > > > /* set some other name then imx */ > > > rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, > > > -- > > > 2.16.4 > > >
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Peng Fan <peng.fan@nxp.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional Date: Wed, 19 Aug 2020 13:45:04 -0600 [thread overview] Message-ID: <20200819194504.GB3845366@xps15> (raw) In-Reply-To: <DB6PR0402MB276017AA0C124172D9BC3483885D0@DB6PR0402MB2760.eurprd04.prod.outlook.com> On Wed, Aug 19, 2020 at 12:51:27AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional > > > > Hi Peng, > > > > On Fri, Jul 24, 2020 at 04:08:07PM +0800, Peng Fan wrote: > > > Make syscon optional, since i.MX8QM/QXP/7ULP not have SRC to control > > M4. > > > But currently i.MX8QM/QXP/7ULP not added, so still check regmap when > > > start/stop to avoid unhappy things. > > > > On the i.MX8QM/QXP/7ULP processors, the remote processors are not > > handled by the remoteproc cores, as implemented in this patch. In such a > > scenario how does the remoteproc core know the remote processor has > > crashed and how does it recover from such a condition? > > For 7ULP dual boot case, A7 is under control of M4, so if m4 crash, I suppose > A7 would not work properly. In that case I assume the whole system gets rebooted, which puts the A7 in a state where it can "attach" with the M4 again. > > For 8QM/QXP partition case, M4 is in a standalone partition, if M4 crash or > reboot, the system controller unit will restart M4 and notify Acore that M4 > restart. And how does that notification work exactly? Does rproc_report_crash() get called somewhere in that process in order for the remoteproc core to attach to the M4 again? Many thanks for the help, Mathieu > > Thanks, > Peng. > > > > > Thanks, > > Mathieu > > > > > > > > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > drivers/remoteproc/imx_rproc.c | 11 +++++++++-- > > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 82594a800a1b..4fad5c0b1c05 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -162,6 +162,9 @@ static int imx_rproc_start(struct rproc *rproc) > > > struct device *dev = priv->dev; > > > int ret; > > > > > > + if (!priv->regmap) > > > + return -EOPNOTSUPP; > > > + > > > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > > > dcfg->src_mask, dcfg->src_start); > > > if (ret) > > > @@ -177,6 +180,9 @@ static int imx_rproc_stop(struct rproc *rproc) > > > struct device *dev = priv->dev; > > > int ret; > > > > > > + if (!priv->regmap) > > > + return -EOPNOTSUPP; > > > + > > > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > > > dcfg->src_mask, dcfg->src_stop); > > > if (ret) > > > @@ -325,9 +331,10 @@ static int imx_rproc_probe(struct platform_device > > *pdev) > > > regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > > > if (IS_ERR(regmap)) { > > > dev_err(dev, "failed to find syscon\n"); > > > - return PTR_ERR(regmap); > > > + regmap = NULL; > > > + } else { > > > + regmap_attach_dev(dev, regmap, &config); > > > } > > > - regmap_attach_dev(dev, regmap, &config); > > > > > > /* set some other name then imx */ > > > rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, > > > -- > > > 2.16.4 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-19 19:45 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-24 8:08 [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-07-24 8:08 ` [PATCH 01/10] dt-bindings: remoteproc: imx_rproc: add i.MX8MQ/M Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-07-31 20:14 ` Rob Herring 2020-07-31 20:14 ` Rob Herring 2020-07-24 8:08 ` [PATCH 02/10] remoteproc: imx_rproc: correct err message Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-08-11 19:56 ` Mathieu Poirier 2020-08-11 19:56 ` Mathieu Poirier 2020-07-24 8:08 ` [PATCH 03/10] remoteproc: imx: use devm_ioremap Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-07-27 6:23 ` Oleksij Rempel 2020-07-27 6:23 ` Oleksij Rempel 2020-07-27 6:28 ` Peng Fan 2020-07-27 6:28 ` Peng Fan 2020-07-27 6:41 ` Oleksij Rempel 2020-07-27 6:41 ` Oleksij Rempel 2020-07-27 6:51 ` Peng Fan 2020-07-27 6:51 ` Peng Fan 2020-07-27 7:37 ` Oleksij Rempel 2020-07-27 7:37 ` Oleksij Rempel 2020-07-27 8:11 ` Peng Fan 2020-07-27 8:11 ` Peng Fan 2020-07-28 7:20 ` Oleksij Rempel 2020-07-28 7:20 ` Oleksij Rempel 2020-07-24 8:08 ` [PATCH 04/10] remoteproc: imx_rproc: make syscon optional Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-08-11 22:40 ` Mathieu Poirier 2020-08-11 22:40 ` Mathieu Poirier 2020-08-18 21:43 ` Mathieu Poirier 2020-08-18 21:43 ` Mathieu Poirier 2020-08-19 0:51 ` Peng Fan 2020-08-19 0:51 ` Peng Fan 2020-08-19 19:45 ` Mathieu Poirier [this message] 2020-08-19 19:45 ` Mathieu Poirier 2020-08-20 2:04 ` Peng Fan 2020-08-20 2:04 ` Peng Fan 2020-08-20 19:27 ` Mathieu Poirier 2020-08-20 19:27 ` Mathieu Poirier 2020-07-24 8:08 ` [PATCH 05/10] remoteproc: imx_rproc: make clk optional Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-07-24 8:08 ` [PATCH 06/10] remoteproc: imx_rproc: add load hook Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-07-27 5:20 ` Oleksij Rempel 2020-07-27 5:20 ` Oleksij Rempel 2020-08-11 21:40 ` Mathieu Poirier 2020-08-11 21:40 ` Mathieu Poirier 2020-07-24 8:08 ` [PATCH 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-08-11 21:56 ` Mathieu Poirier 2020-08-11 21:56 ` Mathieu Poirier 2020-07-24 8:08 ` [PATCH 08/10] remoteproc: imx_rproc: support i.MX8MQ/M Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-07-24 8:08 ` [PATCH 09/10] remoteproc: imx_proc: enable virtio/mailbox Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-07-24 8:08 ` [PATCH 10/10] remoteproc: imx_rproc: support coproc booting before Linux Peng Fan 2020-07-24 8:08 ` Peng Fan 2020-08-11 22:36 ` Mathieu Poirier 2020-08-11 22:36 ` Mathieu Poirier 2020-07-27 6:38 ` [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot Oleksij Rempel 2020-07-27 6:38 ` Oleksij Rempel 2020-07-27 6:44 ` Peng Fan 2020-07-27 6:44 ` Peng Fan 2020-07-27 7:54 ` Oleksij Rempel 2020-07-27 7:54 ` Oleksij Rempel 2020-07-27 9:18 ` Peng Fan 2020-07-27 9:18 ` Peng Fan 2020-07-28 7:26 ` Oleksij Rempel 2020-07-28 7:26 ` Oleksij Rempel 2020-07-28 7:50 ` Peng Fan 2020-07-28 7:50 ` Peng Fan 2020-07-28 7:55 ` Oleksij Rempel 2020-07-28 7:55 ` Oleksij Rempel 2020-07-28 9:36 ` Peng Fan 2020-07-28 9:36 ` Peng Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200819194504.GB3845366@xps15 \ --to=mathieu.poirier@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=o.rempel@pengutronix.de \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.