* [PATCH] Documentation: kbuild: modules.rst: Edit '$$' typo, avoid make error
@ 2020-08-19 21:55 Graeme Hayes
2020-08-20 10:46 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Graeme Hayes @ 2020-08-19 21:55 UTC (permalink / raw)
To: masahiroy; +Cc: linux-kbuild, trivial, Graeme Hayes
Typo '$$' generates make error when run, and was pasted twice more.
Signed-off-by: Graeme Hayes <hayes.graeme.p@gmail.com>
---
linux-kbuild/Documentation/kbuild/modules.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-kbuild/Documentation/kbuild/modules.rst b/linux-kbuild/Documentation/kbuild/modules.rst
index 85ccc87..c7837a5 100644
--- a/linux-kbuild/Documentation/kbuild/modules.rst
+++ b/linux-kbuild/Documentation/kbuild/modules.rst
@@ -205,7 +205,7 @@ module 8123.ko, which is built from the following files::
KDIR ?= /lib/modules/`uname -r`/build
default:
- $(MAKE) -C $(KDIR) M=$$PWD
+ $(MAKE) -C $(KDIR) M=$PWD
# Module specific targets
genbin:
@@ -239,7 +239,7 @@ module 8123.ko, which is built from the following files::
KDIR ?= /lib/modules/`uname -r`/build
default:
- $(MAKE) -C $(KDIR) M=$$PWD
+ $(MAKE) -C $(KDIR) M=$PWD
# Module specific targets
genbin:
@@ -268,7 +268,7 @@ module 8123.ko, which is built from the following files::
KDIR ?= /lib/modules/`uname -r`/build
default:
- $(MAKE) -C $(KDIR) M=$$PWD
+ $(MAKE) -C $(KDIR) M=$PWD
# Module specific targets
genbin:
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation: kbuild: modules.rst: Edit '$$' typo, avoid make error
2020-08-19 21:55 [PATCH] Documentation: kbuild: modules.rst: Edit '$$' typo, avoid make error Graeme Hayes
@ 2020-08-20 10:46 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2020-08-20 10:46 UTC (permalink / raw)
To: Graeme Hayes; +Cc: Linux Kbuild mailing list, Jiri Kosina
On Thu, Aug 20, 2020 at 7:00 AM Graeme Hayes <hayes.graeme.p@gmail.com> wrote:
>
> Typo '$$' generates make error when run, and was pasted twice more.
Are you sure?
$$PWD is the correct escape sequence
to expand $PWD in the shell instead of Make.
> Signed-off-by: Graeme Hayes <hayes.graeme.p@gmail.com>
>
> ---
> linux-kbuild/Documentation/kbuild/modules.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-kbuild/Documentation/kbuild/modules.rst b/linux-kbuild/Documentation/kbuild/modules.rst
> index 85ccc87..c7837a5 100644
> --- a/linux-kbuild/Documentation/kbuild/modules.rst
> +++ b/linux-kbuild/Documentation/kbuild/modules.rst
> @@ -205,7 +205,7 @@ module 8123.ko, which is built from the following files::
> KDIR ?= /lib/modules/`uname -r`/build
>
> default:
> - $(MAKE) -C $(KDIR) M=$$PWD
> + $(MAKE) -C $(KDIR) M=$PWD
>
> # Module specific targets
> genbin:
> @@ -239,7 +239,7 @@ module 8123.ko, which is built from the following files::
> KDIR ?= /lib/modules/`uname -r`/build
>
> default:
> - $(MAKE) -C $(KDIR) M=$$PWD
> + $(MAKE) -C $(KDIR) M=$PWD
>
> # Module specific targets
> genbin:
> @@ -268,7 +268,7 @@ module 8123.ko, which is built from the following files::
> KDIR ?= /lib/modules/`uname -r`/build
>
> default:
> - $(MAKE) -C $(KDIR) M=$$PWD
> + $(MAKE) -C $(KDIR) M=$PWD
>
> # Module specific targets
> genbin:
> --
> 2.17.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-20 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 21:55 [PATCH] Documentation: kbuild: modules.rst: Edit '$$' typo, avoid make error Graeme Hayes
2020-08-20 10:46 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.