* [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine
@ 2020-08-20 9:48 David Hildenbrand
2020-08-20 10:01 ` Dr. David Alan Gilbert
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Hildenbrand @ 2020-08-20 9:48 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, David Hildenbrand, Michael S. Tsirkin,
qemu-stable, Dr . David Alan Gilbert, Paolo Bonzini,
Richard Henderson
Unfortunately, a typo sneeked in: we want to set
auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp.
Cc: qemu-stable@nongnu.org # v5.1
Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)
Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/i386/pc_q35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index a3e607a544..e94f45779b 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -371,7 +371,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m)
m->numa_mem_supported = true;
compat_props_add(m->compat_props, hw_compat_5_0, hw_compat_5_0_len);
compat_props_add(m->compat_props, pc_compat_5_0, pc_compat_5_0_len);
- m->auto_enable_numa_with_memhp = false;
+ m->auto_enable_numa_with_memdev = false;
}
DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine
2020-08-20 9:48 [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine David Hildenbrand
@ 2020-08-20 10:01 ` Dr. David Alan Gilbert
2020-08-20 14:08 ` Igor Mammedov
2020-09-08 8:56 ` David Hildenbrand
2 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2020-08-20 10:01 UTC (permalink / raw)
To: David Hildenbrand
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-devel, qemu-stable,
Paolo Bonzini, Richard Henderson
* David Hildenbrand (david@redhat.com) wrote:
> Unfortunately, a typo sneeked in: we want to set
> auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp.
>
> Cc: qemu-stable@nongnu.org # v5.1
> Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/i386/pc_q35.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index a3e607a544..e94f45779b 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -371,7 +371,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m)
> m->numa_mem_supported = true;
> compat_props_add(m->compat_props, hw_compat_5_0, hw_compat_5_0_len);
> compat_props_add(m->compat_props, pc_compat_5_0, pc_compat_5_0_len);
> - m->auto_enable_numa_with_memhp = false;
> + m->auto_enable_numa_with_memdev = false;
> }
>
> DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,
> --
> 2.26.2
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine
2020-08-20 9:48 [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine David Hildenbrand
2020-08-20 10:01 ` Dr. David Alan Gilbert
@ 2020-08-20 14:08 ` Igor Mammedov
2020-09-08 8:56 ` David Hildenbrand
2 siblings, 0 replies; 5+ messages in thread
From: Igor Mammedov @ 2020-08-20 14:08 UTC (permalink / raw)
To: David Hildenbrand
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-stable, qemu-devel,
Paolo Bonzini, Dr . David Alan Gilbert, Richard Henderson
On Thu, 20 Aug 2020 11:48:28 +0200
David Hildenbrand <david@redhat.com> wrote:
> Unfortunately, a typo sneeked in: we want to set
> auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp.
>
> Cc: qemu-stable@nongnu.org # v5.1
> Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc_q35.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index a3e607a544..e94f45779b 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -371,7 +371,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m)
> m->numa_mem_supported = true;
> compat_props_add(m->compat_props, hw_compat_5_0, hw_compat_5_0_len);
> compat_props_add(m->compat_props, pc_compat_5_0, pc_compat_5_0_len);
> - m->auto_enable_numa_with_memhp = false;
> + m->auto_enable_numa_with_memdev = false;
> }
>
> DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine
2020-08-20 9:48 [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine David Hildenbrand
2020-08-20 10:01 ` Dr. David Alan Gilbert
2020-08-20 14:08 ` Igor Mammedov
@ 2020-09-08 8:56 ` David Hildenbrand
2020-09-08 10:02 ` Michael S. Tsirkin
2 siblings, 1 reply; 5+ messages in thread
From: David Hildenbrand @ 2020-09-08 8:56 UTC (permalink / raw)
To: qemu-devel, Michael S. Tsirkin
Cc: Paolo Bonzini, Richard Henderson, qemu-stable, Eduardo Habkost,
Dr . David Alan Gilbert
On 20.08.20 11:48, David Hildenbrand wrote:
> Unfortunately, a typo sneeked in: we want to set
> auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp.
>
> Cc: qemu-stable@nongnu.org # v5.1
> Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
@MST, do you want to queue this patch? thanks!
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine
2020-09-08 8:56 ` David Hildenbrand
@ 2020-09-08 10:02 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2020-09-08 10:02 UTC (permalink / raw)
To: David Hildenbrand
Cc: Eduardo Habkost, qemu-stable, qemu-devel,
Dr . David Alan Gilbert, Paolo Bonzini, Richard Henderson
On Tue, Sep 08, 2020 at 10:56:53AM +0200, David Hildenbrand wrote:
> On 20.08.20 11:48, David Hildenbrand wrote:
> > Unfortunately, a typo sneeked in: we want to set
> > auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp.
> >
> > Cc: qemu-stable@nongnu.org # v5.1
> > Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)
> > Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Richard Henderson <rth@twiddle.net>
> > Cc: Eduardo Habkost <ehabkost@redhat.com>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Signed-off-by: David Hildenbrand <david@redhat.com>
>
> @MST, do you want to queue this patch? thanks!
queued, thanks!
>
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-08 10:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-20 9:48 [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine David Hildenbrand
2020-08-20 10:01 ` Dr. David Alan Gilbert
2020-08-20 14:08 ` Igor Mammedov
2020-09-08 8:56 ` David Hildenbrand
2020-09-08 10:02 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.