From: Tingwei Zhang <tingwei@codeaurora.org> To: Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Mike Leach <mike.leach@linaro.org> Cc: Kim Phillips <kim.phillips@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Leo Yan <leo.yan@linaro.org>, Randy Dunlap <rdunlap@infradead.org>, Russell King <linux@armlinux.org.uk>, Mian Yousaf Kaukab <ykaukab@suse.de>, tsoni@codeaurora.org, Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>, Mao Jinlong <jinlmao@codeaurora.org>, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Suzuki K Poulose <Suzuki.Poulose@arm.com>, Tingwei Zhang <tingwei@codeaurora.org> Subject: [PATCH v10 11/24] coresight: etb: allow etb to be built as a module Date: Fri, 21 Aug 2020 11:44:32 +0800 [thread overview] Message-ID: <20200821034445.967-12-tingwei@codeaurora.org> (raw) In-Reply-To: <20200821034445.967-1-tingwei@codeaurora.org> From: Kim Phillips <kim.phillips@arm.com> Allow to build coresight-etb10 as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - add an etb_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Leo Yan <leo.yan@linaro.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Russell King <linux@armlinux.org.uk> Signed-off-by: Kim Phillips <kim.phillips@arm.com> Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org> Tested-by: Mike Leach <mike.leach@linaro.org> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/hwtracing/coresight/Kconfig | 5 +++- drivers/hwtracing/coresight/coresight-etb10.c | 26 ++++++++++++++++++- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig index d6e107bbd30b..996d84a1edb8 100644 --- a/drivers/hwtracing/coresight/Kconfig +++ b/drivers/hwtracing/coresight/Kconfig @@ -57,13 +57,16 @@ config CORESIGHT_SINK_TPIU the on-board coresight memory can handle. config CORESIGHT_SINK_ETBV10 - bool "Coresight ETBv1.0 driver" + tristate "Coresight ETBv1.0 driver" depends on CORESIGHT_LINKS_AND_SINKS help This enables support for the Embedded Trace Buffer version 1.0 driver that complies with the generic implementation of the component without special enhancement or added features. + To compile this driver as a module, choose M here: the + module will be called coresight-etb10. + config CORESIGHT_SOURCE_ETM3X tristate "CoreSight Embedded Trace Macrocell 3.x driver" depends on !ARM64 diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 04ee9cda988d..248cc82c838e 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -801,6 +801,21 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) return ret; } +static int __exit etb_remove(struct amba_device *adev) +{ + struct etb_drvdata *drvdata = dev_get_drvdata(&adev->dev); + + /* + * Since misc_open() holds a refcount on the f_ops, which is + * etb fops in this case, device is there until last file + * handler to this device is closed. + */ + misc_deregister(&drvdata->miscdev); + coresight_unregister(drvdata->csdev); + + return 0; +} + #ifdef CONFIG_PM static int etb_runtime_suspend(struct device *dev) { @@ -835,6 +850,8 @@ static const struct amba_id etb_ids[] = { { 0, 0}, }; +MODULE_DEVICE_TABLE(amba, etb_ids); + static struct amba_driver etb_driver = { .drv = { .name = "coresight-etb10", @@ -844,6 +861,13 @@ static struct amba_driver etb_driver = { }, .probe = etb_probe, + .remove = etb_remove, .id_table = etb_ids, }; -builtin_amba_driver(etb_driver); + +module_amba_driver(etb_driver); + +MODULE_AUTHOR("Pratik Patel <pratikp@codeaurora.org>"); +MODULE_AUTHOR("Mathieu Poirier <mathieu.poirier@linaro.org>"); +MODULE_DESCRIPTION("Arm CoreSight Embedded Trace Buffer driver"); +MODULE_LICENSE("GPL v2"); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Tingwei Zhang <tingwei@codeaurora.org> To: Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Mike Leach <mike.leach@linaro.org> Cc: tsoni@codeaurora.org, Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>, Kim Phillips <kim.phillips@arm.com>, Mao Jinlong <jinlmao@codeaurora.org>, Suzuki K Poulose <Suzuki.Poulose@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, coresight@lists.linaro.org, Randy Dunlap <rdunlap@infradead.org>, Mian Yousaf Kaukab <ykaukab@suse.de>, Russell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org, Tingwei Zhang <tingwei@codeaurora.org>, Leo Yan <leo.yan@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v10 11/24] coresight: etb: allow etb to be built as a module Date: Fri, 21 Aug 2020 11:44:32 +0800 [thread overview] Message-ID: <20200821034445.967-12-tingwei@codeaurora.org> (raw) In-Reply-To: <20200821034445.967-1-tingwei@codeaurora.org> From: Kim Phillips <kim.phillips@arm.com> Allow to build coresight-etb10 as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - add an etb_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Leo Yan <leo.yan@linaro.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Russell King <linux@armlinux.org.uk> Signed-off-by: Kim Phillips <kim.phillips@arm.com> Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org> Tested-by: Mike Leach <mike.leach@linaro.org> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/hwtracing/coresight/Kconfig | 5 +++- drivers/hwtracing/coresight/coresight-etb10.c | 26 ++++++++++++++++++- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig index d6e107bbd30b..996d84a1edb8 100644 --- a/drivers/hwtracing/coresight/Kconfig +++ b/drivers/hwtracing/coresight/Kconfig @@ -57,13 +57,16 @@ config CORESIGHT_SINK_TPIU the on-board coresight memory can handle. config CORESIGHT_SINK_ETBV10 - bool "Coresight ETBv1.0 driver" + tristate "Coresight ETBv1.0 driver" depends on CORESIGHT_LINKS_AND_SINKS help This enables support for the Embedded Trace Buffer version 1.0 driver that complies with the generic implementation of the component without special enhancement or added features. + To compile this driver as a module, choose M here: the + module will be called coresight-etb10. + config CORESIGHT_SOURCE_ETM3X tristate "CoreSight Embedded Trace Macrocell 3.x driver" depends on !ARM64 diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 04ee9cda988d..248cc82c838e 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -801,6 +801,21 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) return ret; } +static int __exit etb_remove(struct amba_device *adev) +{ + struct etb_drvdata *drvdata = dev_get_drvdata(&adev->dev); + + /* + * Since misc_open() holds a refcount on the f_ops, which is + * etb fops in this case, device is there until last file + * handler to this device is closed. + */ + misc_deregister(&drvdata->miscdev); + coresight_unregister(drvdata->csdev); + + return 0; +} + #ifdef CONFIG_PM static int etb_runtime_suspend(struct device *dev) { @@ -835,6 +850,8 @@ static const struct amba_id etb_ids[] = { { 0, 0}, }; +MODULE_DEVICE_TABLE(amba, etb_ids); + static struct amba_driver etb_driver = { .drv = { .name = "coresight-etb10", @@ -844,6 +861,13 @@ static struct amba_driver etb_driver = { }, .probe = etb_probe, + .remove = etb_remove, .id_table = etb_ids, }; -builtin_amba_driver(etb_driver); + +module_amba_driver(etb_driver); + +MODULE_AUTHOR("Pratik Patel <pratikp@codeaurora.org>"); +MODULE_AUTHOR("Mathieu Poirier <mathieu.poirier@linaro.org>"); +MODULE_DESCRIPTION("Arm CoreSight Embedded Trace Buffer driver"); +MODULE_LICENSE("GPL v2"); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-21 3:46 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-21 3:44 [PATCH v10 00/24] coresight: allow to build coresight as modules Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 01/24] coresight: cpu_debug: add module name in Kconfig Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 02/24] coresight: cpu_debug: define MODULE_DEVICE_TABLE Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 03/24] coresight: use IS_ENABLED for CONFIGs that may be modules Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 04/24] coresight: add coresight prefix to barrier_pkt Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-09-10 22:19 ` Mathieu Poirier 2020-09-10 22:19 ` Mathieu Poirier 2020-09-11 2:39 ` Tingwei Zhang 2020-09-11 2:39 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 05/24] coresight: export global symbols Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 06/24] coresight: add try_get_module() in coresight_grab_device() Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 07/24] coresight: stm: allow to build coresight-stm as a module Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-09-10 22:28 ` Mathieu Poirier 2020-09-10 22:28 ` Mathieu Poirier 2020-09-11 2:49 ` Tingwei Zhang 2020-09-11 2:49 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 09/24] coresight: etm3x: allow etm3x to be built as a module Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-09-13 13:17 ` Suzuki K Poulose 2020-09-13 13:17 ` Suzuki K Poulose 2020-09-14 2:19 ` Tingwei Zhang 2020-09-14 2:19 ` Tingwei Zhang 2020-09-14 15:45 ` Mathieu Poirier 2020-09-14 15:45 ` Mathieu Poirier 2020-09-14 18:11 ` Mathieu Poirier 2020-09-14 18:11 ` Mathieu Poirier 2020-08-21 3:44 ` [PATCH v10 10/24] coresight: etm4x: allow etm4x " Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 9:10 ` Sai Prakash Ranjan 2020-08-21 9:10 ` Sai Prakash Ranjan 2020-09-13 13:18 ` Suzuki K Poulose 2020-09-13 13:18 ` Suzuki K Poulose 2020-08-21 3:44 ` Tingwei Zhang [this message] 2020-08-21 3:44 ` [PATCH v10 11/24] coresight: etb: allow etb " Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 12/24] coresight: tpiu: allow tpiu " Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 13/24] coresight: tmc: allow tmc " Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 9:09 ` Sai Prakash Ranjan 2020-08-21 9:09 ` Sai Prakash Ranjan 2020-08-21 3:44 ` [PATCH v10 14/24] coresight: allow funnel driver to be built as module Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 9:09 ` Sai Prakash Ranjan 2020-08-21 9:09 ` Sai Prakash Ranjan 2020-09-13 13:20 ` Suzuki K Poulose 2020-09-13 13:20 ` Suzuki K Poulose 2020-09-13 13:24 ` Suzuki K Poulose 2020-09-13 13:24 ` Suzuki K Poulose 2020-09-14 2:17 ` Tingwei Zhang 2020-09-14 2:17 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 15/24] coresight: allow replicator " Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 9:08 ` Sai Prakash Ranjan 2020-08-21 9:08 ` Sai Prakash Ranjan 2020-09-10 23:00 ` Mathieu Poirier 2020-09-10 23:00 ` Mathieu Poirier 2020-08-21 3:44 ` [PATCH v10 16/24] coresight: cti: add function to register cti associate ops Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 17/24] coresight: cti: Fix remove sysfs link error Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 18/24] coresight: cti: Fix bug clearing sysfs links on callback Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-09-10 23:00 ` Mathieu Poirier 2020-09-10 23:00 ` Mathieu Poirier 2020-08-21 3:44 ` [PATCH v10 19/24] coresight: cti: don't disable ect device if it's not enabled Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-09-14 18:07 ` Mathieu Poirier 2020-09-14 18:07 ` Mathieu Poirier 2020-08-21 3:44 ` [PATCH v10 20/24] coresight: cti: increase reference count when enabling cti Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-09-14 18:08 ` Mathieu Poirier 2020-09-14 18:08 ` Mathieu Poirier 2020-08-21 3:44 ` [PATCH v10 21/24] coresight: cti: allow cti to be built as a module Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-09-10 23:03 ` Mathieu Poirier 2020-09-10 23:03 ` Mathieu Poirier 2020-09-11 2:51 ` Tingwei Zhang 2020-09-11 2:51 ` Tingwei Zhang [not found] ` <010101747b1340f9-b0542779-88d7-4193-b53b-5b5bfab5d6a3-000000@us-west-2.amazonses.com> 2020-09-11 17:42 ` Mathieu Poirier 2020-09-11 17:42 ` Mathieu Poirier 2020-08-21 3:44 ` [PATCH v10 22/24] coresight: tmc-etr: add function to register catu ops Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 23/24] coresight: catu: allow catu drivers to be built as modules Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 3:44 ` [PATCH v10 24/24] coresight: allow the coresight core driver to be built as a module Tingwei Zhang 2020-08-21 3:44 ` Tingwei Zhang 2020-08-21 9:07 ` Sai Prakash Ranjan 2020-08-21 9:07 ` Sai Prakash Ranjan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200821034445.967-12-tingwei@codeaurora.org \ --to=tingwei@codeaurora.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jinlmao@codeaurora.org \ --cc=kim.phillips@arm.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=rdunlap@infradead.org \ --cc=saiprakash.ranjan@codeaurora.org \ --cc=suzuki.poulose@arm.com \ --cc=tsoni@codeaurora.org \ --cc=ykaukab@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.