* [PATCH] mmc: improve documentation of HW_RESET
@ 2020-08-21 6:35 Wolfram Sang
2020-08-24 9:51 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2020-08-21 6:35 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Ulf Hansson, Wolfram Sang
HW_RESET means resetting the remote device, not the controller. Two
drivers got it wrong, so make it more clear.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
I sent a series to fix the TMIO/SDHI driver. The other one is bcm2835,
but I want to get this patch approved, before I notify the maintainers.
include/linux/mmc/host.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index c5b6e97cb21a..cf04793ab4ea 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -163,6 +163,7 @@ struct mmc_host_ops {
int (*select_drive_strength)(struct mmc_card *card,
unsigned int max_dtr, int host_drv,
int card_drv, int *drv_type);
+ /* Reset remote device via RST_n */
void (*hw_reset)(struct mmc_host *host);
void (*card_event)(struct mmc_host *host);
@@ -346,7 +347,7 @@ struct mmc_host {
#define MMC_CAP_CD_WAKE (1 << 28) /* Enable card detect wake */
#define MMC_CAP_CMD_DURING_TFR (1 << 29) /* Commands during data transfer */
#define MMC_CAP_CMD23 (1 << 30) /* CMD23 supported. */
-#define MMC_CAP_HW_RESET (1 << 31) /* Hardware reset */
+#define MMC_CAP_HW_RESET (1 << 31) /* supports device reset via RST_n */
u32 caps2; /* More host capabilities */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: improve documentation of HW_RESET
2020-08-21 6:35 [PATCH] mmc: improve documentation of HW_RESET Wolfram Sang
@ 2020-08-24 9:51 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2020-08-24 9:51 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, Linux-Renesas
On Fri, 21 Aug 2020 at 08:35, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> HW_RESET means resetting the remote device, not the controller. Two
> drivers got it wrong, so make it more clear.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, with a few amendments, thanks!
Kind regards
Uffe
> ---
>
> I sent a series to fix the TMIO/SDHI driver. The other one is bcm2835,
> but I want to get this patch approved, before I notify the maintainers.
>
> include/linux/mmc/host.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
> index c5b6e97cb21a..cf04793ab4ea 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -163,6 +163,7 @@ struct mmc_host_ops {
> int (*select_drive_strength)(struct mmc_card *card,
> unsigned int max_dtr, int host_drv,
> int card_drv, int *drv_type);
> + /* Reset remote device via RST_n */
> void (*hw_reset)(struct mmc_host *host);
> void (*card_event)(struct mmc_host *host);
>
> @@ -346,7 +347,7 @@ struct mmc_host {
> #define MMC_CAP_CD_WAKE (1 << 28) /* Enable card detect wake */
> #define MMC_CAP_CMD_DURING_TFR (1 << 29) /* Commands during data transfer */
> #define MMC_CAP_CMD23 (1 << 30) /* CMD23 supported. */
> -#define MMC_CAP_HW_RESET (1 << 31) /* Hardware reset */
> +#define MMC_CAP_HW_RESET (1 << 31) /* supports device reset via RST_n */
>
> u32 caps2; /* More host capabilities */
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-24 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21 6:35 [PATCH] mmc: improve documentation of HW_RESET Wolfram Sang
2020-08-24 9:51 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.