From: Joerg Roedel <jroedel@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
linux-mm@kvack.org, Pavel Machek <pavel@ucw.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dave Airlie <airlied@redhat.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Vrabel <david.vrabel@citrix.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm: Track page table modifications in __apply_to_page_range() construction
Date: Fri, 21 Aug 2020 14:18:16 +0200 [thread overview]
Message-ID: <20200821121816.GJ3354@suse.de> (raw)
In-Reply-To: <159800988352.29194.8498025838223804532@build.alporthouse.com>
On Fri, Aug 21, 2020 at 12:38:03PM +0100, Chris Wilson wrote:
> In the version I tested, I also had
>
> @@ -2216,7 +2216,7 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
>
> if (create) {
> pte = (mm == &init_mm) ?
> - pte_alloc_kernel(pmd, addr) :
> + pte_alloc_kernel_track(pmd, addr, mask) :
> pte_alloc_map_lock(mm, pmd, addr, &ptl);
> if (!pte)
> return -ENOMEM;
>
> And that PGTBL_PMD_MODIFIED makes a difference.
Right, thanks. Added that too.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <jroedel@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, linux-mm@kvack.org,
David Vrabel <david.vrabel@citrix.com>,
Pavel Machek <pavel@ucw.cz>, Dave Airlie <airlied@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [Intel-gfx] [PATCH] mm: Track page table modifications in __apply_to_page_range() construction
Date: Fri, 21 Aug 2020 14:18:16 +0200 [thread overview]
Message-ID: <20200821121816.GJ3354@suse.de> (raw)
In-Reply-To: <159800988352.29194.8498025838223804532@build.alporthouse.com>
On Fri, Aug 21, 2020 at 12:38:03PM +0100, Chris Wilson wrote:
> In the version I tested, I also had
>
> @@ -2216,7 +2216,7 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
>
> if (create) {
> pte = (mm == &init_mm) ?
> - pte_alloc_kernel(pmd, addr) :
> + pte_alloc_kernel_track(pmd, addr, mask) :
> pte_alloc_map_lock(mm, pmd, addr, &ptl);
> if (!pte)
> return -ENOMEM;
>
> And that PGTBL_PMD_MODIFIED makes a difference.
Right, thanks. Added that too.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-21 12:19 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 8:50 [PATCH 1/4] mm: Export flush_vm_area() to sync the PTEs upon construction Chris Wilson
2020-08-21 8:50 ` [Intel-gfx] " Chris Wilson
2020-08-21 8:50 ` [PATCH 2/4] drm/i915/gem: Sync the vmap " Chris Wilson
2020-08-21 8:50 ` [Intel-gfx] " Chris Wilson
2020-08-21 12:41 ` Linus Torvalds
2020-08-21 12:41 ` [Intel-gfx] " Linus Torvalds
2020-08-21 12:41 ` Linus Torvalds
2020-08-21 13:01 ` Chris Wilson
2020-08-21 13:01 ` [Intel-gfx] " Chris Wilson
2020-08-21 8:50 ` [PATCH 3/4] drm/i915/gem: Use set_pte_at() for assigning the vmapped PTE Chris Wilson
2020-08-21 8:50 ` [Intel-gfx] " Chris Wilson
2020-08-21 8:50 ` [PATCH 4/4] drm/i915/gem: Replace reloc chain with terminator on error unwind Chris Wilson
2020-08-21 8:50 ` [Intel-gfx] " Chris Wilson
2020-08-21 9:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] mm: Export flush_vm_area() to sync the PTEs upon construction Patchwork
2020-08-21 9:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-08-21 9:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-21 9:51 ` [PATCH 1/4] " Joerg Roedel
2020-08-21 9:51 ` [Intel-gfx] " Joerg Roedel
2020-08-21 9:54 ` Chris Wilson
2020-08-21 9:54 ` [Intel-gfx] " Chris Wilson
2020-08-21 10:22 ` Joerg Roedel
2020-08-21 10:22 ` [Intel-gfx] " Joerg Roedel
2020-08-21 10:36 ` Chris Wilson
2020-08-21 10:36 ` [Intel-gfx] " Chris Wilson
2020-08-21 10:09 ` [PATCH] mm: Track page table modifications in __apply_to_page_range() construction Joerg Roedel
2020-08-21 10:09 ` [Intel-gfx] " Joerg Roedel
2020-08-21 10:13 ` Chris Wilson
2020-08-21 10:13 ` [Intel-gfx] " Chris Wilson
2020-08-21 10:23 ` Joerg Roedel
2020-08-21 10:23 ` [Intel-gfx] " Joerg Roedel
2020-08-21 10:39 ` Chris Wilson
2020-08-21 10:39 ` [Intel-gfx] " Chris Wilson
2020-08-21 11:38 ` Chris Wilson
2020-08-21 11:38 ` [Intel-gfx] " Chris Wilson
2020-08-21 12:18 ` Joerg Roedel [this message]
2020-08-21 12:18 ` Joerg Roedel
2020-08-21 10:53 ` Greg KH
2020-08-21 10:53 ` [Intel-gfx] " Greg KH
2020-08-21 10:27 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with mm: Track page table modifications in __apply_to_page_range() construction (rev2) Patchwork
2020-08-21 11:33 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] mm: Export flush_vm_area() to sync the PTEs upon construction Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821121816.GJ3354@suse.de \
--to=jroedel@suse.de \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=david.vrabel@citrix.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
--cc=rodrigo.vivi@intel.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.