[vincent.guittot:sched/pelt 6/7] kernel/sched/fair.c:9431:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool

[vincent.guittot:sched/pelt 6/7] kernel/sched/fair.c:9431:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

tree:   https://git.linaro.org/people/vincent.guittot/kernel.git sched/pelt
head:   eeef063fbfa2e18600421f9c78b3a07ded3ec081
commit: 8be8caab247c40a969162f691661489571484544 [6/7] sched/fair: reduce cases for active balance
config: x86_64-randconfig-c002-20200820 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> kernel/sched/fair.c:9431:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28114 bytes --]

[PATCH] sched/fair: fix boolreturn.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

From: kernel test robot <lkp@intel.com>

kernel/sched/fair.c:9431:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 8be8caab247c ("sched/fair: reduce cases for active balance")
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.linaro.org/people/vincent.guittot/kernel.git sched/pelt
head:   eeef063fbfa2e18600421f9c78b3a07ded3ec081
commit: 8be8caab247c40a969162f691661489571484544 [6/7] sched/fair: reduce cases for active balance

 fair.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9428,9 +9428,9 @@ imbalanced_active_balance(struct lb_env
 
 	if ((env->migration_type == migrate_task) &&
 		(sd->nr_balance_failed > sd->cache_nice_tries+2))
-		return 1;
+		return true;
 
-	return 0;
+	return false;
 }
 
 static int need_active_balance(struct lb_env *env)