* [PATCH] meson: drop keymaps symlink
@ 2020-08-24 7:40 Gerd Hoffmann
2020-08-24 8:34 ` Klaus Jensen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2020-08-24 7:40 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
We are building the keymaps by default now. Drop the keymaps symlink
so the generated files are actually written to the build tree not the
source tree.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 67832e3bab76..428fa33be140 100755
--- a/configure
+++ b/configure
@@ -8119,7 +8119,7 @@ DIRS="$DIRS roms/seabios"
LINKS="Makefile"
LINKS="$LINKS tests/tcg/lm32/Makefile"
LINKS="$LINKS tests/tcg/Makefile.target"
-LINKS="$LINKS pc-bios/optionrom/Makefile pc-bios/keymaps"
+LINKS="$LINKS pc-bios/optionrom/Makefile"
LINKS="$LINKS pc-bios/s390-ccw/Makefile"
LINKS="$LINKS roms/seabios/Makefile"
LINKS="$LINKS pc-bios/qemu-icon.bmp"
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] meson: drop keymaps symlink
2020-08-24 7:40 [PATCH] meson: drop keymaps symlink Gerd Hoffmann
@ 2020-08-24 8:34 ` Klaus Jensen
2020-08-24 14:36 ` Bin Meng
2020-08-24 22:27 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Klaus Jensen @ 2020-08-24 8:34 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
On Aug 24 09:40, Gerd Hoffmann wrote:
> We are building the keymaps by default now. Drop the keymaps symlink
> so the generated files are actually written to the build tree not the
> source tree.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 67832e3bab76..428fa33be140 100755
> --- a/configure
> +++ b/configure
> @@ -8119,7 +8119,7 @@ DIRS="$DIRS roms/seabios"
> LINKS="Makefile"
> LINKS="$LINKS tests/tcg/lm32/Makefile"
> LINKS="$LINKS tests/tcg/Makefile.target"
> -LINKS="$LINKS pc-bios/optionrom/Makefile pc-bios/keymaps"
> +LINKS="$LINKS pc-bios/optionrom/Makefile"
> LINKS="$LINKS pc-bios/s390-ccw/Makefile"
> LINKS="$LINKS roms/seabios/Makefile"
> LINKS="$LINKS pc-bios/qemu-icon.bmp"
> --
> 2.27.0
>
Tested-by: Klaus Jensen <k.jensen@samsung.com>
Awesome! This fixes cluttering of the source tree with changed
pc-bios/keymaps/ files for me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meson: drop keymaps symlink
2020-08-24 7:40 [PATCH] meson: drop keymaps symlink Gerd Hoffmann
2020-08-24 8:34 ` Klaus Jensen
@ 2020-08-24 14:36 ` Bin Meng
2020-08-24 22:27 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2020-08-24 14:36 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel@nongnu.org Developers
On Mon, Aug 24, 2020 at 3:42 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> We are building the keymaps by default now. Drop the keymaps symlink
> so the generated files are actually written to the build tree not the
> source tree.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 67832e3bab76..428fa33be140 100755
> --- a/configure
> +++ b/configure
> @@ -8119,7 +8119,7 @@ DIRS="$DIRS roms/seabios"
> LINKS="Makefile"
> LINKS="$LINKS tests/tcg/lm32/Makefile"
> LINKS="$LINKS tests/tcg/Makefile.target"
> -LINKS="$LINKS pc-bios/optionrom/Makefile pc-bios/keymaps"
> +LINKS="$LINKS pc-bios/optionrom/Makefile"
> LINKS="$LINKS pc-bios/s390-ccw/Makefile"
> LINKS="$LINKS roms/seabios/Makefile"
> LINKS="$LINKS pc-bios/qemu-icon.bmp"
This fixes the annoying pc-bios/keymaps/* file changes every time
after a new build. Thanks!
Tested-by: Bin Meng <bin.meng@windriver.com>
Regards,
Bin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meson: drop keymaps symlink
2020-08-24 7:40 [PATCH] meson: drop keymaps symlink Gerd Hoffmann
2020-08-24 8:34 ` Klaus Jensen
2020-08-24 14:36 ` Bin Meng
@ 2020-08-24 22:27 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2020-08-24 22:27 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel@nongnu.org Developers
On Mon, Aug 24, 2020 at 12:42 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> We are building the keymaps by default now. Drop the keymaps symlink
> so the generated files are actually written to the build tree not the
> source tree.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 67832e3bab76..428fa33be140 100755
> --- a/configure
> +++ b/configure
> @@ -8119,7 +8119,7 @@ DIRS="$DIRS roms/seabios"
> LINKS="Makefile"
> LINKS="$LINKS tests/tcg/lm32/Makefile"
> LINKS="$LINKS tests/tcg/Makefile.target"
> -LINKS="$LINKS pc-bios/optionrom/Makefile pc-bios/keymaps"
> +LINKS="$LINKS pc-bios/optionrom/Makefile"
> LINKS="$LINKS pc-bios/s390-ccw/Makefile"
> LINKS="$LINKS roms/seabios/Makefile"
> LINKS="$LINKS pc-bios/qemu-icon.bmp"
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-24 22:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 7:40 [PATCH] meson: drop keymaps symlink Gerd Hoffmann
2020-08-24 8:34 ` Klaus Jensen
2020-08-24 14:36 ` Bin Meng
2020-08-24 22:27 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.