* [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
@ 2020-08-24 8:04 Ye Bin
2020-08-24 8:21 ` Greg KH
0 siblings, 1 reply; 12+ messages in thread
From: Ye Bin @ 2020-08-24 8:04 UTC (permalink / raw)
To: leoyang.li, linux-usb, linuxppc-dev; +Cc: Ye Bin
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/usb/gadget/udc/fsl_udc_core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index a6f7b2594c09..3e98740b8cfc 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2439,11 +2439,12 @@ static int fsl_udc_probe(struct platform_device *pdev)
/* DEN is bidirectional ep number, max_ep doubles the number */
udc_controller->max_ep = (dccparams & DCCPARAMS_DEN_MASK) * 2;
- udc_controller->irq = platform_get_irq(pdev, 0);
- if (udc_controller->irq <= 0) {
- ret = udc_controller->irq ? : -ENODEV;
+ ret = platform_get_irq(pdev, 0);
+ if (ret <= 0) {
+ ret = ret ? : -ENODEV;
goto err_iounmap;
}
+ udc_controller->irq = ret;
ret = request_irq(udc_controller->irq, fsl_udc_irq, IRQF_SHARED,
driver_name, udc_controller);
--
2.25.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
2020-08-24 8:04 [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe Ye Bin
@ 2020-08-24 8:21 ` Greg KH
0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2020-08-24 8:21 UTC (permalink / raw)
To: Ye Bin; +Cc: leoyang.li, linux-usb, linuxppc-dev
On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
> Signed-off-by: Ye Bin <yebin10@huawei.com>
I can't take patches without any changelog text, sorry.
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
@ 2020-08-24 8:21 ` Greg KH
0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2020-08-24 8:21 UTC (permalink / raw)
To: Ye Bin; +Cc: linux-usb, linuxppc-dev, leoyang.li
On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
> Signed-off-by: Ye Bin <yebin10@huawei.com>
I can't take patches without any changelog text, sorry.
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
2020-08-24 8:21 ` Greg KH
@ 2020-08-24 8:49 ` Joakim Tjernlund
-1 siblings, 0 replies; 12+ messages in thread
From: Joakim Tjernlund @ 2020-08-24 8:49 UTC (permalink / raw)
To: yebin10, gregkh; +Cc: linuxppc-dev, leoyang.li, linux-usb
On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
>
> On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
> > Signed-off-by: Ye Bin <yebin10@huawei.com>
>
> I can't take patches without any changelog text, sorry.
Still taking patches for fsl_udc_core.c ?
I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
Jocke
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
@ 2020-08-24 8:49 ` Joakim Tjernlund
0 siblings, 0 replies; 12+ messages in thread
From: Joakim Tjernlund @ 2020-08-24 8:49 UTC (permalink / raw)
To: yebin10, gregkh; +Cc: linux-usb, linuxppc-dev, leoyang.li
On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
>
> On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
> > Signed-off-by: Ye Bin <yebin10@huawei.com>
>
> I can't take patches without any changelog text, sorry.
Still taking patches for fsl_udc_core.c ?
I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
Jocke
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
2020-08-24 8:49 ` Joakim Tjernlund
@ 2020-08-24 13:58 ` Felipe Balbi
-1 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2020-08-24 13:58 UTC (permalink / raw)
To: Joakim Tjernlund, yebin10, gregkh; +Cc: linuxppc-dev, leoyang.li, linux-usb
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
> On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
>>
>> On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
>> > Signed-off-by: Ye Bin <yebin10@huawei.com>
>>
>> I can't take patches without any changelog text, sorry.
>
> Still taking patches for fsl_udc_core.c ?
> I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
Nobody sent any patches to switch over the users of this driver to
chipidea. I would love to delete this driver :-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
@ 2020-08-24 13:58 ` Felipe Balbi
0 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2020-08-24 13:58 UTC (permalink / raw)
To: Joakim Tjernlund, yebin10, gregkh; +Cc: linux-usb, linuxppc-dev, leoyang.li
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
> On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
>>
>> On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
>> > Signed-off-by: Ye Bin <yebin10@huawei.com>
>>
>> I can't take patches without any changelog text, sorry.
>
> Still taking patches for fsl_udc_core.c ?
> I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
Nobody sent any patches to switch over the users of this driver to
chipidea. I would love to delete this driver :-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
2020-08-24 13:58 ` Felipe Balbi
@ 2020-08-24 14:12 ` Joakim Tjernlund
-1 siblings, 0 replies; 12+ messages in thread
From: Joakim Tjernlund @ 2020-08-24 14:12 UTC (permalink / raw)
To: yebin10, gregkh, balbi; +Cc: linuxppc-dev, leoyang.li, linux-usb
On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote:
> Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
>
> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
> > >
> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
> > > > Signed-off-by: Ye Bin <yebin10@huawei.com>
> > >
> > > I can't take patches without any changelog text, sorry.
> >
> > Still taking patches for fsl_udc_core.c ?
> > I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
>
> Nobody sent any patches to switch over the users of this driver to
> chipidea. I would love to delete this driver :-)
Me too, I got a few local patches here as the driver is quite buggy.
Got to little USB knowledge to switch it over though :(
Jocke
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
@ 2020-08-24 14:12 ` Joakim Tjernlund
0 siblings, 0 replies; 12+ messages in thread
From: Joakim Tjernlund @ 2020-08-24 14:12 UTC (permalink / raw)
To: yebin10, gregkh, balbi; +Cc: linux-usb, linuxppc-dev, leoyang.li
On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote:
> Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
>
> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
> > >
> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
> > > > Signed-off-by: Ye Bin <yebin10@huawei.com>
> > >
> > > I can't take patches without any changelog text, sorry.
> >
> > Still taking patches for fsl_udc_core.c ?
> > I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
>
> Nobody sent any patches to switch over the users of this driver to
> chipidea. I would love to delete this driver :-)
Me too, I got a few local patches here as the driver is quite buggy.
Got to little USB knowledge to switch it over though :(
Jocke
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
2020-08-24 14:12 ` Joakim Tjernlund
@ 2020-08-25 8:53 ` Felipe Balbi
-1 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2020-08-25 8:53 UTC (permalink / raw)
To: Joakim Tjernlund, yebin10, gregkh; +Cc: linuxppc-dev, leoyang.li, linux-usb
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
> On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote:
>> Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
>>
>> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
>> > >
>> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
>> > > > Signed-off-by: Ye Bin <yebin10@huawei.com>
>> > >
>> > > I can't take patches without any changelog text, sorry.
>> >
>> > Still taking patches for fsl_udc_core.c ?
>> > I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
>>
>> Nobody sent any patches to switch over the users of this driver to
>> chipidea. I would love to delete this driver :-)
>
> Me too, I got a few local patches here as the driver is quite buggy.
> Got to little USB knowledge to switch it over though :(
this wouldn't require USB knowledge. It only requires some minor DTS
knowledge and HW for testing.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
@ 2020-08-25 8:53 ` Felipe Balbi
0 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2020-08-25 8:53 UTC (permalink / raw)
To: Joakim Tjernlund, yebin10, gregkh; +Cc: linux-usb, linuxppc-dev, leoyang.li
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
> On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote:
>> Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:
>>
>> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
>> > >
>> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
>> > > > Signed-off-by: Ye Bin <yebin10@huawei.com>
>> > >
>> > > I can't take patches without any changelog text, sorry.
>> >
>> > Still taking patches for fsl_udc_core.c ?
>> > I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
>>
>> Nobody sent any patches to switch over the users of this driver to
>> chipidea. I would love to delete this driver :-)
>
> Me too, I got a few local patches here as the driver is quite buggy.
> Got to little USB knowledge to switch it over though :(
this wouldn't require USB knowledge. It only requires some minor DTS
knowledge and HW for testing.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
2020-08-25 8:53 ` Felipe Balbi
(?)
@ 2020-08-25 9:02 ` Joakim Tjernlund
-1 siblings, 0 replies; 12+ messages in thread
From: Joakim Tjernlund @ 2020-08-25 9:02 UTC (permalink / raw)
To: yebin10, gregkh, balbi; +Cc: linux-usb, linuxppc-dev, leoyang.li
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Tue, 2020-08-25 at 11:53 +0300, Felipe Balbi wrote:
Joakim Tjernlund <Joakim.Tjernlund@infinera.com<mailto:Joakim.Tjernlund@infinera.com>> writes:
> On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote:
>> Joakim Tjernlund <Joakim.Tjernlund@infinera.com<mailto:Joakim.Tjernlund@infinera.com>> writes:
>>
>> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote:
>> > >
>> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote:
>> > > > Signed-off-by: Ye Bin <yebin10@huawei.com<mailto:yebin10@huawei.com>>
>> > >
>> > > I can't take patches without any changelog text, sorry.
>> >
>> > Still taking patches for fsl_udc_core.c ?
>> > I figured this driver was obsolete and should be moved to one of the Chipidea drivers.
>>
>> Nobody sent any patches to switch over the users of this driver to
>> chipidea. I would love to delete this driver :-)
>
> Me too, I got a few local patches here as the driver is quite buggy.
> Got to little USB knowledge to switch it over though :(
this wouldn't require USB knowledge. It only requires some minor DTS
knowledge and HW for testing.
hmm, OK. If it is that simple I may take a crack at it(but then why hasn't NXP already done that ?)
I would need some guidance as to what the involved files are?
Jocke
[-- Attachment #2: Type: text/html, Size: 2927 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-08-25 10:25 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 8:04 [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe Ye Bin
2020-08-24 8:21 ` Greg KH
2020-08-24 8:21 ` Greg KH
2020-08-24 8:49 ` Joakim Tjernlund
2020-08-24 8:49 ` Joakim Tjernlund
2020-08-24 13:58 ` Felipe Balbi
2020-08-24 13:58 ` Felipe Balbi
2020-08-24 14:12 ` Joakim Tjernlund
2020-08-24 14:12 ` Joakim Tjernlund
2020-08-25 8:53 ` Felipe Balbi
2020-08-25 8:53 ` Felipe Balbi
2020-08-25 9:02 ` Joakim Tjernlund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.