* [PATCH v2 4/6] kasan: add tests for timer stack recording
@ 2020-08-24 8:13 ` Walter Wu
0 siblings, 0 replies; 3+ messages in thread
From: Walter Wu @ 2020-08-24 8:13 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov, Matthias Brugger
Cc: kasan-dev, linux-mm, linux-kernel, linux-arm-kernel,
wsd_upstream, linux-mediatek, Walter Wu, Andrey Konovalov
Adds a test to verify timer stack recording and print it
in KASAN report.
The KASAN report was as follows(cleaned up slightly):
BUG: KASAN: use-after-free in kasan_timer_uaf
Freed by task 0:
kasan_save_stack+0x24/0x50
kasan_set_track+0x24/0x38
kasan_set_free_info+0x20/0x40
__kasan_slab_free+0x10c/0x170
kasan_slab_free+0x10/0x18
kfree+0x98/0x270
kasan_timer_function+0x1c/0x28
Last potentially related work creation:
kasan_save_stack+0x24/0x50
kasan_record_tmr_stack+0xa8/0xb8
init_timer_key+0xf0/0x248
kasan_timer_uaf+0x5c/0xd8
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Andrey Konovalov <andreyknvl@google.com>
---
lib/test_kasan.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index 6e5fb05d42d8..2bd61674c7a3 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -821,6 +821,30 @@ static noinline void __init kasan_rcu_uaf(void)
call_rcu(&global_ptr->rcu, kasan_rcu_reclaim);
}
+static noinline void __init kasan_timer_function(struct timer_list *timer)
+{
+ del_timer(timer);
+ kfree(timer);
+}
+
+static noinline void __init kasan_timer_uaf(void)
+{
+ struct timer_list *timer;
+
+ timer = kmalloc(sizeof(struct timer_list), GFP_KERNEL);
+ if (!timer) {
+ pr_err("Allocation failed\n");
+ return;
+ }
+
+ timer_setup(timer, kasan_timer_function, 0);
+ add_timer(timer);
+ msleep(100);
+
+ pr_info("use-after-free on timer\n");
+ ((volatile struct timer_list *)timer)->expires;
+}
+
static int __init kmalloc_tests_init(void)
{
/*
@@ -869,6 +893,7 @@ static int __init kmalloc_tests_init(void)
kmalloc_double_kzfree();
vmalloc_oob();
kasan_rcu_uaf();
+ kasan_timer_uaf();
kasan_restore_multi_shot(multishot);
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 4/6] kasan: add tests for timer stack recording
@ 2020-08-24 8:13 ` Walter Wu
0 siblings, 0 replies; 3+ messages in thread
From: Walter Wu @ 2020-08-24 8:13 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov, Matthias Brugger
Cc: Walter Wu, wsd_upstream, Andrey Konovalov, linux-kernel,
kasan-dev, linux-mm, linux-mediatek, linux-arm-kernel
Adds a test to verify timer stack recording and print it
in KASAN report.
The KASAN report was as follows(cleaned up slightly):
BUG: KASAN: use-after-free in kasan_timer_uaf
Freed by task 0:
kasan_save_stack+0x24/0x50
kasan_set_track+0x24/0x38
kasan_set_free_info+0x20/0x40
__kasan_slab_free+0x10c/0x170
kasan_slab_free+0x10/0x18
kfree+0x98/0x270
kasan_timer_function+0x1c/0x28
Last potentially related work creation:
kasan_save_stack+0x24/0x50
kasan_record_tmr_stack+0xa8/0xb8
init_timer_key+0xf0/0x248
kasan_timer_uaf+0x5c/0xd8
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Andrey Konovalov <andreyknvl@google.com>
---
lib/test_kasan.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index 6e5fb05d42d8..2bd61674c7a3 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -821,6 +821,30 @@ static noinline void __init kasan_rcu_uaf(void)
call_rcu(&global_ptr->rcu, kasan_rcu_reclaim);
}
+static noinline void __init kasan_timer_function(struct timer_list *timer)
+{
+ del_timer(timer);
+ kfree(timer);
+}
+
+static noinline void __init kasan_timer_uaf(void)
+{
+ struct timer_list *timer;
+
+ timer = kmalloc(sizeof(struct timer_list), GFP_KERNEL);
+ if (!timer) {
+ pr_err("Allocation failed\n");
+ return;
+ }
+
+ timer_setup(timer, kasan_timer_function, 0);
+ add_timer(timer);
+ msleep(100);
+
+ pr_info("use-after-free on timer\n");
+ ((volatile struct timer_list *)timer)->expires;
+}
+
static int __init kmalloc_tests_init(void)
{
/*
@@ -869,6 +893,7 @@ static int __init kmalloc_tests_init(void)
kmalloc_double_kzfree();
vmalloc_oob();
kasan_rcu_uaf();
+ kasan_timer_uaf();
kasan_restore_multi_shot(multishot);
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 4/6] kasan: add tests for timer stack recording
@ 2020-08-24 8:13 ` Walter Wu
0 siblings, 0 replies; 3+ messages in thread
From: Walter Wu @ 2020-08-24 8:13 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov, Matthias Brugger
Cc: Walter Wu, wsd_upstream, Andrey Konovalov, linux-kernel,
kasan-dev, linux-mm, linux-mediatek, linux-arm-kernel
Adds a test to verify timer stack recording and print it
in KASAN report.
The KASAN report was as follows(cleaned up slightly):
BUG: KASAN: use-after-free in kasan_timer_uaf
Freed by task 0:
kasan_save_stack+0x24/0x50
kasan_set_track+0x24/0x38
kasan_set_free_info+0x20/0x40
__kasan_slab_free+0x10c/0x170
kasan_slab_free+0x10/0x18
kfree+0x98/0x270
kasan_timer_function+0x1c/0x28
Last potentially related work creation:
kasan_save_stack+0x24/0x50
kasan_record_tmr_stack+0xa8/0xb8
init_timer_key+0xf0/0x248
kasan_timer_uaf+0x5c/0xd8
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Andrey Konovalov <andreyknvl@google.com>
---
lib/test_kasan.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index 6e5fb05d42d8..2bd61674c7a3 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -821,6 +821,30 @@ static noinline void __init kasan_rcu_uaf(void)
call_rcu(&global_ptr->rcu, kasan_rcu_reclaim);
}
+static noinline void __init kasan_timer_function(struct timer_list *timer)
+{
+ del_timer(timer);
+ kfree(timer);
+}
+
+static noinline void __init kasan_timer_uaf(void)
+{
+ struct timer_list *timer;
+
+ timer = kmalloc(sizeof(struct timer_list), GFP_KERNEL);
+ if (!timer) {
+ pr_err("Allocation failed\n");
+ return;
+ }
+
+ timer_setup(timer, kasan_timer_function, 0);
+ add_timer(timer);
+ msleep(100);
+
+ pr_info("use-after-free on timer\n");
+ ((volatile struct timer_list *)timer)->expires;
+}
+
static int __init kmalloc_tests_init(void)
{
/*
@@ -869,6 +893,7 @@ static int __init kmalloc_tests_init(void)
kmalloc_double_kzfree();
vmalloc_oob();
kasan_rcu_uaf();
+ kasan_timer_uaf();
kasan_restore_multi_shot(multishot);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-24 8:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 8:13 [PATCH v2 4/6] kasan: add tests for timer stack recording Walter Wu
2020-08-24 8:13 ` Walter Wu
2020-08-24 8:13 ` Walter Wu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.