Re: [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote:
> On 8/24/2020 2:36 PM, Ed Czeck wrote:
> > Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG,
> > PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG.
> > Review and adjust log levels and messages as needed.
> > 
> > Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> > ---
> >  doc/guides/nics/ark.rst         | 13 ------
> >  drivers/net/ark/ark_ddm.c       | 12 ++---
> >  drivers/net/ark/ark_ethdev.c    | 77 +++++++++++++++------------------
> >  drivers/net/ark/ark_ethdev_rx.c | 46 ++++++++++----------
> >  drivers/net/ark/ark_ethdev_tx.c | 10 ++---
> >  drivers/net/ark/ark_logs.h      | 63 +++------------------------
> >  drivers/net/ark/ark_mpu.c       | 32 ++++----------
> >  drivers/net/ark/ark_pktchkr.c   | 36 +++++++--------
> >  drivers/net/ark/ark_pktdir.c    |  2 +-
> >  drivers/net/ark/ark_pktgen.c    | 22 +++++-----
> >  drivers/net/ark/ark_rqp.c       |  4 +-
> >  drivers/net/ark/ark_udm.c       | 18 ++++----
> >  12 files changed, 125 insertions(+), 210 deletions(-)
> > 
> > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> > index 06e8c3374..c3ffcbbc2 100644
> > --- a/doc/guides/nics/ark.rst
> > +++ b/doc/guides/nics/ark.rst
> > @@ -132,19 +132,6 @@ Configuration Information
> >     * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y):  When enabled TX
> >       packets are padded to 60 bytes to support downstream MACS.
> >  
> > -   * **CONFIG_RTE_LIBRTE_ARK_DEBUG_RX** (default n): Enables or disables debug
> > -     logging and internal checking of RX ingress logic within the ARK PMD driver.
> > -
> > -   * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TX** (default n): Enables or disables debug
> > -     logging and internal checking of TX egress logic within the ARK PMD driver.
> > -
> > -   * **CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS** (default n): Enables or disables debug
> > -     logging of detailed packet and performance statistics gathered in
> > -     the PMD and FPGA.
> > -
> > -   * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE** (default n): Enables or disables debug
> > -     logging of detailed PMD events and status.
> > -
> 
> Can you please remove these config option from 'config/common_base'?
> 
Given that the file is scheduled for deletion fairly soon, not sure if that
is worthwhile doing.