From: Jean-Philippe Brucker <jean-philippe@linaro.org> To: Jacob Pan <jacob.pan.linux@gmail.com> Cc: iommu@lists.linux-foundation.org, LKML <linux-kernel@vger.kernel.org>, Jean-Philippe Brucker <jean-philippe@linaro.com>, Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Yi Liu <yi.l.liu@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>, Raj Ashok <ashok.raj@intel.com>, Eric Auger <eric.auger@redhat.com>, Wu Hao <hao.wu@intel.com> Subject: Re: [PATCH v2 2/9] iommu/ioasid: Rename ioasid_set_data() Date: Mon, 24 Aug 2020 20:29:31 +0200 [thread overview] Message-ID: <20200824182931.GC3210689@myrica> (raw) In-Reply-To: <1598070918-21321-3-git-send-email-jacob.jun.pan@linux.intel.com> On Fri, Aug 21, 2020 at 09:35:11PM -0700, Jacob Pan wrote: > Rename ioasid_set_data() to ioasid_attach_data() to avoid confusion with > struct ioasid_set. ioasid_set is a group of IOASIDs that share a common > token. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- > drivers/iommu/intel/svm.c | 6 +++--- > drivers/iommu/ioasid.c | 6 +++--- > include/linux/ioasid.h | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c > index b6972dca2ae0..37a9beabc0ca 100644 > --- a/drivers/iommu/intel/svm.c > +++ b/drivers/iommu/intel/svm.c > @@ -342,7 +342,7 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, > svm->gpasid = data->gpasid; > svm->flags |= SVM_FLAG_GUEST_PASID; > } > - ioasid_set_data(data->hpasid, svm); > + ioasid_attach_data(data->hpasid, svm); > INIT_LIST_HEAD_RCU(&svm->devs); > mmput(svm->mm); > } > @@ -394,7 +394,7 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, > list_add_rcu(&sdev->list, &svm->devs); > out: > if (!IS_ERR_OR_NULL(svm) && list_empty(&svm->devs)) { > - ioasid_set_data(data->hpasid, NULL); > + ioasid_attach_data(data->hpasid, NULL); > kfree(svm); > } > > @@ -437,7 +437,7 @@ int intel_svm_unbind_gpasid(struct device *dev, int pasid) > * the unbind, IOMMU driver will get notified > * and perform cleanup. > */ > - ioasid_set_data(pasid, NULL); > + ioasid_attach_data(pasid, NULL); > kfree(svm); > } > } > diff --git a/drivers/iommu/ioasid.c b/drivers/iommu/ioasid.c > index 0f8dd377aada..5f63af07acd5 100644 > --- a/drivers/iommu/ioasid.c > +++ b/drivers/iommu/ioasid.c > @@ -258,14 +258,14 @@ void ioasid_unregister_allocator(struct ioasid_allocator_ops *ops) > EXPORT_SYMBOL_GPL(ioasid_unregister_allocator); > > /** > - * ioasid_set_data - Set private data for an allocated ioasid > + * ioasid_attach_data - Set private data for an allocated ioasid > * @ioasid: the ID to set data > * @data: the private data > * > * For IOASID that is already allocated, private data can be set > * via this API. Future lookup can be done via ioasid_find. > */ > -int ioasid_set_data(ioasid_t ioasid, void *data) > +int ioasid_attach_data(ioasid_t ioasid, void *data) > { > struct ioasid_data *ioasid_data; > int ret = 0; > @@ -287,7 +287,7 @@ int ioasid_set_data(ioasid_t ioasid, void *data) > > return ret; > } > -EXPORT_SYMBOL_GPL(ioasid_set_data); > +EXPORT_SYMBOL_GPL(ioasid_attach_data); > > /** > * ioasid_alloc - Allocate an IOASID > diff --git a/include/linux/ioasid.h b/include/linux/ioasid.h > index 6f000d7a0ddc..9c44947a68c8 100644 > --- a/include/linux/ioasid.h > +++ b/include/linux/ioasid.h > @@ -39,7 +39,7 @@ void *ioasid_find(struct ioasid_set *set, ioasid_t ioasid, > bool (*getter)(void *)); > int ioasid_register_allocator(struct ioasid_allocator_ops *allocator); > void ioasid_unregister_allocator(struct ioasid_allocator_ops *allocator); > -int ioasid_set_data(ioasid_t ioasid, void *data); > +int ioasid_attach_data(ioasid_t ioasid, void *data); > > #else /* !CONFIG_IOASID */ > static inline ioasid_t ioasid_alloc(struct ioasid_set *set, ioasid_t min, > @@ -67,7 +67,7 @@ static inline void ioasid_unregister_allocator(struct ioasid_allocator_ops *allo > { > } > > -static inline int ioasid_set_data(ioasid_t ioasid, void *data) > +static inline int ioasid_attach_data(ioasid_t ioasid, void *data) > { > return -ENOTSUPP; > } > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe@linaro.org> To: Jacob Pan <jacob.pan.linux@gmail.com> Cc: "Tian, Kevin" <kevin.tian@intel.com>, Raj Ashok <ashok.raj@intel.com>, Jean-Philippe Brucker <jean-philippe@linaro.com>, LKML <linux-kernel@vger.kernel.org>, iommu@lists.linux-foundation.org, Wu Hao <hao.wu@intel.com>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [PATCH v2 2/9] iommu/ioasid: Rename ioasid_set_data() Date: Mon, 24 Aug 2020 20:29:31 +0200 [thread overview] Message-ID: <20200824182931.GC3210689@myrica> (raw) In-Reply-To: <1598070918-21321-3-git-send-email-jacob.jun.pan@linux.intel.com> On Fri, Aug 21, 2020 at 09:35:11PM -0700, Jacob Pan wrote: > Rename ioasid_set_data() to ioasid_attach_data() to avoid confusion with > struct ioasid_set. ioasid_set is a group of IOASIDs that share a common > token. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- > drivers/iommu/intel/svm.c | 6 +++--- > drivers/iommu/ioasid.c | 6 +++--- > include/linux/ioasid.h | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c > index b6972dca2ae0..37a9beabc0ca 100644 > --- a/drivers/iommu/intel/svm.c > +++ b/drivers/iommu/intel/svm.c > @@ -342,7 +342,7 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, > svm->gpasid = data->gpasid; > svm->flags |= SVM_FLAG_GUEST_PASID; > } > - ioasid_set_data(data->hpasid, svm); > + ioasid_attach_data(data->hpasid, svm); > INIT_LIST_HEAD_RCU(&svm->devs); > mmput(svm->mm); > } > @@ -394,7 +394,7 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, > list_add_rcu(&sdev->list, &svm->devs); > out: > if (!IS_ERR_OR_NULL(svm) && list_empty(&svm->devs)) { > - ioasid_set_data(data->hpasid, NULL); > + ioasid_attach_data(data->hpasid, NULL); > kfree(svm); > } > > @@ -437,7 +437,7 @@ int intel_svm_unbind_gpasid(struct device *dev, int pasid) > * the unbind, IOMMU driver will get notified > * and perform cleanup. > */ > - ioasid_set_data(pasid, NULL); > + ioasid_attach_data(pasid, NULL); > kfree(svm); > } > } > diff --git a/drivers/iommu/ioasid.c b/drivers/iommu/ioasid.c > index 0f8dd377aada..5f63af07acd5 100644 > --- a/drivers/iommu/ioasid.c > +++ b/drivers/iommu/ioasid.c > @@ -258,14 +258,14 @@ void ioasid_unregister_allocator(struct ioasid_allocator_ops *ops) > EXPORT_SYMBOL_GPL(ioasid_unregister_allocator); > > /** > - * ioasid_set_data - Set private data for an allocated ioasid > + * ioasid_attach_data - Set private data for an allocated ioasid > * @ioasid: the ID to set data > * @data: the private data > * > * For IOASID that is already allocated, private data can be set > * via this API. Future lookup can be done via ioasid_find. > */ > -int ioasid_set_data(ioasid_t ioasid, void *data) > +int ioasid_attach_data(ioasid_t ioasid, void *data) > { > struct ioasid_data *ioasid_data; > int ret = 0; > @@ -287,7 +287,7 @@ int ioasid_set_data(ioasid_t ioasid, void *data) > > return ret; > } > -EXPORT_SYMBOL_GPL(ioasid_set_data); > +EXPORT_SYMBOL_GPL(ioasid_attach_data); > > /** > * ioasid_alloc - Allocate an IOASID > diff --git a/include/linux/ioasid.h b/include/linux/ioasid.h > index 6f000d7a0ddc..9c44947a68c8 100644 > --- a/include/linux/ioasid.h > +++ b/include/linux/ioasid.h > @@ -39,7 +39,7 @@ void *ioasid_find(struct ioasid_set *set, ioasid_t ioasid, > bool (*getter)(void *)); > int ioasid_register_allocator(struct ioasid_allocator_ops *allocator); > void ioasid_unregister_allocator(struct ioasid_allocator_ops *allocator); > -int ioasid_set_data(ioasid_t ioasid, void *data); > +int ioasid_attach_data(ioasid_t ioasid, void *data); > > #else /* !CONFIG_IOASID */ > static inline ioasid_t ioasid_alloc(struct ioasid_set *set, ioasid_t min, > @@ -67,7 +67,7 @@ static inline void ioasid_unregister_allocator(struct ioasid_allocator_ops *allo > { > } > > -static inline int ioasid_set_data(ioasid_t ioasid, void *data) > +static inline int ioasid_attach_data(ioasid_t ioasid, void *data) > { > return -ENOTSUPP; > } > -- > 2.7.4 > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-08-24 18:29 UTC|newest] Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-22 4:35 [PATCH v2 0/9] IOASID extensions for guest SVA Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-22 4:35 ` [PATCH v2 1/9] docs: Document IO Address Space ID (IOASID) APIs Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-23 7:05 ` Lu Baolu 2020-08-23 7:05 ` Lu Baolu 2020-08-28 17:01 ` Jacob Pan 2020-08-28 17:01 ` Jacob Pan 2020-08-24 10:32 ` Jean-Philippe Brucker 2020-08-24 10:32 ` Jean-Philippe Brucker 2020-08-27 16:21 ` Auger Eric 2020-08-27 16:21 ` Auger Eric 2020-09-01 16:56 ` Jacob Pan 2020-09-01 16:56 ` Jacob Pan 2020-09-07 8:03 ` Auger Eric 2020-09-07 8:03 ` Auger Eric 2020-09-08 17:29 ` Jacob Pan 2020-08-28 22:24 ` Jacob Pan 2020-08-28 22:24 ` Jacob Pan 2020-08-22 4:35 ` [PATCH v2 2/9] iommu/ioasid: Rename ioasid_set_data() Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-24 18:29 ` Jean-Philippe Brucker [this message] 2020-08-24 18:29 ` Jean-Philippe Brucker 2020-09-01 11:51 ` Auger Eric 2020-09-01 11:51 ` Auger Eric 2020-08-22 4:35 ` [PATCH v2 3/9] iommu/ioasid: Introduce ioasid_set APIs Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-22 12:53 ` kernel test robot 2020-08-22 12:53 ` kernel test robot 2020-08-22 12:53 ` kernel test robot 2020-08-24 2:24 ` Lu Baolu 2020-08-24 2:24 ` Lu Baolu 2020-09-01 21:28 ` Jacob Pan 2020-09-01 21:28 ` Jacob Pan 2020-09-02 2:39 ` Lu Baolu 2020-09-02 2:39 ` Lu Baolu 2020-08-24 18:28 ` Jean-Philippe Brucker 2020-08-24 18:28 ` Jean-Philippe Brucker 2020-08-24 18:30 ` Randy Dunlap 2020-08-24 18:30 ` Randy Dunlap 2020-09-02 21:46 ` Jacob Pan 2020-09-02 21:46 ` Jacob Pan 2020-08-24 18:34 ` Randy Dunlap 2020-08-24 18:34 ` Randy Dunlap 2020-09-02 21:47 ` Jacob Pan 2020-09-02 21:47 ` Jacob Pan 2020-09-02 21:44 ` Jacob Pan 2020-09-02 21:44 ` Jacob Pan 2020-09-01 11:51 ` Auger Eric 2020-09-01 11:51 ` Auger Eric 2020-09-03 21:07 ` Jacob Pan 2020-09-03 21:07 ` Jacob Pan 2020-09-07 8:04 ` Auger Eric 2020-09-07 8:04 ` Auger Eric 2020-08-22 4:35 ` [PATCH v2 4/9] iommu/ioasid: Add reference couting functions Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-24 2:26 ` Lu Baolu 2020-08-24 2:26 ` Lu Baolu 2020-08-25 10:20 ` Jean-Philippe Brucker 2020-08-25 10:20 ` Jean-Philippe Brucker 2020-08-25 10:19 ` Jean-Philippe Brucker 2020-08-25 10:19 ` Jean-Philippe Brucker 2020-09-08 20:30 ` Jacob Pan 2020-09-01 12:13 ` Auger Eric 2020-09-01 12:13 ` Auger Eric 2020-09-08 20:49 ` Jacob Pan 2020-09-24 18:29 ` Shameerali Kolothum Thodi 2020-09-24 18:29 ` Shameerali Kolothum Thodi 2020-08-22 4:35 ` [PATCH v2 5/9] iommu/ioasid: Introduce ioasid_set private ID Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-22 8:36 ` kernel test robot 2020-08-22 8:36 ` kernel test robot 2020-08-22 8:36 ` kernel test robot 2020-08-22 9:03 ` kernel test robot 2020-08-22 9:03 ` kernel test robot 2020-08-22 9:03 ` kernel test robot 2020-08-25 10:22 ` Jean-Philippe Brucker 2020-08-25 10:22 ` Jean-Philippe Brucker 2020-09-08 22:19 ` Jacob Pan 2020-09-08 22:19 ` Jacob Pan 2020-09-01 15:38 ` Auger Eric 2020-09-01 15:38 ` Auger Eric 2020-09-08 22:40 ` Jacob Pan 2020-09-08 22:40 ` Jacob Pan 2020-09-10 9:18 ` Auger Eric 2020-09-10 9:18 ` Auger Eric 2020-08-22 4:35 ` [PATCH v2 6/9] iommu/ioasid: Introduce notification APIs Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-25 10:26 ` Jean-Philippe Brucker 2020-08-25 10:26 ` Jean-Philippe Brucker 2020-09-09 20:37 ` Jacob Pan 2020-09-09 20:37 ` Jacob Pan 2020-09-01 16:49 ` Auger Eric 2020-09-01 16:49 ` Auger Eric 2020-09-09 22:58 ` Jacob Pan 2020-09-09 22:58 ` Jacob Pan 2020-09-10 8:59 ` Auger Eric 2020-09-10 8:59 ` Auger Eric 2020-08-22 4:35 ` [PATCH v2 7/9] iommu/vt-d: Listen to IOASID notifications Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-09-01 17:03 ` Auger Eric 2020-09-01 17:03 ` Auger Eric 2020-09-10 4:54 ` Jacob Pan 2020-08-22 4:35 ` [PATCH v2 8/9] iommu/vt-d: Send IOASID bind/unbind notifications Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-08-22 4:35 ` [PATCH v2 9/9] iommu/vt-d: Store guest PASID during bind Jacob Pan 2020-08-22 4:35 ` Jacob Pan 2020-09-01 17:08 ` Auger Eric 2020-09-01 17:08 ` Auger Eric 2020-09-10 17:12 ` Jacob Pan 2020-09-10 17:12 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200824182931.GC3210689@myrica \ --to=jean-philippe@linaro.org \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=eric.auger@redhat.com \ --cc=hao.wu@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.pan.linux@gmail.com \ --cc=jean-philippe@linaro.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.