[linux-rt-devel:linux-5.9.y-rt-rebase 190/203] arch/powerpc/platforms/pseries/iommu.c:181:1: warning: parameter names (without types) in function declaration

[linux-rt-devel:linux-5.9.y-rt-rebase 190/203] arch/powerpc/platforms/pseries/iommu.c:181:1: warning: parameter names (without types) in function declaration

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 6509 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.9.y-rt-rebase
head:   e7b17bd805747460961fa525247289b894f57004
commit: da1874b9fde1c352fac21ba0214aaff2cb226e37 [190/203] powerpc/pseries/iommu: Use a locallock instead local_irq_save()
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout da1874b9fde1c352fac21ba0214aaff2cb226e37
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/powerpc/platforms/pseries/iommu.c:181:8: error: type defaults to 'int' in declaration of 'DEFINE_LOCAL_IRQ_LOCK' [-Werror=implicit-int]
     181 | static DEFINE_LOCAL_IRQ_LOCK(tcp_page_lock);
         |        ^~~~~~~~~~~~~~~~~~~~~
>> arch/powerpc/platforms/pseries/iommu.c:181:1: warning: parameter names (without types) in function declaration
     181 | static DEFINE_LOCAL_IRQ_LOCK(tcp_page_lock);
         | ^~~~~~
   In file included from include/asm-generic/percpu.h:7,
                    from arch/powerpc/include/asm/percpu.h:18,
                    from include/linux/irqflags.h:17,
                    from include/linux/spinlock.h:54,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from arch/powerpc/platforms/pseries/iommu.c:15:
   arch/powerpc/platforms/pseries/iommu.c: In function 'tce_buildmulti_pSeriesLP':
   arch/powerpc/platforms/pseries/iommu.c:204:21: error: 'tcp_page_lock' undeclared (first use in this function)
     204 |  local_lock_irqsave(tcp_page_lock, flags);
         |                     ^~~~~~~~~~~~~
   include/linux/percpu-defs.h:219:47: note: in definition of macro '__verify_pcpu_ptr'
     219 |  const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
         |                                               ^~~
   include/linux/percpu-defs.h:252:27: note: in expansion of macro 'raw_cpu_ptr'
     252 | #define this_cpu_ptr(ptr) raw_cpu_ptr(ptr)
         |                           ^~~~~~~~~~~
   include/linux/local_lock_internal.h:163:22: note: in expansion of macro 'this_cpu_ptr'
     163 |   local_lock_acquire(this_cpu_ptr(lock));  \
         |                      ^~~~~~~~~~~~
   include/linux/local_lock.h:31:2: note: in expansion of macro '__local_lock_irqsave'
      31 |  __local_lock_irqsave(lock, flags)
         |  ^~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/iommu.c:204:2: note: in expansion of macro 'local_lock_irqsave'
     204 |  local_lock_irqsave(tcp_page_lock, flags);
         |  ^~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/iommu.c:204:21: note: each undeclared identifier is reported only once for each function it appears in
     204 |  local_lock_irqsave(tcp_page_lock, flags);
         |                     ^~~~~~~~~~~~~
   include/linux/percpu-defs.h:219:47: note: in definition of macro '__verify_pcpu_ptr'
     219 |  const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
         |                                               ^~~
   include/linux/percpu-defs.h:252:27: note: in expansion of macro 'raw_cpu_ptr'
     252 | #define this_cpu_ptr(ptr) raw_cpu_ptr(ptr)
         |                           ^~~~~~~~~~~
   include/linux/local_lock_internal.h:163:22: note: in expansion of macro 'this_cpu_ptr'
     163 |   local_lock_acquire(this_cpu_ptr(lock));  \
         |                      ^~~~~~~~~~~~
   include/linux/local_lock.h:31:2: note: in expansion of macro '__local_lock_irqsave'
      31 |  __local_lock_irqsave(lock, flags)
         |  ^~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/iommu.c:204:2: note: in expansion of macro 'local_lock_irqsave'
     204 |  local_lock_irqsave(tcp_page_lock, flags);
         |  ^~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/iommu.c: In function 'tce_setrange_multi_pSeriesLP':
   arch/powerpc/platforms/pseries/iommu.c:422:17: error: 'tcp_page_lock' undeclared (first use in this function)
     422 |  local_lock_irq(tcp_page_lock);
         |                 ^~~~~~~~~~~~~
   include/linux/percpu-defs.h:219:47: note: in definition of macro '__verify_pcpu_ptr'
     219 |  const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
         |                                               ^~~
   include/linux/percpu-defs.h:252:27: note: in expansion of macro 'raw_cpu_ptr'
     252 | #define this_cpu_ptr(ptr) raw_cpu_ptr(ptr)
         |                           ^~~~~~~~~~~
   include/linux/local_lock_internal.h:157:22: note: in expansion of macro 'this_cpu_ptr'
     157 |   local_lock_acquire(this_cpu_ptr(lock));  \
         |                      ^~~~~~~~~~~~
   include/linux/local_lock.h:22:31: note: in expansion of macro '__local_lock_irq'
      22 | #define local_lock_irq(lock)  __local_lock_irq(lock)
         |                               ^~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/iommu.c:422:2: note: in expansion of macro 'local_lock_irq'
     422 |  local_lock_irq(tcp_page_lock);
         |  ^~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/iommu.c: At top level:
   arch/powerpc/platforms/pseries/iommu.c:181:8: warning: 'DEFINE_LOCAL_IRQ_LOCK' declared 'static' but never defined [-Wunused-function]
     181 | static DEFINE_LOCAL_IRQ_LOCK(tcp_page_lock);
         |        ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

# https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=da1874b9fde1c352fac21ba0214aaff2cb226e37
git remote add linux-rt-devel https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
git fetch --no-tags linux-rt-devel linux-5.9.y-rt-rebase
git checkout da1874b9fde1c352fac21ba0214aaff2cb226e37
vim +181 arch/powerpc/platforms/pseries/iommu.c

   179	
   180	static DEFINE_PER_CPU(__be64 *, tce_page);
 > 181	static DEFINE_LOCAL_IRQ_LOCK(tcp_page_lock);
   182	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 70387 bytes --]