* [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h>
@ 2020-08-24 14:09 Fabio Estevam
2020-08-24 15:11 ` Ard Biesheuvel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2020-08-24 14:09 UTC (permalink / raw)
To: herbert; +Cc: Jason, linux, linux-crypto, ardb, Fabio Estevam
Building ARM allmodconfig leads to the following warnings:
arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration]
arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration]
arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]
Include <linux/scatterlist.h> to fix such warnings
Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/crypto/curve25519-glue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/crypto/curve25519-glue.c b/arch/arm/crypto/curve25519-glue.c
index 776ae07e0469..31eb75b6002f 100644
--- a/arch/arm/crypto/curve25519-glue.c
+++ b/arch/arm/crypto/curve25519-glue.c
@@ -16,6 +16,7 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/jump_label.h>
+#include <linux/scatterlist.h>
#include <crypto/curve25519.h>
asmlinkage void curve25519_neon(u8 mypublic[CURVE25519_KEY_SIZE],
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h>
2020-08-24 14:09 [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h> Fabio Estevam
@ 2020-08-24 15:11 ` Ard Biesheuvel
2020-08-24 19:42 ` Jason A. Donenfeld
2020-08-25 1:53 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-08-24 15:11 UTC (permalink / raw)
To: Fabio Estevam
Cc: Herbert Xu, Jason A. Donenfeld, Russell King, Linux Crypto Mailing List
On Mon, 24 Aug 2020 at 16:13, Fabio Estevam <festevam@gmail.com> wrote:
>
> Building ARM allmodconfig leads to the following warnings:
>
> arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration]
> arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration]
> arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]
>
> Include <linux/scatterlist.h> to fix such warnings
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Thanks for the fix - I just hit this as well.
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm/crypto/curve25519-glue.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/crypto/curve25519-glue.c b/arch/arm/crypto/curve25519-glue.c
> index 776ae07e0469..31eb75b6002f 100644
> --- a/arch/arm/crypto/curve25519-glue.c
> +++ b/arch/arm/crypto/curve25519-glue.c
> @@ -16,6 +16,7 @@
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/jump_label.h>
> +#include <linux/scatterlist.h>
> #include <crypto/curve25519.h>
>
> asmlinkage void curve25519_neon(u8 mypublic[CURVE25519_KEY_SIZE],
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h>
2020-08-24 14:09 [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h> Fabio Estevam
2020-08-24 15:11 ` Ard Biesheuvel
@ 2020-08-24 19:42 ` Jason A. Donenfeld
2020-08-25 1:53 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Jason A. Donenfeld @ 2020-08-24 19:42 UTC (permalink / raw)
To: Fabio Estevam
Cc: Herbert Xu, Russell King - ARM Linux, Linux Crypto Mailing List,
Ard Biesheuvel
On Mon, Aug 24, 2020 at 4:13 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Building ARM allmodconfig leads to the following warnings:
>
> arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration]
> arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration]
> arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]
>
> Include <linux/scatterlist.h> to fix such warnings
This patch seems correct to me -- sg_copy_to_buffer, sg_nents_for_len.
I wonder what header dependency chain caused us to miss this before.
Either way,
Acked-by: Jason A. Donenfeld <Jason@zx2c4.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h>
2020-08-24 14:09 [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h> Fabio Estevam
2020-08-24 15:11 ` Ard Biesheuvel
2020-08-24 19:42 ` Jason A. Donenfeld
@ 2020-08-25 1:53 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-08-25 1:53 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Jason, linux, linux-crypto, ardb
On Mon, Aug 24, 2020 at 11:09:53AM -0300, Fabio Estevam wrote:
> Building ARM allmodconfig leads to the following warnings:
>
> arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration]
> arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration]
> arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]
>
> Include <linux/scatterlist.h> to fix such warnings
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/crypto/curve25519-glue.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-25 1:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 14:09 [PATCH] crypto: arm/curve25519 - include <linux/scatterlist.h> Fabio Estevam
2020-08-24 15:11 ` Ard Biesheuvel
2020-08-24 19:42 ` Jason A. Donenfeld
2020-08-25 1:53 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.