* [hch-block:gendisk-lookup 17/19] drivers/block/floppy.c:4110:42: warning: variable 'new_dev' is uninitialized when used here
@ 2020-08-24 20:55 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-08-24 20:55 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 9615 bytes --]
tree: git://git.infradead.org/users/hch/block.git gendisk-lookup
head: fb73c864e566d8e46b8c75caa3a455674548308d
commit: 6bc1ba7d09b8e4e5d4915592fb1430b640b86599 [17/19] floppy: remove support for "alias" minors
config: x86_64-randconfig-a003-20200824 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b587ca93be114d07ec3bf654add97d7872325281)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 6bc1ba7d09b8e4e5d4915592fb1430b640b86599
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/block/floppy.c:4110:42: warning: variable 'new_dev' is uninitialized when used here [-Wuninitialized]
set_capacity(disks[drive], floppy_sizes[new_dev]);
^~~~~~~
drivers/block/floppy.c:4058:22: note: initialize the variable 'new_dev' to silence this warning
int old_dev, new_dev;
^
= 0
1 warning generated.
git remote add hch-block git://git.infradead.org/users/hch/block.git
git fetch --no-tags hch-block gendisk-lookup
git checkout 6bc1ba7d09b8e4e5d4915592fb1430b640b86599
vim +/new_dev +4110 drivers/block/floppy.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 4049
^1da177e4c3f41 Linus Torvalds 2005-04-16 4050 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 4051 * floppy_open check for aliasing (/dev/fd0 can be the same as
^1da177e4c3f41 Linus Torvalds 2005-04-16 4052 * /dev/PS0 etc), and disallows simultaneous access to the same
^1da177e4c3f41 Linus Torvalds 2005-04-16 4053 * drive with different device numbers.
^1da177e4c3f41 Linus Torvalds 2005-04-16 4054 */
a4af9b48cb480f Al Viro 2008-03-02 4055 static int floppy_open(struct block_device *bdev, fmode_t mode)
^1da177e4c3f41 Linus Torvalds 2005-04-16 4056 {
a4af9b48cb480f Al Viro 2008-03-02 4057 int drive = (long)bdev->bd_disk->private_data;
a4af9b48cb480f Al Viro 2008-03-02 4058 int old_dev, new_dev;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4059 int try;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4060 int res = -EBUSY;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4061 char *tmp;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4062
2a48fc0ab24241 Arnd Bergmann 2010-06-02 4063 mutex_lock(&floppy_mutex);
b1c82b5c55851b Jes Sorensen 2006-03-23 4064 mutex_lock(&open_lock);
8d9d34e25a372b Willy Tarreau 2020-02-24 4065 old_dev = drive_state[drive].fd_device;
a4af9b48cb480f Al Viro 2008-03-02 4066 if (opened_bdev[drive] && opened_bdev[drive] != bdev)
^1da177e4c3f41 Linus Torvalds 2005-04-16 4067 goto out2;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4068
8d9d34e25a372b Willy Tarreau 2020-02-24 4069 if (!drive_state[drive].fd_ref && (drive_params[drive].flags & FD_BROKEN_DCL)) {
8d9d34e25a372b Willy Tarreau 2020-02-24 4070 set_bit(FD_DISK_CHANGED_BIT, &drive_state[drive].flags);
8d9d34e25a372b Willy Tarreau 2020-02-24 4071 set_bit(FD_VERIFY_BIT, &drive_state[drive].flags);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4072 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 4073
8d9d34e25a372b Willy Tarreau 2020-02-24 4074 drive_state[drive].fd_ref++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4075
a4af9b48cb480f Al Viro 2008-03-02 4076 opened_bdev[drive] = bdev;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4077
^1da177e4c3f41 Linus Torvalds 2005-04-16 4078 res = -ENXIO;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4079
^1da177e4c3f41 Linus Torvalds 2005-04-16 4080 if (!floppy_track_buffer) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 4081 /* if opening an ED drive, reserve a big buffer,
^1da177e4c3f41 Linus Torvalds 2005-04-16 4082 * else reserve a small one */
1ce9ae9654c910 Willy Tarreau 2020-02-24 4083 if ((drive_params[drive].cmos == 6) || (drive_params[drive].cmos == 5))
^1da177e4c3f41 Linus Torvalds 2005-04-16 4084 try = 64; /* Only 48 actually useful */
^1da177e4c3f41 Linus Torvalds 2005-04-16 4085 else
^1da177e4c3f41 Linus Torvalds 2005-04-16 4086 try = 32; /* Only 24 actually useful */
^1da177e4c3f41 Linus Torvalds 2005-04-16 4087
^1da177e4c3f41 Linus Torvalds 2005-04-16 4088 tmp = (char *)fd_dma_mem_alloc(1024 * try);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4089 if (!tmp && !floppy_track_buffer) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 4090 try >>= 1; /* buffer only one side */
^1da177e4c3f41 Linus Torvalds 2005-04-16 4091 INFBOUND(try, 16);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4092 tmp = (char *)fd_dma_mem_alloc(1024 * try);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4093 }
a81ee5447157a4 Joe Perches 2010-03-10 4094 if (!tmp && !floppy_track_buffer)
^1da177e4c3f41 Linus Torvalds 2005-04-16 4095 fallback_on_nodma_alloc(&tmp, 2048 * try);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4096 if (!tmp && !floppy_track_buffer) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 4097 DPRINT("Unable to allocate DMA memory\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16 4098 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4099 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 4100 if (floppy_track_buffer) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 4101 if (tmp)
^1da177e4c3f41 Linus Torvalds 2005-04-16 4102 fd_dma_mem_free((unsigned long)tmp, try * 1024);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4103 } else {
^1da177e4c3f41 Linus Torvalds 2005-04-16 4104 buffer_min = buffer_max = -1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4105 floppy_track_buffer = tmp;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4106 max_buffer_sectors = try;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4107 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 4108 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 4109
a4af9b48cb480f Al Viro 2008-03-02 @4110 set_capacity(disks[drive], floppy_sizes[new_dev]);
a4af9b48cb480f Al Viro 2008-03-02 4111 if (old_dev != -1 && old_dev != new_dev) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 4112 if (buffer_drive == drive)
^1da177e4c3f41 Linus Torvalds 2005-04-16 4113 buffer_track = -1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4114 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 4115
f9d322bdb1e241 Willy Tarreau 2020-02-24 4116 if (fdc_state[FDC(drive)].rawcmd == 1)
f9d322bdb1e241 Willy Tarreau 2020-02-24 4117 fdc_state[FDC(drive)].rawcmd = 2;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4118
f2791e7eadf437 Jens Axboe 2016-08-25 4119 if (!(mode & FMODE_NDELAY)) {
f2791e7eadf437 Jens Axboe 2016-08-25 4120 if (mode & (FMODE_READ|FMODE_WRITE)) {
8d9d34e25a372b Willy Tarreau 2020-02-24 4121 drive_state[drive].last_checked = 0;
8d9d34e25a372b Willy Tarreau 2020-02-24 4122 clear_bit(FD_OPEN_SHOULD_FAIL_BIT,
8d9d34e25a372b Willy Tarreau 2020-02-24 4123 &drive_state[drive].flags);
a4af9b48cb480f Al Viro 2008-03-02 4124 check_disk_change(bdev);
8d9d34e25a372b Willy Tarreau 2020-02-24 4125 if (test_bit(FD_DISK_CHANGED_BIT, &drive_state[drive].flags))
^1da177e4c3f41 Linus Torvalds 2005-04-16 4126 goto out;
8d9d34e25a372b Willy Tarreau 2020-02-24 4127 if (test_bit(FD_OPEN_SHOULD_FAIL_BIT, &drive_state[drive].flags))
7b7b68bba5ef23 Jiri Kosina 2014-01-10 4128 goto out;
f2791e7eadf437 Jens Axboe 2016-08-25 4129 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 4130 res = -EROFS;
e029853612ba59 Joe Perches 2010-03-10 4131 if ((mode & FMODE_WRITE) &&
8d9d34e25a372b Willy Tarreau 2020-02-24 4132 !test_bit(FD_DISK_WRITABLE_BIT, &drive_state[drive].flags))
^1da177e4c3f41 Linus Torvalds 2005-04-16 4133 goto out;
f2791e7eadf437 Jens Axboe 2016-08-25 4134 }
b1c82b5c55851b Jes Sorensen 2006-03-23 4135 mutex_unlock(&open_lock);
2a48fc0ab24241 Arnd Bergmann 2010-06-02 4136 mutex_unlock(&floppy_mutex);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4137 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4138 out:
8d9d34e25a372b Willy Tarreau 2020-02-24 4139 drive_state[drive].fd_ref--;
bfa10b8c98bb33 Jiri Kosina 2012-05-18 4140
8d9d34e25a372b Willy Tarreau 2020-02-24 4141 if (!drive_state[drive].fd_ref)
^1da177e4c3f41 Linus Torvalds 2005-04-16 4142 opened_bdev[drive] = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4143 out2:
b1c82b5c55851b Jes Sorensen 2006-03-23 4144 mutex_unlock(&open_lock);
2a48fc0ab24241 Arnd Bergmann 2010-06-02 4145 mutex_unlock(&floppy_mutex);
^1da177e4c3f41 Linus Torvalds 2005-04-16 4146 return res;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4147 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 4148
:::::: The code at line 4110 was first introduced by commit
:::::: a4af9b48cb480f5016947bbd3f396c265c7cb368 [PATCH] switch floppy
:::::: TO: Al Viro <viro@zeniv.linux.org.uk>
:::::: CC: Al Viro <viro@zeniv.linux.org.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37423 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-24 20:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 20:55 [hch-block:gendisk-lookup 17/19] drivers/block/floppy.c:4110:42: warning: variable 'new_dev' is uninitialized when used here kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.