* [PATCH 2/2] iommu/vt-d:Add support for probing ACPI device in RMRR
@ 2020-08-25 6:48 ` FelixCuioc
0 siblings, 0 replies; 2+ messages in thread
From: FelixCuioc @ 2020-08-25 6:48 UTC (permalink / raw)
To: Joerg Roedel, iommu, linux-kernel, David Woodhouse, Lu Baolu,
Dan Carpenter, kbuild
Cc: kbuild-all, CobeChen-oc, RaymondPang-oc
In the probe_acpi_namespace_devices function,when the physical
node of the acpi device is NULL,the unlock function is missing.
Add mutex_unlock(&adev->physical_node_lock).
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: FelixCuioc <FelixCui-oc@zhaoxin.com>
---
drivers/iommu/intel/iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index b31f02f41c96..25e9853cba1b 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4851,6 +4851,7 @@ static int __init probe_acpi_namespace_devices(void)
if (pn_dev == NULL) {
dev->bus->iommu_ops = &intel_iommu_ops;
ret = iommu_probe_device(dev);
+ mutex_unlock(&adev->physical_node_lock);
if (ret) {
pr_err("acpi_device probe fail! ret:%d\n", ret);
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] iommu/vt-d:Add support for probing ACPI device in RMRR
@ 2020-08-25 6:48 ` FelixCuioc
0 siblings, 0 replies; 2+ messages in thread
From: FelixCuioc @ 2020-08-25 6:48 UTC (permalink / raw)
To: Joerg Roedel, iommu, linux-kernel, David Woodhouse, Lu Baolu,
Dan Carpenter, kbuild
Cc: kbuild-all, CobeChen-oc
In the probe_acpi_namespace_devices function,when the physical
node of the acpi device is NULL,the unlock function is missing.
Add mutex_unlock(&adev->physical_node_lock).
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: FelixCuioc <FelixCui-oc@zhaoxin.com>
---
drivers/iommu/intel/iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index b31f02f41c96..25e9853cba1b 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4851,6 +4851,7 @@ static int __init probe_acpi_namespace_devices(void)
if (pn_dev == NULL) {
dev->bus->iommu_ops = &intel_iommu_ops;
ret = iommu_probe_device(dev);
+ mutex_unlock(&adev->physical_node_lock);
if (ret) {
pr_err("acpi_device probe fail! ret:%d\n", ret);
return ret;
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-25 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 6:48 [PATCH 2/2] iommu/vt-d:Add support for probing ACPI device in RMRR FelixCuioc
2020-08-25 6:48 ` FelixCuioc
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.