[PATCH v2 0/5] Follow up to "Add new board: Xen guest for ARM64" series

[PATCH v2 0/5] Follow up to "Add new board: Xen guest for ARM64" series

[Anastasiia Lukianenko]

From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>

Removed unnecessary defines, fixed code style errors and added maintainers to
XEN section.

Regards,
Anastasiia Lukianenko

Changes since v1:
=================

1. Removed CONFIG_BOARD_EARLY_INIT_F define and board_early_init_f function
2. Removed duplicates from MAINTAINERS file
3. Cleaned xenguest_arm64_defconfig
4. Coding style cleanup

Anastasiia Lukianenko (5):
  board: xen: Remove unnecessary CONFIG_BOARD_EARLY_INIT_F define and
    board_early_init_f function
  MAINTAINERS: Add maintainers to XEN section
  board: xen: Remove CONFIG_CMD_RUN define and clean
    xenguest_arm64_defconfig
  board: xen: Remove unnecessary CONFIG_INITRD_TAG and
    CONFIG_CMDLINE_TAG
  xen: Code style conformity

 MAINTAINERS                               | 16 +++++
 board/xen/xenguest_arm64/MAINTAINERS      |  3 +-
 board/xen/xenguest_arm64/xenguest_arm64.c |  5 --
 configs/xenguest_arm64_defconfig          | 75 ++++++++---------------
 drivers/xen/gnttab.c                      |  3 +-
 drivers/xen/pvblock.c                     | 12 ++--
 include/configs/xenguest_arm64.h          |  7 ---
 include/xen/gnttab.h                      |  3 +-
 lib/sscanf.c                              |  3 +-
 9 files changed, 56 insertions(+), 71 deletions(-)

-- 
2.17.1

[PATCH v2 1/5] board: xen: Remove unnecessary CONFIG_BOARD_EARLY_INIT_F define and board_early_init_f function

[Anastasiia Lukianenko]

From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>

Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
---
 board/xen/xenguest_arm64/xenguest_arm64.c | 5 -----
 include/configs/xenguest_arm64.h          | 2 --
 2 files changed, 7 deletions(-)

diff --git a/board/xen/xenguest_arm64/xenguest_arm64.c b/board/xen/xenguest_arm64/xenguest_arm64.c
index cce54369bb..4660f3fff2 100644
--- a/board/xen/xenguest_arm64/xenguest_arm64.c
+++ b/board/xen/xenguest_arm64/xenguest_arm64.c
@@ -184,11 +184,6 @@ int ft_board_setup(void *blob, struct bd_info *bd)
 	return 0;
 }
 
-int board_early_init_f(void)
-{
-	return 0;
-}
-
 int print_cpuinfo(void)
 {
 	printf("Xen virtual CPU\n");
diff --git a/include/configs/xenguest_arm64.h b/include/configs/xenguest_arm64.h
index db3059a82c..e88ab87a1d 100644
--- a/include/configs/xenguest_arm64.h
+++ b/include/configs/xenguest_arm64.h
@@ -9,8 +9,6 @@
 #include <linux/types.h>
 #endif
 
-#define CONFIG_BOARD_EARLY_INIT_F
-
 #define CONFIG_EXTRA_ENV_SETTINGS
 
 #undef CONFIG_NR_DRAM_BANKS
-- 
2.17.1

[PATCH v2 2/5] MAINTAINERS: Add maintainers to XEN section

[Anastasiia Lukianenko]

From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>

Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
---

Changes since v1:
 - removed duplicates from MAINTAINERS file, which mentioned in
   board/xen/xenguest_arm64/MAINTAINERS
 - change maintainers in XEN GUEST FOR ARM64 section

 MAINTAINERS                          | 16 ++++++++++++++++
 board/xen/xenguest_arm64/MAINTAINERS |  3 ++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 17ac45587b..bebe87b4d1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1097,6 +1097,22 @@ T:	git https://gitlab.denx.de/u-boot/custodians/u-boot-x86.git
 F:	arch/x86/
 F:	cmd/x86/
 
+XEN
+M:	Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
+M:	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
+S:	Maintained
+F:	arch/arm/cpu/armv8/xen/
+F:	arch/arm/include/asm/xen.h
+F:	arch/arm/include/asm/xen/
+F:	cmd/pvblock.c
+F:	drivers/serial/serial_xen.c
+F:	drivers/xen/
+F:	include/pvblock.h
+F:	include/xen/
+F:	include/xen.h
+F:	lib/sscanf.c
+F:	test/lib/sscanf.c
+
 XTENSA
 M:	Max Filippov <jcmvbkbc@gmail.com>
 S:	Maintained
diff --git a/board/xen/xenguest_arm64/MAINTAINERS b/board/xen/xenguest_arm64/MAINTAINERS
index 787e9e0d0e..264920e240 100644
--- a/board/xen/xenguest_arm64/MAINTAINERS
+++ b/board/xen/xenguest_arm64/MAINTAINERS
@@ -1,5 +1,6 @@
 XEN GUEST FOR ARM64
-M:	Andrii Anisov <andrii_anisov@epam.com>
+M:	Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
+M:	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
 S:	Maintained
 F:	board/xen/xenguest_arm64/
 F:	doc/board/xen/
-- 
2.17.1

[PATCH v2 3/5] board: xen: Remove CONFIG_CMD_RUN define and clean xenguest_arm64_defconfig

[Anastasiia Lukianenko]

From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>

CONFIG_CMD_RUN is set on by default in Kconfig.
Create xenguest_arm64_defconfig by using savedefconfig to avoid unnecessary
options.

Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
---

Changes since v1:
 - removed wrong config options
 - added commit message

 configs/xenguest_arm64_defconfig | 75 ++++++++++++--------------------
 include/configs/xenguest_arm64.h |  2 -
 2 files changed, 27 insertions(+), 50 deletions(-)

diff --git a/configs/xenguest_arm64_defconfig b/configs/xenguest_arm64_defconfig
index 46473c251d..042ea79729 100644
--- a/configs/xenguest_arm64_defconfig
+++ b/configs/xenguest_arm64_defconfig
@@ -1,60 +1,39 @@
 CONFIG_ARM=y
 CONFIG_POSITION_INDEPENDENT=y
+CONFIG_TARGET_XENGUEST_ARM64=y
 CONFIG_SYS_TEXT_BASE=0x40080000
 CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_IDENT_STRING=" xenguest"
-CONFIG_TARGET_XENGUEST_ARM64=y
 CONFIG_BOOTDELAY=10
-
 CONFIG_SYS_PROMPT="xenguest# "
-
-CONFIG_CMD_NET=n
-CONFIG_CMD_BDI=n
-CONFIG_CMD_BOOTD=n
-CONFIG_CMD_BOOTEFI=n
-CONFIG_CMD_BOOTEFI_HELLO_COMPILE=n
-CONFIG_CMD_ELF=n
+# CONFIG_CMD_BDI is not set
+# CONFIG_CMD_BOOTD is not set
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_GO is not set
+# CONFIG_CMD_IMI is not set
+# CONFIG_CMD_XIMG is not set
+# CONFIG_CMD_EXPORTENV is not set
+# CONFIG_CMD_IMPORTENV is not set
+# CONFIG_CMD_EDITENV is not set
+# CONFIG_CMD_SAVEENV is not set
+# CONFIG_CMD_ENV_EXISTS is not set
+# CONFIG_CMD_CRC32 is not set
+# CONFIG_CMD_LZMADEC is not set
+# CONFIG_CMD_UNZIP is not set
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+CONFIG_CMD_PVBLOCK=y
+# CONFIG_CMD_ECHO is not set
+# CONFIG_CMD_ITEST is not set
+# CONFIG_CMD_SOURCE is not set
+# CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_NET is not set
+# CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_FAT=y
-CONFIG_CMD_GO=n
-CONFIG_CMD_RUN=n
-CONFIG_CMD_IMI=n
-CONFIG_CMD_IMLS=n
-CONFIG_CMD_XIMG=n
-CONFIG_CMD_EXPORTENV=n
-CONFIG_CMD_IMPORTENV=n
-CONFIG_CMD_EDITENV=n
-CONFIG_CMD_ENV_EXISTS=n
-CONFIG_CMD_MEMORY=y
-CONFIG_CMD_CRC32=n
-CONFIG_CMD_DM=n
-CONFIG_CMD_LOADB=n
-CONFIG_CMD_LOADS=n
-CONFIG_CMD_FLASH=n
-CONFIG_CMD_GPT=n
-CONFIG_CMD_FPGA=n
-CONFIG_CMD_ECHO=n
-CONFIG_CMD_ITEST=n
-CONFIG_CMD_SOURCE=n
-CONFIG_CMD_SETEXPR=n
-CONFIG_CMD_MISC=n
-CONFIG_CMD_UNZIP=n
-CONFIG_CMD_LZMADEC=n
-CONFIG_CMD_SAVEENV=n
-CONFIG_CMD_UMS=n
-
-CONFIG_CMD_PVBLOCK=y
-
-#CONFIG_USB=n
-# CONFIG_ISO_PARTITION is not set
-
-#CONFIG_EFI_PARTITION=y
-# CONFIG_EFI_LOADER is not set
-
+CONFIG_OF_BOARD=y
 CONFIG_DM=y
 # CONFIG_MMC is not set
-CONFIG_DM_SERIAL=y
 # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
-
-CONFIG_OF_BOARD=y
-CONFIG_OF_LIBFDT=y
+CONFIG_DM_SERIAL=y
+# CONFIG_EFI_LOADER is not set
diff --git a/include/configs/xenguest_arm64.h b/include/configs/xenguest_arm64.h
index e88ab87a1d..f3092cb2f8 100644
--- a/include/configs/xenguest_arm64.h
+++ b/include/configs/xenguest_arm64.h
@@ -39,8 +39,6 @@
 #define CONFIG_CMDLINE_TAG            1
 #define CONFIG_INITRD_TAG             1
 
-#define CONFIG_CMD_RUN
-
 #undef CONFIG_EXTRA_ENV_SETTINGS
 #define CONFIG_EXTRA_ENV_SETTINGS	\
 	"loadimage=ext4load pvblock 0 0x90000000 /boot/Image;\0" \
-- 
2.17.1

[PATCH v2 4/5] board: xen: Remove unnecessary CONFIG_INITRD_TAG and CONFIG_CMDLINE_TAG

[Anastasiia Lukianenko]

From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>

Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
---
 include/configs/xenguest_arm64.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/configs/xenguest_arm64.h b/include/configs/xenguest_arm64.h
index f3092cb2f8..c44381e966 100644
--- a/include/configs/xenguest_arm64.h
+++ b/include/configs/xenguest_arm64.h
@@ -36,9 +36,6 @@
 
 #define CONFIG_OF_SYSTEM_SETUP
 
-#define CONFIG_CMDLINE_TAG            1
-#define CONFIG_INITRD_TAG             1
-
 #undef CONFIG_EXTRA_ENV_SETTINGS
 #define CONFIG_EXTRA_ENV_SETTINGS	\
 	"loadimage=ext4load pvblock 0 0x90000000 /boot/Image;\0" \
-- 
2.17.1

[PATCH v2 5/5] xen: Code style conformity

[Anastasiia Lukianenko]

From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>

Cleaning up the following:

ERROR: do not use assignment in if condition
#281: FILE: drivers/xen/pvblock.c:260:
+       if ((err = xenbus_switch_state(XBT_NIL, nodename,
CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "err"
#52: FILE: drivers/xen/pvblock.c:298:
+       if (err != NULL) {
ERROR: do not use assignment in if condition
#176: FILE: drivers/xen/gnttab.c:103:
+               if ((flags = nflags) & (GTF_reading | GTF_writing)) {
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#329: FILE: include/xen/gnttab.h:1:
+/*
WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
#330: FILE: include/xen/gnttab.h:2:
+ * SPDX-License-Identifier: GPL-2.0
ERROR: do not use assignment in if condition
#630: FILE: lib/sscanf.c:558:
+                               if ((n = inr) < width) {

Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
---

Changes since v1:
 - cleaned errors like in drivers/xen/pvblock.c:
 CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "err"
 - added commit message

 drivers/xen/gnttab.c  |  3 ++-
 drivers/xen/pvblock.c | 12 ++++++------
 include/xen/gnttab.h  |  3 +--
 lib/sscanf.c          |  3 ++-
 4 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/xen/gnttab.c b/drivers/xen/gnttab.c
index becf7a79fb..9bf1091ab3 100644
--- a/drivers/xen/gnttab.c
+++ b/drivers/xen/gnttab.c
@@ -100,7 +100,8 @@ int gnttab_end_access(grant_ref_t ref)
 
 	nflags = gnttab_table[ref].flags;
 	do {
-		if ((flags = nflags) & (GTF_reading | GTF_writing)) {
+		flags = nflags;
+		if ((flags) & (GTF_reading | GTF_writing)) {
 			printf("WARNING: g.e. still in use! (%x)\n", flags);
 			return 0;
 		}
diff --git a/drivers/xen/pvblock.c b/drivers/xen/pvblock.c
index 76e82fbf41..1b3325bbe2 100644
--- a/drivers/xen/pvblock.c
+++ b/drivers/xen/pvblock.c
@@ -294,8 +294,8 @@ static void shutdown_blkfront(struct blkfront_dev *dev)
 	snprintf(path, sizeof(path), "%s/state", dev->backend);
 	snprintf(nodename, sizeof(nodename), "%s/state", dev->nodename);
 
-	if ((err = xenbus_switch_state(XBT_NIL, nodename,
-				       XenbusStateClosing)) != NULL) {
+	err = xenbus_switch_state(XBT_NIL, nodename, XenbusStateClosing);
+	if (err) {
 		printf("%s: error changing state to %d: %s\n", __func__,
 		       XenbusStateClosing, err);
 		goto close;
@@ -306,8 +306,8 @@ static void shutdown_blkfront(struct blkfront_dev *dev)
 		err = xenbus_wait_for_state_change(path, &state);
 	free(err);
 
-	if ((err = xenbus_switch_state(XBT_NIL, nodename,
-				       XenbusStateClosed)) != NULL) {
+	err = xenbus_switch_state(XBT_NIL, nodename, XenbusStateClosed);
+	if (err) {
 		printf("%s: error changing state to %d: %s\n", __func__,
 		       XenbusStateClosed, err);
 		goto close;
@@ -319,8 +319,8 @@ static void shutdown_blkfront(struct blkfront_dev *dev)
 		free(err);
 	}
 
-	if ((err = xenbus_switch_state(XBT_NIL, nodename,
-				       XenbusStateInitialising)) != NULL) {
+	err = xenbus_switch_state(XBT_NIL, nodename, XenbusStateInitialising);
+	if (err) {
 		printf("%s: error changing state to %d: %s\n", __func__,
 		       XenbusStateInitialising, err);
 		goto close;
diff --git a/include/xen/gnttab.h b/include/xen/gnttab.h
index db1d5361fe..db615004aa 100644
--- a/include/xen/gnttab.h
+++ b/include/xen/gnttab.h
@@ -1,5 +1,4 @@
-/*
- * SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0
  *
  * (C) 2006, Steven Smith <sos22@cam.ac.uk>
  * (C) 2006, Grzegorz Milos <gm281@cam.ac.uk>
diff --git a/lib/sscanf.c b/lib/sscanf.c
index d1e2dc272c..4c35c035fe 100644
--- a/lib/sscanf.c
+++ b/lib/sscanf.c
@@ -555,7 +555,8 @@ literal:
 			if (flags & SUPPRESS) {
 				size_t sum = 0;
 
-				if ((n = inr) < width) {
+				n = inr;
+				if (n < width) {
 					sum += n;
 					width -= n;
 					inp += n;
-- 
2.17.1

[PATCH v2 2/5] MAINTAINERS: Add maintainers to XEN section

[Simon Glass]

On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko <vicooodin@gmail.com> wrote:
>
> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
>
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> ---
>
> Changes since v1:
>  - removed duplicates from MAINTAINERS file, which mentioned in
>    board/xen/xenguest_arm64/MAINTAINERS
>  - change maintainers in XEN GUEST FOR ARM64 section
>
>  MAINTAINERS                          | 16 ++++++++++++++++
>  board/xen/xenguest_arm64/MAINTAINERS |  3 ++-
>  2 files changed, 18 insertions(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH v2 3/5] board: xen: Remove CONFIG_CMD_RUN define and clean xenguest_arm64_defconfig

[Simon Glass]

On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko <vicooodin@gmail.com> wrote:
>
> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
>
> CONFIG_CMD_RUN is set on by default in Kconfig.
> Create xenguest_arm64_defconfig by using savedefconfig to avoid unnecessary
> options.
>
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> ---
>
> Changes since v1:
>  - removed wrong config options
>  - added commit message
>
>  configs/xenguest_arm64_defconfig | 75 ++++++++++++--------------------
>  include/configs/xenguest_arm64.h |  2 -
>  2 files changed, 27 insertions(+), 50 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH v2 4/5] board: xen: Remove unnecessary CONFIG_INITRD_TAG and CONFIG_CMDLINE_TAG

[Simon Glass]

On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko <vicooodin@gmail.com> wrote:
>
> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
>
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> ---
>  include/configs/xenguest_arm64.h | 3 ---
>  1 file changed, 3 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH v2 5/5] xen: Code style conformity

[Simon Glass]

On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko <vicooodin@gmail.com> wrote:
>
> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
>
> Cleaning up the following:
>
> ERROR: do not use assignment in if condition
> #281: FILE: drivers/xen/pvblock.c:260:
> +       if ((err = xenbus_switch_state(XBT_NIL, nodename,
> CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "err"
> #52: FILE: drivers/xen/pvblock.c:298:
> +       if (err != NULL) {
> ERROR: do not use assignment in if condition
> #176: FILE: drivers/xen/gnttab.c:103:
> +               if ((flags = nflags) & (GTF_reading | GTF_writing)) {
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> #329: FILE: include/xen/gnttab.h:1:
> +/*
> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
> #330: FILE: include/xen/gnttab.h:2:
> + * SPDX-License-Identifier: GPL-2.0
> ERROR: do not use assignment in if condition
> #630: FILE: lib/sscanf.c:558:
> +                               if ((n = inr) < width) {
>
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> ---
>
> Changes since v1:
>  - cleaned errors like in drivers/xen/pvblock.c:
>  CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "err"
>  - added commit message
>
>  drivers/xen/gnttab.c  |  3 ++-
>  drivers/xen/pvblock.c | 12 ++++++------
>  include/xen/gnttab.h  |  3 +--
>  lib/sscanf.c          |  3 ++-
>  4 files changed, 11 insertions(+), 10 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH v2 1/5] board: xen: Remove unnecessary CONFIG_BOARD_EARLY_INIT_F define and board_early_init_f function

[Tom Rini]

On Fri, Aug 21, 2020 at 12:10:00PM +0300, Anastasiia Lukianenko wrote:

> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> 
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200825/076cc400/attachment.sig>

[PATCH v2 2/5] MAINTAINERS: Add maintainers to XEN section

[Tom Rini]

On Fri, Aug 21, 2020 at 12:10:01PM +0300, Anastasiia Lukianenko wrote:

> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> 
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200825/f26e5336/attachment.sig>

[PATCH v2 3/5] board: xen: Remove CONFIG_CMD_RUN define and clean xenguest_arm64_defconfig

[Tom Rini]

On Fri, Aug 21, 2020 at 12:10:02PM +0300, Anastasiia Lukianenko wrote:

> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> 
> CONFIG_CMD_RUN is set on by default in Kconfig.
> Create xenguest_arm64_defconfig by using savedefconfig to avoid unnecessary
> options.
> 
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200825/d407bb34/attachment.sig>

[PATCH v2 4/5] board: xen: Remove unnecessary CONFIG_INITRD_TAG and CONFIG_CMDLINE_TAG

[Tom Rini]

On Fri, Aug 21, 2020 at 12:10:03PM +0300, Anastasiia Lukianenko wrote:

> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> 
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200825/e4b1b081/attachment.sig>

[PATCH v2 5/5] xen: Code style conformity

[Tom Rini]

On Fri, Aug 21, 2020 at 12:10:04PM +0300, Anastasiia Lukianenko wrote:

> From: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> 
> Cleaning up the following:
> 
> ERROR: do not use assignment in if condition
> #281: FILE: drivers/xen/pvblock.c:260:
> +       if ((err = xenbus_switch_state(XBT_NIL, nodename,
> CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "err"
> #52: FILE: drivers/xen/pvblock.c:298:
> +       if (err != NULL) {
> ERROR: do not use assignment in if condition
> #176: FILE: drivers/xen/gnttab.c:103:
> +               if ((flags = nflags) & (GTF_reading | GTF_writing)) {
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> #329: FILE: include/xen/gnttab.h:1:
> +/*
> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
> #330: FILE: include/xen/gnttab.h:2:
> + * SPDX-License-Identifier: GPL-2.0
> ERROR: do not use assignment in if condition
> #630: FILE: lib/sscanf.c:558:
> +                               if ((n = inr) < width) {
> 
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200825/7d21a1f3/attachment.sig>