* [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
@ 2020-08-25 15:45 Diego
2020-08-25 15:57 ` [oe] " Martin Jansa
0 siblings, 1 reply; 10+ messages in thread
From: Diego @ 2020-08-25 15:45 UTC (permalink / raw)
To: openembedded-devel; +Cc: Diego Rondini
Bitbucket is no longer the official home of eigen, which has moved to
gitlab. Update SRC_URI to download releases from gitlab, fixing:
WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2,
attempting MIRRORS if available
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
---
meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
index f638848d1..9c3d962f4 100644
--- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
+++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
@@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/"
LICENSE = "MPL-2.0"
LIC_FILES_CHKSUM = "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
-SRC_URI = "https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2"
-SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
-SRC_URI[sha256sum] = "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
+SRC_URI = "https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2"
+SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
+SRC_URI[sha256sum] = "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
-S = "${WORKDIR}/eigen-eigen-323c052e1731"
+S = "${WORKDIR}/eigen-${PV}"
inherit cmake
--
2.26.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-08-25 15:45 [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab Diego
@ 2020-08-25 15:57 ` Martin Jansa
2020-08-25 16:36 ` Diego
0 siblings, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2020-08-25 15:57 UTC (permalink / raw)
To: Diego; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]
Doesn't this trigger src-uri-bad QA warning? It would be better to use git
fetcher.
On Tue, Aug 25, 2020 at 5:45 PM Diego <diego.rondini@kynetics.com> wrote:
> Bitbucket is no longer the official home of eigen, which has moved to
> gitlab. Update SRC_URI to download releases from gitlab, fixing:
> WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
>
> https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2
> ,
> attempting MIRRORS if available
>
> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
> ---
> meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> index f638848d1..9c3d962f4 100644
> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> @@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/"
> LICENSE = "MPL-2.0"
> LIC_FILES_CHKSUM =
> "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
>
> -SRC_URI = "
> https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2
> "
> -SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
> -SRC_URI[sha256sum] =
> "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
> +SRC_URI = "
> https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2"
> +SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
> +SRC_URI[sha256sum] =
> "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
>
> -S = "${WORKDIR}/eigen-eigen-323c052e1731"
> +S = "${WORKDIR}/eigen-${PV}"
>
> inherit cmake
>
> --
> 2.26.2
>
>
>
[-- Attachment #2: Type: text/html, Size: 3137 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-08-25 15:57 ` [oe] " Martin Jansa
@ 2020-08-25 16:36 ` Diego
2020-08-25 17:58 ` Martin Jansa
0 siblings, 1 reply; 10+ messages in thread
From: Diego @ 2020-08-25 16:36 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel
Hi Martin,
On Tue, Aug 25, 2020 at 5:57 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Doesn't this trigger src-uri-bad QA warning? It would be better to use git fetcher.
No warning because this is from git*lab*.
Also, this the URL of an official release tarball taken from:
https://gitlab.com/libeigen/eigen/-/releases
See also first comment here:
https://patchwork.openembedded.org/patch/161360/
Regards,
Diego Rondini
>
> On Tue, Aug 25, 2020 at 5:45 PM Diego <diego.rondini@kynetics.com> wrote:
>>
>> Bitbucket is no longer the official home of eigen, which has moved to
>> gitlab. Update SRC_URI to download releases from gitlab, fixing:
>> WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
>> https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2,
>> attempting MIRRORS if available
>>
>> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
>> ---
>> meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> index f638848d1..9c3d962f4 100644
>> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> @@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/"
>> LICENSE = "MPL-2.0"
>> LIC_FILES_CHKSUM = "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
>>
>> -SRC_URI = "https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2"
>> -SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
>> -SRC_URI[sha256sum] = "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
>> +SRC_URI = "https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2"
>> +SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
>> +SRC_URI[sha256sum] = "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
>>
>> -S = "${WORKDIR}/eigen-eigen-323c052e1731"
>> +S = "${WORKDIR}/eigen-${PV}"
>>
>> inherit cmake
>>
>> --
>> 2.26.2
>>
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-08-25 16:36 ` Diego
@ 2020-08-25 17:58 ` Martin Jansa
2020-08-25 18:39 ` Khem Raj
0 siblings, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2020-08-25 17:58 UTC (permalink / raw)
To: Diego Rondini; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2784 bytes --]
OK, I've overlooked that it's from gitlab, but are you sure that gitlab
archives aren't re-generated from time to time like the github archives are?
Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are
developer uploaded archives? It looks like gitlab creates them
automatically:
https://docs.gitlab.com/ee/user/project/releases/
like github does with tag archives.
On Tue, Aug 25, 2020 at 6:36 PM Diego Rondini <diego.rondini@kynetics.com>
wrote:
> Hi Martin,
>
> On Tue, Aug 25, 2020 at 5:57 PM Martin Jansa <martin.jansa@gmail.com>
> wrote:
> >
> > Doesn't this trigger src-uri-bad QA warning? It would be better to use
> git fetcher.
>
> No warning because this is from git*lab*.
>
> Also, this the URL of an official release tarball taken from:
> https://gitlab.com/libeigen/eigen/-/releases
>
> See also first comment here:
> https://patchwork.openembedded.org/patch/161360/
>
> Regards,
> Diego Rondini
>
>
> >
> > On Tue, Aug 25, 2020 at 5:45 PM Diego <diego.rondini@kynetics.com>
> wrote:
> >>
> >> Bitbucket is no longer the official home of eigen, which has moved to
> >> gitlab. Update SRC_URI to download releases from gitlab, fixing:
> >> WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
> >>
> https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2
> ,
> >> attempting MIRRORS if available
> >>
> >> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
> >> ---
> >> meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> >> index f638848d1..9c3d962f4 100644
> >> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> >> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> >> @@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/"
> >> LICENSE = "MPL-2.0"
> >> LIC_FILES_CHKSUM =
> "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
> >>
> >> -SRC_URI = "
> https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2
> "
> >> -SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
> >> -SRC_URI[sha256sum] =
> "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
> >> +SRC_URI = "
> https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2"
> >> +SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
> >> +SRC_URI[sha256sum] =
> "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
> >>
> >> -S = "${WORKDIR}/eigen-eigen-323c052e1731"
> >> +S = "${WORKDIR}/eigen-${PV}"
> >>
> >> inherit cmake
> >>
> >> --
> >> 2.26.2
> >>
> >>
>
[-- Attachment #2: Type: text/html, Size: 4897 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-08-25 17:58 ` Martin Jansa
@ 2020-08-25 18:39 ` Khem Raj
2020-08-26 7:16 ` Diego
0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2020-08-25 18:39 UTC (permalink / raw)
To: Martin Jansa; +Cc: Diego Rondini, openembedded-devel
On Tue, Aug 25, 2020 at 10:59 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
>
> OK, I've overlooked that it's from gitlab, but are you sure that gitlab archives aren't re-generated from time to time like the github archives are?
>
> Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are developer uploaded archives? It looks like gitlab creates them automatically:
> https://docs.gitlab.com/ee/user/project/releases/
> like github does with tag archives.
>
while it fixes the issue it is trying to fix, it would be better to
fix the non-deterministic archive issue as well while here, I dont
know if gitlab's archiving is reproducible perhaps a question for
gitlab, but it would be ok to switch to using git fetcher to avoid
that suspicion. What do you think?
> On Tue, Aug 25, 2020 at 6:36 PM Diego Rondini <diego.rondini@kynetics.com> wrote:
>>
>> Hi Martin,
>>
>> On Tue, Aug 25, 2020 at 5:57 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>> >
>> > Doesn't this trigger src-uri-bad QA warning? It would be better to use git fetcher.
>>
>> No warning because this is from git*lab*.
>>
>> Also, this the URL of an official release tarball taken from:
>> https://gitlab.com/libeigen/eigen/-/releases
>>
>> See also first comment here:
>> https://patchwork.openembedded.org/patch/161360/
>>
>> Regards,
>> Diego Rondini
>>
>>
>> >
>> > On Tue, Aug 25, 2020 at 5:45 PM Diego <diego.rondini@kynetics.com> wrote:
>> >>
>> >> Bitbucket is no longer the official home of eigen, which has moved to
>> >> gitlab. Update SRC_URI to download releases from gitlab, fixing:
>> >> WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
>> >> https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2,
>> >> attempting MIRRORS if available
>> >>
>> >> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
>> >> ---
>> >> meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
>> >> 1 file changed, 4 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> >> index f638848d1..9c3d962f4 100644
>> >> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> >> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> >> @@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/"
>> >> LICENSE = "MPL-2.0"
>> >> LIC_FILES_CHKSUM = "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
>> >>
>> >> -SRC_URI = "https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2"
>> >> -SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
>> >> -SRC_URI[sha256sum] = "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
>> >> +SRC_URI = "https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2"
>> >> +SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
>> >> +SRC_URI[sha256sum] = "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
>> >>
>> >> -S = "${WORKDIR}/eigen-eigen-323c052e1731"
>> >> +S = "${WORKDIR}/eigen-${PV}"
>> >>
>> >> inherit cmake
>> >>
>> >> --
>> >> 2.26.2
>> >>
>> >>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-08-25 18:39 ` Khem Raj
@ 2020-08-26 7:16 ` Diego
2020-08-26 22:25 ` Khem Raj
2020-09-02 12:25 ` Diego
0 siblings, 2 replies; 10+ messages in thread
From: Diego @ 2020-08-26 7:16 UTC (permalink / raw)
To: Khem Raj; +Cc: Martin Jansa, openembedded-devel
Hi Khem,
On Tue, Aug 25, 2020 at 8:40 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Tue, Aug 25, 2020 at 10:59 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> >
> > OK, I've overlooked that it's from gitlab, but are you sure that gitlab archives aren't re-generated from time to time like the github archives are?
> >
> > Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are developer uploaded archives? It looks like gitlab creates them automatically:
> > https://docs.gitlab.com/ee/user/project/releases/
> > like github does with tag archives.
> >
>
> while it fixes the issue it is trying to fix, it would be better to
> fix the non-deterministic archive issue as well while here, I dont
> know if gitlab's archiving is reproducible perhaps a question for
> gitlab, but it would be ok to switch to using git fetcher to avoid
> that suspicion. What do you think?
I've posted the question, so we get an answer for all the other gitlab
projects that are out there:
https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888
Let's see what the answer is.
Regards,
Diego Rondini
>
> > On Tue, Aug 25, 2020 at 6:36 PM Diego Rondini <diego.rondini@kynetics.com> wrote:
> >>
> >> Hi Martin,
> >>
> >> On Tue, Aug 25, 2020 at 5:57 PM Martin Jansa <martin.jansa@gmail.com> wrote:
> >> >
> >> > Doesn't this trigger src-uri-bad QA warning? It would be better to use git fetcher.
> >>
> >> No warning because this is from git*lab*.
> >>
> >> Also, this the URL of an official release tarball taken from:
> >> https://gitlab.com/libeigen/eigen/-/releases
> >>
> >> See also first comment here:
> >> https://patchwork.openembedded.org/patch/161360/
> >>
> >> Regards,
> >> Diego Rondini
> >>
> >>
> >> >
> >> > On Tue, Aug 25, 2020 at 5:45 PM Diego <diego.rondini@kynetics.com> wrote:
> >> >>
> >> >> Bitbucket is no longer the official home of eigen, which has moved to
> >> >> gitlab. Update SRC_URI to download releases from gitlab, fixing:
> >> >> WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
> >> >> https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2,
> >> >> attempting MIRRORS if available
> >> >>
> >> >> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
> >> >> ---
> >> >> meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
> >> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >> >>
> >> >> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> >> >> index f638848d1..9c3d962f4 100644
> >> >> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> >> >> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> >> >> @@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/"
> >> >> LICENSE = "MPL-2.0"
> >> >> LIC_FILES_CHKSUM = "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
> >> >>
> >> >> -SRC_URI = "https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2"
> >> >> -SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
> >> >> -SRC_URI[sha256sum] = "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
> >> >> +SRC_URI = "https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2"
> >> >> +SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
> >> >> +SRC_URI[sha256sum] = "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
> >> >>
> >> >> -S = "${WORKDIR}/eigen-eigen-323c052e1731"
> >> >> +S = "${WORKDIR}/eigen-${PV}"
> >> >>
> >> >> inherit cmake
> >> >>
> >> >> --
> >> >> 2.26.2
> >> >>
> >> >>
> >
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-08-26 7:16 ` Diego
@ 2020-08-26 22:25 ` Khem Raj
2020-09-02 12:25 ` Diego
1 sibling, 0 replies; 10+ messages in thread
From: Khem Raj @ 2020-08-26 22:25 UTC (permalink / raw)
To: Diego Rondini; +Cc: Martin Jansa, openembedded-devel
Cool, thanks!
On Wed, Aug 26, 2020 at 12:16 AM Diego Rondini
<diego.rondini@kynetics.com> wrote:
>
> Hi Khem,
>
> On Tue, Aug 25, 2020 at 8:40 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Tue, Aug 25, 2020 at 10:59 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > >
> > > OK, I've overlooked that it's from gitlab, but are you sure that gitlab archives aren't re-generated from time to time like the github archives are?
> > >
> > > Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are developer uploaded archives? It looks like gitlab creates them automatically:
> > > https://docs.gitlab.com/ee/user/project/releases/
> > > like github does with tag archives.
> > >
> >
> > while it fixes the issue it is trying to fix, it would be better to
> > fix the non-deterministic archive issue as well while here, I dont
> > know if gitlab's archiving is reproducible perhaps a question for
> > gitlab, but it would be ok to switch to using git fetcher to avoid
> > that suspicion. What do you think?
>
> I've posted the question, so we get an answer for all the other gitlab
> projects that are out there:
> https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888
>
> Let's see what the answer is.
>
> Regards,
> Diego Rondini
>
>
> >
> > > On Tue, Aug 25, 2020 at 6:36 PM Diego Rondini <diego.rondini@kynetics.com> wrote:
> > >>
> > >> Hi Martin,
> > >>
> > >> On Tue, Aug 25, 2020 at 5:57 PM Martin Jansa <martin.jansa@gmail.com> wrote:
> > >> >
> > >> > Doesn't this trigger src-uri-bad QA warning? It would be better to use git fetcher.
> > >>
> > >> No warning because this is from git*lab*.
> > >>
> > >> Also, this the URL of an official release tarball taken from:
> > >> https://gitlab.com/libeigen/eigen/-/releases
> > >>
> > >> See also first comment here:
> > >> https://patchwork.openembedded.org/patch/161360/
> > >>
> > >> Regards,
> > >> Diego Rondini
> > >>
> > >>
> > >> >
> > >> > On Tue, Aug 25, 2020 at 5:45 PM Diego <diego.rondini@kynetics.com> wrote:
> > >> >>
> > >> >> Bitbucket is no longer the official home of eigen, which has moved to
> > >> >> gitlab. Update SRC_URI to download releases from gitlab, fixing:
> > >> >> WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
> > >> >> https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2,
> > >> >> attempting MIRRORS if available
> > >> >>
> > >> >> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
> > >> >> ---
> > >> >> meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
> > >> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> > >> >>
> > >> >> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> > >> >> index f638848d1..9c3d962f4 100644
> > >> >> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> > >> >> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
> > >> >> @@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/"
> > >> >> LICENSE = "MPL-2.0"
> > >> >> LIC_FILES_CHKSUM = "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
> > >> >>
> > >> >> -SRC_URI = "https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2"
> > >> >> -SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
> > >> >> -SRC_URI[sha256sum] = "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
> > >> >> +SRC_URI = "https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2"
> > >> >> +SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
> > >> >> +SRC_URI[sha256sum] = "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
> > >> >>
> > >> >> -S = "${WORKDIR}/eigen-eigen-323c052e1731"
> > >> >> +S = "${WORKDIR}/eigen-${PV}"
> > >> >>
> > >> >> inherit cmake
> > >> >>
> > >> >> --
> > >> >> 2.26.2
> > >> >>
> > >> >>
> > >
> > >
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-08-26 7:16 ` Diego
2020-08-26 22:25 ` Khem Raj
@ 2020-09-02 12:25 ` Diego
2020-09-02 12:29 ` Martin Jansa
1 sibling, 1 reply; 10+ messages in thread
From: Diego @ 2020-09-02 12:25 UTC (permalink / raw)
To: Khem Raj; +Cc: Martin Jansa, openembedded-devel
Hi,
On Wed, Aug 26, 2020 at 9:16 AM Diego Rondini
<diego.rondini@kynetics.com> wrote:
>
> Hi Khem,
>
> On Tue, Aug 25, 2020 at 8:40 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Tue, Aug 25, 2020 at 10:59 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > >
> > > OK, I've overlooked that it's from gitlab, but are you sure that gitlab archives aren't re-generated from time to time like the github archives are?
> > >
> > > Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are developer uploaded archives? It looks like gitlab creates them automatically:
> > > https://docs.gitlab.com/ee/user/project/releases/
> > > like github does with tag archives.
> > >
> >
> > while it fixes the issue it is trying to fix, it would be better to
> > fix the non-deterministic archive issue as well while here, I dont
> > know if gitlab's archiving is reproducible perhaps a question for
> > gitlab, but it would be ok to switch to using git fetcher to avoid
> > that suspicion. What do you think?
>
> I've posted the question, so we get an answer for all the other gitlab
> projects that are out there:
> https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888
>
> Let's see what the answer is.
So we have an initial answer:
https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888/3?u=diegorondini
The summary is: tarballs can be regenerated, but they are regenerated
identical by git archive according to the manual.
The use of git archive in the source code is not guaranteed in the
future as at the moment there is no immutability test in the gitaly
service.
Martin, Khem, what do you suggest to do?
Regards,
Diego Rondini
Sr. Embedded Engineer
Kynetics
www.kynetics.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-09-02 12:25 ` Diego
@ 2020-09-02 12:29 ` Martin Jansa
2020-09-02 15:19 ` Khem Raj
0 siblings, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2020-09-02 12:29 UTC (permalink / raw)
To: Diego Rondini; +Cc: Khem Raj, openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2080 bytes --]
On Wed, Sep 02, 2020 at 02:25:10PM +0200, Diego Rondini wrote:
> Hi,
>
> On Wed, Aug 26, 2020 at 9:16 AM Diego Rondini
> <diego.rondini@kynetics.com> wrote:
> >
> > Hi Khem,
> >
> > On Tue, Aug 25, 2020 at 8:40 PM Khem Raj <raj.khem@gmail.com> wrote:
> > >
> > > On Tue, Aug 25, 2020 at 10:59 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > > >
> > > > OK, I've overlooked that it's from gitlab, but are you sure that gitlab archives aren't re-generated from time to time like the github archives are?
> > > >
> > > > Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are developer uploaded archives? It looks like gitlab creates them automatically:
> > > > https://docs.gitlab.com/ee/user/project/releases/
> > > > like github does with tag archives.
> > > >
> > >
> > > while it fixes the issue it is trying to fix, it would be better to
> > > fix the non-deterministic archive issue as well while here, I dont
> > > know if gitlab's archiving is reproducible perhaps a question for
> > > gitlab, but it would be ok to switch to using git fetcher to avoid
> > > that suspicion. What do you think?
> >
> > I've posted the question, so we get an answer for all the other gitlab
> > projects that are out there:
> > https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888
> >
> > Let's see what the answer is.
>
> So we have an initial answer:
> https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888/3?u=diegorondini
>
> The summary is: tarballs can be regenerated, but they are regenerated
> identical by git archive according to the manual.
> The use of git archive in the source code is not guaranteed in the
> future as at the moment there is no immutability test in the gitaly
> service.
>
> Martin, Khem, what do you suggest to do?
I would you git fetcher to be safe, like we already do for github
archives.
Extending the QA check to cover gitlab would be for bonus points :).
Thanks
>
> Regards,
> Diego Rondini
> Sr. Embedded Engineer
>
> Kynetics
> www.kynetics.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [oe] [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab
2020-09-02 12:29 ` Martin Jansa
@ 2020-09-02 15:19 ` Khem Raj
0 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2020-09-02 15:19 UTC (permalink / raw)
To: Martin Jansa; +Cc: Diego Rondini, openembedded-devel
On Wed, Sep 2, 2020 at 5:29 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> On Wed, Sep 02, 2020 at 02:25:10PM +0200, Diego Rondini wrote:
> > Hi,
> >
> > On Wed, Aug 26, 2020 at 9:16 AM Diego Rondini
> > <diego.rondini@kynetics.com> wrote:
> > >
> > > Hi Khem,
> > >
> > > On Tue, Aug 25, 2020 at 8:40 PM Khem Raj <raj.khem@gmail.com> wrote:
> > > >
> > > > On Tue, Aug 25, 2020 at 10:59 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > > > >
> > > > > OK, I've overlooked that it's from gitlab, but are you sure that gitlab archives aren't re-generated from time to time like the github archives are?
> > > > >
> > > > > Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are developer uploaded archives? It looks like gitlab creates them automatically:
> > > > > https://docs.gitlab.com/ee/user/project/releases/
> > > > > like github does with tag archives.
> > > > >
> > > >
> > > > while it fixes the issue it is trying to fix, it would be better to
> > > > fix the non-deterministic archive issue as well while here, I dont
> > > > know if gitlab's archiving is reproducible perhaps a question for
> > > > gitlab, but it would be ok to switch to using git fetcher to avoid
> > > > that suspicion. What do you think?
> > >
> > > I've posted the question, so we get an answer for all the other gitlab
> > > projects that are out there:
> > > https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888
> > >
> > > Let's see what the answer is.
> >
> > So we have an initial answer:
> > https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888/3?u=diegorondini
> >
> > The summary is: tarballs can be regenerated, but they are regenerated
> > identical by git archive according to the manual.
> > The use of git archive in the source code is not guaranteed in the
> > future as at the moment there is no immutability test in the gitaly
> > service.
> >
> > Martin, Khem, what do you suggest to do?
>
> I would you git fetcher to be safe, like we already do for github
> archives.
>
> Extending the QA check to cover gitlab would be for bonus points :).
>
I would agree.
> Thanks
> >
> > Regards,
> > Diego Rondini
> > Sr. Embedded Engineer
> >
> > Kynetics
> > www.kynetics.com
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-09-02 15:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 15:45 [meta-oe][PATCH] libeigen: update SRC_URI to download from gitlab Diego
2020-08-25 15:57 ` [oe] " Martin Jansa
2020-08-25 16:36 ` Diego
2020-08-25 17:58 ` Martin Jansa
2020-08-25 18:39 ` Khem Raj
2020-08-26 7:16 ` Diego
2020-08-26 22:25 ` Khem Raj
2020-09-02 12:25 ` Diego
2020-09-02 12:29 ` Martin Jansa
2020-09-02 15:19 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.