From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: edgar.iglesias@gmail.com
Subject: [PATCH 00/77] target/microblaze improvements
Date: Tue, 25 Aug 2020 13:58:33 -0700 [thread overview]
Message-ID: <20200825205950.730499-1-richard.henderson@linaro.org> (raw)
Well, this is larger than I expected.
I started off thinking conversion to decodetree would be quick,
after I reviewed the mttcg patches last week. Then I realized
that this could also use conversion to the generic translation loop.
Then I realized that there were a number of bugs, and some
inefficiencies, that could be fixed by using tcg exception unwind
properly.
Hopefully most of these are small and easy to understand.
I begin by adding enough stuff to test/tcg to make use of a
self-built musl cross-environment. I'll note that linuxtest
does not pass before or after this patch set -- I think that
linux-user/microblaze/signal.c needs work -- but that the
other tests do work.
I also have an old copy of a microblaze system test image,
which I think used to be hosted on our wiki. After basic kernel
boot, it contains a "selftest" script which runs a bunch of
user-land isa tests. That still works fine too.
HOWEVER: That's not nearly complete. There are cpu config options
that aren't default and I don't know how to change or test.
In addition, the manual is really not clear on what's supposed to
happen under various edge conditions, especially with MSR[EE] unset.
E.g. unaligned access: Does the insn get nop-ed out? Do the low
bits of the address get ignored? Right now (before and after) the
access simply happens unaligned, which doesn't seem correct.
I assume the reason for having this configure option is to reduce
the size of the FPGA so that the unaligned access handling hw
simply isn't present.
Lemme know what you think.
r~
Richard Henderson (77):
tests/tcg: Add microblaze to arches filter
tests/tcg: Do not require FE_TOWARDZERO
tests/tcg: Do not require FE_* exception bits
target/microblaze: Tidy gdbstub
target/microblaze: Split out PC from env->sregs
target/microblaze: Split out MSR from env->sregs
target/microblaze: Split out EAR from env->sregs
target/microblaze: Split out ESR from env->sregs
target/microblaze: Split out FSR from env->sregs
target/microblaze: Split out BTR from env->sregs
target/microblaze: Split out EDR from env->sregs
target/microblaze: Split the cpu_SR array
target/microblaze: Fix width of PC and BTARGET
target/microblaze: Fix width of MSR
target/microblaze: Fix width of ESR
target/microblaze: Fix width of FSR
target/microblaze: Fix width of BTR
target/microblaze: Fix width of EDR
target/microblaze: Remove cpu_ear
target/microblaze: Tidy raising of exceptions
target/microblaze: Mark raise_exception as noreturn
target/microblaze: Remove helper_debug and env->debug
target/microblaze: Rename env_* tcg variables to cpu_*
target/microblaze: Tidy mb_tcg_init
target/microblaze: Split out MSR[C] to its own variable
target/microblaze: Use DISAS_NORETURN
target/microblaze: Check singlestep_enabled in gen_goto_tb
target/microblaze: Convert to DisasContextBase
target/microblaze: Convert to translator_loop
target/microblaze: Remove SIM_COMPAT
target/microblaze: Remove DISAS_GNU
target/microblaze: Remove empty D macros
target/microblaze: Remove LOG_DIS
target/microblaze: Ensure imm constant is always available
target/microblaze: Add decodetree infrastructure
target/microblaze: Convert dec_add to decodetree
target/microblaze: Convert dec_sub to decodetree
target/microblaze: Implement cmp and cmpu inline
target/microblaze: Convert dec_pattern to decodetree
target/microblaze: Convert dec_and, dec_or, dec_xor to decodetree
target/microblaze: Convert dec_mul to decodetree
target/microblaze: Convert dec_div to decodetree
target/microblaze: Unwind properly when raising divide-by-zero
target/microblaze: Convert dec_bit to decodetree
target/microblaze: Convert dec_barrel to decodetree
target/microblaze: Convert dec_imm to decodetree
target/microblaze: Convert dec_fpu to decodetree
target/microblaze: Fix cpu unwind for fpu exceptions
target/microblaze: Mark fpu helpers TCG_CALL_NO_WG
target/microblaze: Replace MSR_EE_FLAG with MSR_EE
target/microblaze: Cache mem_index in DisasContext
target/microblaze: Fix cpu unwind for stackprot
target/microblaze: Convert dec_load and dec_store to decodetree
target/microblaze: Assert no overlap in flags making up tb_flags
target/microblaze: Move bimm to BIMM_FLAG
target/microblaze: Store "current" iflags in insn_start
tcg: Add tcg_get_insn_start_param
target/microblaze: Use cc->do_unaligned_access
target/microblaze: Replace clear_imm with tb_flags_to_set
target/microblaze: Replace delayed_branch with tb_flags_to_set
target/microblaze: Tidy mb_cpu_dump_state
target/microblaze: Try to keep imm and delay slot together
target/microblaze: Convert brk and brki to decodetree
target/microblaze: Convert mbar to decodetree
target/microblaze: Reorganize branching
target/microblaze: Use tcg_gen_lookup_and_goto_ptr
target/microblaze: Convert dec_br to decodetree
target/microblaze: Convert dec_bcc to decodetree
target/microblaze: Convert dec_rts to decodetree
target/microblaze: Tidy do_rti, do_rtb, do_rte
target/microblaze: Convert msrclr, msrset to decodetree
target/microblaze: Convert dec_msr to decodetree
target/microblaze: Convert dec_stream to decodetree
target/microblaze: Remove last of old decoder
target/microblaze: Remove cpu_R[0]
target/microblaze: Add flags markup to some helpers
target/microblaze: Reduce linux-user address space to 32-bit
include/tcg/tcg.h | 15 +
target/microblaze/cpu-param.h | 15 +
target/microblaze/cpu.h | 67 +-
target/microblaze/helper.h | 49 +-
tests/tcg/multiarch/float_helpers.h | 17 +
target/microblaze/insns.decode | 253 +++
linux-user/elfload.c | 9 +-
linux-user/microblaze/cpu_loop.c | 26 +-
linux-user/microblaze/signal.c | 8 +-
target/microblaze/cpu.c | 9 +-
target/microblaze/gdbstub.c | 193 +-
target/microblaze/helper.c | 164 +-
target/microblaze/mmu.c | 4 +-
target/microblaze/op_helper.c | 175 +-
target/microblaze/translate.c | 3250 ++++++++++++++-------------
tests/tcg/multiarch/float_convs.c | 2 +
tests/tcg/multiarch/float_madds.c | 2 +
target/microblaze/meson.build | 3 +
tests/tcg/configure.sh | 2 +-
19 files changed, 2309 insertions(+), 1954 deletions(-)
create mode 100644 target/microblaze/insns.decode
--
2.25.1
next reply other threads:[~2020-08-25 21:01 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 20:58 Richard Henderson [this message]
2020-08-25 20:58 ` [PATCH 01/77] tests/tcg: Add microblaze to arches filter Richard Henderson
2020-08-26 16:20 ` Edgar E. Iglesias
2020-08-25 20:58 ` [PATCH 02/77] tests/tcg: Do not require FE_TOWARDZERO Richard Henderson
2020-08-26 16:20 ` Edgar E. Iglesias
2020-08-25 20:58 ` [PATCH 03/77] tests/tcg: Do not require FE_* exception bits Richard Henderson
2020-08-26 16:21 ` Edgar E. Iglesias
2020-08-25 20:58 ` [PATCH 04/77] target/microblaze: Tidy gdbstub Richard Henderson
2020-08-25 20:58 ` [PATCH 05/77] target/microblaze: Split out PC from env->sregs Richard Henderson
2020-08-25 20:58 ` [PATCH 06/77] target/microblaze: Split out MSR " Richard Henderson
2020-08-25 20:58 ` [PATCH 07/77] target/microblaze: Split out EAR " Richard Henderson
2020-08-25 20:58 ` [PATCH 08/77] target/microblaze: Split out ESR " Richard Henderson
2020-08-25 20:58 ` [PATCH 09/77] target/microblaze: Split out FSR " Richard Henderson
2020-08-25 20:58 ` [PATCH 10/77] target/microblaze: Split out BTR " Richard Henderson
2020-08-25 20:58 ` [PATCH 11/77] target/microblaze: Split out EDR " Richard Henderson
2020-08-25 20:58 ` [PATCH 12/77] target/microblaze: Split the cpu_SR array Richard Henderson
2020-08-25 20:58 ` [PATCH 13/77] target/microblaze: Fix width of PC and BTARGET Richard Henderson
2020-08-25 20:58 ` [PATCH 14/77] target/microblaze: Fix width of MSR Richard Henderson
2020-08-25 20:58 ` [PATCH 15/77] target/microblaze: Fix width of ESR Richard Henderson
2020-08-25 20:58 ` [PATCH 16/77] target/microblaze: Fix width of FSR Richard Henderson
2020-08-25 20:58 ` [PATCH 17/77] target/microblaze: Fix width of BTR Richard Henderson
2020-08-25 20:58 ` [PATCH 18/77] target/microblaze: Fix width of EDR Richard Henderson
2020-08-25 20:58 ` [PATCH 19/77] target/microblaze: Remove cpu_ear Richard Henderson
2020-08-25 20:58 ` [PATCH 20/77] target/microblaze: Tidy raising of exceptions Richard Henderson
2020-08-25 20:58 ` [PATCH 21/77] target/microblaze: Mark raise_exception as noreturn Richard Henderson
2020-08-25 20:58 ` [PATCH 22/77] target/microblaze: Remove helper_debug and env->debug Richard Henderson
2020-08-25 20:58 ` [PATCH 23/77] target/microblaze: Rename env_* tcg variables to cpu_* Richard Henderson
2020-08-25 20:58 ` [PATCH 24/77] target/microblaze: Tidy mb_tcg_init Richard Henderson
2020-08-25 20:58 ` [PATCH 25/77] target/microblaze: Split out MSR[C] to its own variable Richard Henderson
2020-08-25 20:58 ` [PATCH 26/77] target/microblaze: Use DISAS_NORETURN Richard Henderson
2020-08-25 20:59 ` [PATCH 27/77] target/microblaze: Check singlestep_enabled in gen_goto_tb Richard Henderson
2020-08-25 20:59 ` [PATCH 28/77] target/microblaze: Convert to DisasContextBase Richard Henderson
2020-08-25 20:59 ` [PATCH 29/77] target/microblaze: Convert to translator_loop Richard Henderson
2020-08-25 20:59 ` [PATCH 30/77] target/microblaze: Remove SIM_COMPAT Richard Henderson
2020-08-25 20:59 ` [PATCH 31/77] target/microblaze: Remove DISAS_GNU Richard Henderson
2020-08-25 20:59 ` [PATCH 32/77] target/microblaze: Remove empty D macros Richard Henderson
2020-08-25 20:59 ` [PATCH 33/77] target/microblaze: Remove LOG_DIS Richard Henderson
2020-08-25 20:59 ` [PATCH 34/77] target/microblaze: Ensure imm constant is always available Richard Henderson
2020-08-25 20:59 ` [PATCH 35/77] target/microblaze: Add decodetree infrastructure Richard Henderson
2020-08-25 20:59 ` [PATCH 36/77] target/microblaze: Convert dec_add to decodetree Richard Henderson
2020-08-25 20:59 ` [PATCH 37/77] target/microblaze: Convert dec_sub " Richard Henderson
2020-08-25 20:59 ` [PATCH 38/77] target/microblaze: Implement cmp and cmpu inline Richard Henderson
2020-08-25 20:59 ` [PATCH 39/77] target/microblaze: Convert dec_pattern to decodetree Richard Henderson
2020-08-25 20:59 ` [PATCH 40/77] target/microblaze: Convert dec_and, dec_or, dec_xor " Richard Henderson
2020-08-25 20:59 ` [PATCH 41/77] target/microblaze: Convert dec_mul " Richard Henderson
2020-08-25 20:59 ` [PATCH 42/77] target/microblaze: Convert dec_div " Richard Henderson
2020-08-25 20:59 ` [PATCH 43/77] target/microblaze: Unwind properly when raising divide-by-zero Richard Henderson
2020-08-25 20:59 ` [PATCH 44/77] target/microblaze: Convert dec_bit to decodetree Richard Henderson
2020-08-25 20:59 ` [PATCH 45/77] target/microblaze: Convert dec_barrel " Richard Henderson
2020-08-25 20:59 ` [PATCH 46/77] target/microblaze: Convert dec_imm " Richard Henderson
2020-08-25 20:59 ` [PATCH 47/77] target/microblaze: Convert dec_fpu " Richard Henderson
2020-08-25 20:59 ` [PATCH 48/77] target/microblaze: Fix cpu unwind for fpu exceptions Richard Henderson
2020-08-25 20:59 ` [PATCH 49/77] target/microblaze: Mark fpu helpers TCG_CALL_NO_WG Richard Henderson
2020-08-25 20:59 ` [PATCH 50/77] target/microblaze: Replace MSR_EE_FLAG with MSR_EE Richard Henderson
2020-08-25 20:59 ` [PATCH 51/77] target/microblaze: Cache mem_index in DisasContext Richard Henderson
2020-08-25 20:59 ` [PATCH 52/77] target/microblaze: Fix cpu unwind for stackprot Richard Henderson
2020-08-25 20:59 ` [PATCH 53/77] target/microblaze: Convert dec_load and dec_store to decodetree Richard Henderson
2020-08-25 20:59 ` [PATCH 54/77] target/microblaze: Assert no overlap in flags making up tb_flags Richard Henderson
2020-08-25 20:59 ` [PATCH 55/77] target/microblaze: Move bimm to BIMM_FLAG Richard Henderson
2020-08-25 20:59 ` [PATCH 56/77] target/microblaze: Store "current" iflags in insn_start Richard Henderson
2020-08-25 20:59 ` [PATCH 57/77] tcg: Add tcg_get_insn_start_param Richard Henderson
2020-08-25 20:59 ` [PATCH 58/77] target/microblaze: Use cc->do_unaligned_access Richard Henderson
2020-08-25 20:59 ` [PATCH 59/77] target/microblaze: Replace clear_imm with tb_flags_to_set Richard Henderson
2020-08-25 20:59 ` [PATCH 60/77] target/microblaze: Replace delayed_branch " Richard Henderson
2020-08-25 20:59 ` [PATCH 61/77] target/microblaze: Tidy mb_cpu_dump_state Richard Henderson
2020-08-25 20:59 ` [PATCH 62/77] target/microblaze: Try to keep imm and delay slot together Richard Henderson
2020-08-27 19:17 ` Edgar E. Iglesias
2020-08-27 21:33 ` Richard Henderson
2020-08-29 15:27 ` Richard Henderson
2020-08-25 20:59 ` [PATCH 63/77] target/microblaze: Convert brk and brki to decodetree Richard Henderson
2020-08-25 20:59 ` [PATCH 64/77] target/microblaze: Convert mbar " Richard Henderson
2020-08-27 9:24 ` Edgar E. Iglesias
2020-08-27 9:58 ` Richard Henderson
2020-08-27 10:08 ` Edgar E. Iglesias
2020-08-27 11:11 ` Richard Henderson
2020-08-25 20:59 ` [PATCH 65/77] target/microblaze: Reorganize branching Richard Henderson
2020-08-25 20:59 ` [PATCH 66/77] target/microblaze: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2020-08-28 6:33 ` Edgar E. Iglesias
2020-08-28 13:32 ` Richard Henderson
2020-08-25 20:59 ` [PATCH 67/77] target/microblaze: Convert dec_br to decodetree Richard Henderson
2020-08-25 20:59 ` [PATCH 68/77] target/microblaze: Convert dec_bcc " Richard Henderson
2020-08-25 20:59 ` [PATCH 69/77] target/microblaze: Convert dec_rts " Richard Henderson
2020-08-25 20:59 ` [PATCH 70/77] target/microblaze: Tidy do_rti, do_rtb, do_rte Richard Henderson
2020-08-25 20:59 ` [PATCH 71/77] target/microblaze: Convert msrclr, msrset to decodetree Richard Henderson
2020-08-25 20:59 ` [PATCH 72/77] target/microblaze: Convert dec_msr " Richard Henderson
2020-08-25 20:59 ` [PATCH 73/77] target/microblaze: Convert dec_stream " Richard Henderson
2020-08-27 21:10 ` Edgar E. Iglesias
2020-08-27 21:12 ` Richard Henderson
2020-08-25 20:59 ` [PATCH 74/77] target/microblaze: Remove last of old decoder Richard Henderson
2020-08-25 20:59 ` [PATCH 75/77] target/microblaze: Remove cpu_R[0] Richard Henderson
2020-08-25 20:59 ` [PATCH 76/77] target/microblaze: Add flags markup to some helpers Richard Henderson
2020-08-25 20:59 ` [PATCH 77/77] target/microblaze: Reduce linux-user address space to 32-bit Richard Henderson
2020-08-26 15:27 ` [PATCH 00/77] target/microblaze improvements Edgar E. Iglesias
2020-08-26 18:07 ` Edgar E. Iglesias
2020-08-27 9:11 ` Edgar E. Iglesias
2020-08-27 10:01 ` Richard Henderson
2020-08-27 10:22 ` Edgar E. Iglesias
2020-08-27 11:19 ` Richard Henderson
2020-08-27 17:09 ` Edgar E. Iglesias
2020-08-28 13:36 ` Richard Henderson
2020-08-28 14:04 ` Edgar E. Iglesias
2020-08-28 13:19 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825205950.730499-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.