* [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member
@ 2020-08-25 22:09 Chaitanya Kulkarni
0 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2020-08-25 22:09 UTC (permalink / raw)
To: linux-btrace
Update a struct queue with block trace extension.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
include/linux/blkdev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index bb5636cc17b9..cd3ba7781843 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -529,6 +529,7 @@ struct request_queue {
struct mutex debugfs_mutex;
#ifdef CONFIG_BLK_DEV_IO_TRACE
struct blk_trace __rcu *blk_trace;
+ struct blk_trace_ext __rcu *blk_trace_ext;
#endif
/*
* for flush operations
--
2.22.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member
2021-02-25 7:01 ` [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member Chaitanya Kulkarni
@ 2021-02-26 4:35 ` Damien Le Moal
0 siblings, 0 replies; 6+ messages in thread
From: Damien Le Moal @ 2021-02-26 4:35 UTC (permalink / raw)
To: Chaitanya Kulkarni, axboe, viro, rostedt, mingo,
Johannes Thumshirn, bvanassche, dongli.zhang, Aravind Ramesh,
joshi.k, Niklas Cassel, hch, osandov, martin.petersen
Cc: linux-block, linux-fsdevel
On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
> Update a struct queue with block trace extension.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> include/linux/blkdev.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index c032cfe133c7..7c21f22f2077 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -533,6 +533,7 @@ struct request_queue {
> struct mutex debugfs_mutex;
> #ifdef CONFIG_BLK_DEV_IO_TRACE
> struct blk_trace __rcu *blk_trace;
> + struct blk_trace_ext __rcu *blk_trace_ext;
> #endif
> /*
> * for flush operations
>
You lost me here... why is blk_trace_ext defined in addition to the existing
blk_trace ? Why not extend the definition of struct blk_trace ?
And this patch should probably be squashed into patch 2.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member
2021-02-25 7:01 [RFC PATCH 00/39] blktrace: add block trace extension support Chaitanya Kulkarni
@ 2021-02-25 7:01 ` Chaitanya Kulkarni
2021-02-26 4:35 ` Damien Le Moal
0 siblings, 1 reply; 6+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-25 7:01 UTC (permalink / raw)
To: axboe, viro, rostedt, mingo, chaitanya.kulkarni,
johannes.thumshirn, damien.lemoal, bvanassche, dongli.zhang,
aravind.ramesh, joshi.k, niklas.cassel, hch, osandov,
martin.petersen
Cc: linux-block, linux-fsdevel
Update a struct queue with block trace extension.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
include/linux/blkdev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index c032cfe133c7..7c21f22f2077 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -533,6 +533,7 @@ struct request_queue {
struct mutex debugfs_mutex;
#ifdef CONFIG_BLK_DEV_IO_TRACE
struct blk_trace __rcu *blk_trace;
+ struct blk_trace_ext __rcu *blk_trace_ext;
#endif
/*
* for flush operations
--
2.22.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member
@ 2020-11-05 2:40 Chaitanya Kulkarni
0 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2020-11-05 2:40 UTC (permalink / raw)
To: linux-btrace
Update a struct queue with block trace extension.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
include/linux/blkdev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 639cae2c158b..8e9fd3d01f17 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -537,6 +537,7 @@ struct request_queue {
struct mutex debugfs_mutex;
#ifdef CONFIG_BLK_DEV_IO_TRACE
struct blk_trace __rcu *blk_trace;
+ struct blk_trace_ext __rcu *blk_trace_ext;
#endif
/*
* for flush operations
--
2.22.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member
@ 2020-03-23 16:29 Chaitanya Kulkarni
0 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2020-03-23 16:29 UTC (permalink / raw)
To: linux-btrace
Update a struct queue with block trace extension.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
include/linux/blkdev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f629d40c645c..13ccdfbf7c32 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -34,6 +34,7 @@ struct scsi_ioctl_command;
struct request_queue;
struct elevator_queue;
struct blk_trace;
+struct blk_trace_ext;
struct request;
struct sg_io_hdr;
struct bsg_job;
@@ -526,6 +527,8 @@ struct request_queue {
#ifdef CONFIG_BLK_DEV_IO_TRACE
struct blk_trace __rcu *blk_trace;
struct mutex blk_trace_mutex;
+ struct blk_trace_ext __rcu *blk_trace_ext;
+ struct mutex blk_trace_ext_mutex;
#endif
/*
* for flush operations
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member
@ 2019-11-20 4:24 Chaitanya Kulkarni
0 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2019-11-20 4:24 UTC (permalink / raw)
To: linux-btrace
Update a struct queue with block trace extension.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
include/linux/blkdev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 397bb9bc230b..3b2945c50a83 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -34,6 +34,7 @@ struct scsi_ioctl_command;
struct request_queue;
struct elevator_queue;
struct blk_trace;
+struct blk_trace_ext;
struct request;
struct sg_io_hdr;
struct bsg_job;
@@ -532,6 +533,8 @@ struct request_queue {
#ifdef CONFIG_BLK_DEV_IO_TRACE
struct blk_trace *blk_trace;
struct mutex blk_trace_mutex;
+ struct blk_trace_ext *blk_trace_ext;
+ struct mutex blk_trace_ext_mutex;
#endif
/*
* for flush operations
--
2.22.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-26 4:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 22:09 [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member Chaitanya Kulkarni
-- strict thread matches above, loose matches on Subject: below --
2021-02-25 7:01 [RFC PATCH 00/39] blktrace: add block trace extension support Chaitanya Kulkarni
2021-02-25 7:01 ` [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member Chaitanya Kulkarni
2021-02-26 4:35 ` Damien Le Moal
2020-11-05 2:40 Chaitanya Kulkarni
2020-03-23 16:29 Chaitanya Kulkarni
2019-11-20 4:24 Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.