* [RFC PATCH 04/39] blktrace: add a new global list
@ 2020-08-25 22:09 Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-08-25 22:09 UTC (permalink / raw)
To: linux-btrace
Add a separate list to hold running extension traces.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
kernel/trace/blktrace.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 7ba62d68885a..7857ac2b37c9 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -36,6 +36,9 @@ static bool blk_tracer_enabled __read_mostly;
static LIST_HEAD(running_trace_list);
static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_lock);
+static LIST_HEAD(running_trace_ext_list);
+static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_ext_lock);
+
/* Select an alternative, minimalistic output than the original one */
#define TRACE_BLK_OPT_CLASSIC 0x1
#define TRACE_BLK_OPT_CGROUP 0x2
--
2.22.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH 04/39] blktrace: add a new global list
2021-02-25 7:01 ` [RFC PATCH 04/39] blktrace: add a new global list Chaitanya Kulkarni
@ 2021-02-26 4:36 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2021-02-26 4:36 UTC (permalink / raw)
To: Chaitanya Kulkarni, axboe, viro, rostedt, mingo,
Johannes Thumshirn, bvanassche, dongli.zhang, Aravind Ramesh,
joshi.k, Niklas Cassel, hch, osandov, martin.petersen
Cc: linux-block, linux-fsdevel
On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
> Add a separate list to hold running extension traces.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> kernel/trace/blktrace.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index ca6f0ceba09b..e45bbfcb5daf 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -36,6 +36,9 @@ static bool blk_tracer_enabled __read_mostly;
> static LIST_HEAD(running_trace_list);
> static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_lock);
>
> +static LIST_HEAD(running_trace_ext_list);
> +static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_ext_lock);
Why is this necessary ? This is not explained. Why cannot you keep using
running_trace_lock ?
> +
> /* Select an alternative, minimalistic output than the original one */
> #define TRACE_BLK_OPT_CLASSIC 0x1
> #define TRACE_BLK_OPT_CGROUP 0x2
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC PATCH 04/39] blktrace: add a new global list
2021-02-25 7:01 [RFC PATCH 00/39] blktrace: add block trace extension support Chaitanya Kulkarni
@ 2021-02-25 7:01 ` Chaitanya Kulkarni
2021-02-26 4:36 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-25 7:01 UTC (permalink / raw)
To: axboe, viro, rostedt, mingo, chaitanya.kulkarni,
johannes.thumshirn, damien.lemoal, bvanassche, dongli.zhang,
aravind.ramesh, joshi.k, niklas.cassel, hch, osandov,
martin.petersen
Cc: linux-block, linux-fsdevel
Add a separate list to hold running extension traces.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
kernel/trace/blktrace.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index ca6f0ceba09b..e45bbfcb5daf 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -36,6 +36,9 @@ static bool blk_tracer_enabled __read_mostly;
static LIST_HEAD(running_trace_list);
static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_lock);
+static LIST_HEAD(running_trace_ext_list);
+static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_ext_lock);
+
/* Select an alternative, minimalistic output than the original one */
#define TRACE_BLK_OPT_CLASSIC 0x1
#define TRACE_BLK_OPT_CGROUP 0x2
--
2.22.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RFC PATCH 04/39] blktrace: add a new global list
@ 2020-11-05 2:40 Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-11-05 2:40 UTC (permalink / raw)
To: linux-btrace
Add a separate list to hold running extension traces.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
kernel/trace/blktrace.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index f1022945e346..e7fc8330b7bb 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -36,6 +36,9 @@ static bool blk_tracer_enabled __read_mostly;
static LIST_HEAD(running_trace_list);
static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_lock);
+static LIST_HEAD(running_trace_ext_list);
+static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_ext_lock);
+
/* Select an alternative, minimalistic output than the original one */
#define TRACE_BLK_OPT_CLASSIC 0x1
#define TRACE_BLK_OPT_CGROUP 0x2
--
2.22.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-26 4:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 22:09 [RFC PATCH 04/39] blktrace: add a new global list Chaitanya Kulkarni
2020-11-05 2:40 Chaitanya Kulkarni
2021-02-25 7:01 [RFC PATCH 00/39] blktrace: add block trace extension support Chaitanya Kulkarni
2021-02-25 7:01 ` [RFC PATCH 04/39] blktrace: add a new global list Chaitanya Kulkarni
2021-02-26 4:36 ` Damien Le Moal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.