* [RFC PATCH 06/39] blktrace: add act and prio check helpers
@ 2020-08-25 22:09 Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-08-25 22:09 UTC (permalink / raw)
To: linux-btrace
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
kernel/trace/blktrace.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index f739a1b73a47..a2270818e29c 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -311,6 +311,43 @@ static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
return 0;
}
+static inline bool prio_log_check(struct blk_trace_ext *bt, u32 ioprio)
+{
+ bool ret;
+
+ switch (IOPRIO_PRIO_CLASS(ioprio)) {
+ case IOPRIO_CLASS_NONE:
+ ret = (bt->prio_mask & 0x01) ? true : false;
+ break;
+ case IOPRIO_CLASS_RT:
+ ret = (bt->prio_mask & 0x02) ? true : false;
+ break;
+ case IOPRIO_CLASS_BE:
+ ret = (bt->prio_mask & 0x04) ? true : false;
+ break;
+ case IOPRIO_CLASS_IDLE:
+ ret = (bt->prio_mask & 0x08) ? true : false;
+ break;
+ default:
+ /*XXX: print rate limit warn here */
+ ret = false;
+ }
+ return ret;
+}
+
+static inline int act_log_check_ext(struct blk_trace_ext *bt, u64 what,
+ sector_t sector, pid_t pid)
+{
+ if (((bt->act_mask << BLK_TC_SHIFT_EXT) & what) = 0)
+ return 1;
+ if (sector && (sector < bt->start_lba || sector > bt->end_lba))
+ return 1;
+ if (bt->pid && pid != bt->pid)
+ return 1;
+
+ return 0;
+}
+
/*
* Data direction bit lookup
*/
--
2.22.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH 06/39] blktrace: add act and prio check helpers
2021-02-25 7:01 ` [RFC PATCH 06/39] blktrace: add act and prio check helpers Chaitanya Kulkarni
@ 2021-02-26 4:41 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2021-02-26 4:41 UTC (permalink / raw)
To: Chaitanya Kulkarni, axboe, viro, rostedt, mingo,
Johannes Thumshirn, bvanassche, dongli.zhang, Aravind Ramesh,
joshi.k, Niklas Cassel, hch, osandov, martin.petersen
Cc: linux-block, linux-fsdevel
On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> kernel/trace/blktrace.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 4871934b9717..feb823b917ec 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -311,6 +311,43 @@ static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
> return 0;
> }
>
> +static inline bool prio_log_check(struct blk_trace_ext *bt, u32 ioprio)
> +{
> + bool ret;
> +
> + switch (IOPRIO_PRIO_CLASS(ioprio)) {
> + case IOPRIO_CLASS_NONE:
> + ret = (bt->prio_mask & 0x01) ? true : false;
> + break;
> + case IOPRIO_CLASS_RT:
> + ret = (bt->prio_mask & 0x02) ? true : false;
> + break;
> + case IOPRIO_CLASS_BE:
> + ret = (bt->prio_mask & 0x04) ? true : false;
> + break;
> + case IOPRIO_CLASS_IDLE:
> + ret = (bt->prio_mask & 0x08) ? true : false;
> + break;
> + default:
> + /*XXX: print rate limit warn here */
> + ret = false;
> + }
> + return ret;
> +}
> +
> +static inline int act_log_check_ext(struct blk_trace_ext *bt, u64 what,
> + sector_t sector, pid_t pid)
> +{
> + if (((bt->act_mask << BLK_TC_SHIFT_EXT) & what) == 0)
> + return 1;
> + if (sector && (sector < bt->start_lba || sector > bt->end_lba))
> + return 1;
> + if (bt->pid && pid != bt->pid)
> + return 1;
> +
> + return 0;
> +}
> +
> /*
> * Data direction bit lookup
> */
>
Without the code using these helpers in the same patch, it is hard to see what
these are for...
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC PATCH 06/39] blktrace: add act and prio check helpers
2021-02-25 7:01 [RFC PATCH 00/39] blktrace: add block trace extension support Chaitanya Kulkarni
@ 2021-02-25 7:01 ` Chaitanya Kulkarni
2021-02-26 4:41 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-25 7:01 UTC (permalink / raw)
To: axboe, viro, rostedt, mingo, chaitanya.kulkarni,
johannes.thumshirn, damien.lemoal, bvanassche, dongli.zhang,
aravind.ramesh, joshi.k, niklas.cassel, hch, osandov,
martin.petersen
Cc: linux-block, linux-fsdevel
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
kernel/trace/blktrace.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 4871934b9717..feb823b917ec 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -311,6 +311,43 @@ static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
return 0;
}
+static inline bool prio_log_check(struct blk_trace_ext *bt, u32 ioprio)
+{
+ bool ret;
+
+ switch (IOPRIO_PRIO_CLASS(ioprio)) {
+ case IOPRIO_CLASS_NONE:
+ ret = (bt->prio_mask & 0x01) ? true : false;
+ break;
+ case IOPRIO_CLASS_RT:
+ ret = (bt->prio_mask & 0x02) ? true : false;
+ break;
+ case IOPRIO_CLASS_BE:
+ ret = (bt->prio_mask & 0x04) ? true : false;
+ break;
+ case IOPRIO_CLASS_IDLE:
+ ret = (bt->prio_mask & 0x08) ? true : false;
+ break;
+ default:
+ /*XXX: print rate limit warn here */
+ ret = false;
+ }
+ return ret;
+}
+
+static inline int act_log_check_ext(struct blk_trace_ext *bt, u64 what,
+ sector_t sector, pid_t pid)
+{
+ if (((bt->act_mask << BLK_TC_SHIFT_EXT) & what) == 0)
+ return 1;
+ if (sector && (sector < bt->start_lba || sector > bt->end_lba))
+ return 1;
+ if (bt->pid && pid != bt->pid)
+ return 1;
+
+ return 0;
+}
+
/*
* Data direction bit lookup
*/
--
2.22.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RFC PATCH 06/39] blktrace: add act and prio check helpers
@ 2020-11-05 2:40 Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-11-05 2:40 UTC (permalink / raw)
To: linux-btrace
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
kernel/trace/blktrace.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 96c11bda8eef..12ba2b170f02 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -311,6 +311,43 @@ static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
return 0;
}
+static inline bool prio_log_check(struct blk_trace_ext *bt, u32 ioprio)
+{
+ bool ret;
+
+ switch (IOPRIO_PRIO_CLASS(ioprio)) {
+ case IOPRIO_CLASS_NONE:
+ ret = (bt->prio_mask & 0x01) ? true : false;
+ break;
+ case IOPRIO_CLASS_RT:
+ ret = (bt->prio_mask & 0x02) ? true : false;
+ break;
+ case IOPRIO_CLASS_BE:
+ ret = (bt->prio_mask & 0x04) ? true : false;
+ break;
+ case IOPRIO_CLASS_IDLE:
+ ret = (bt->prio_mask & 0x08) ? true : false;
+ break;
+ default:
+ /*XXX: print rate limit warn here */
+ ret = false;
+ }
+ return ret;
+}
+
+static inline int act_log_check_ext(struct blk_trace_ext *bt, u64 what,
+ sector_t sector, pid_t pid)
+{
+ if (((bt->act_mask << BLK_TC_SHIFT_EXT) & what) = 0)
+ return 1;
+ if (sector && (sector < bt->start_lba || sector > bt->end_lba))
+ return 1;
+ if (bt->pid && pid != bt->pid)
+ return 1;
+
+ return 0;
+}
+
/*
* Data direction bit lookup
*/
--
2.22.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-26 4:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 22:09 [RFC PATCH 06/39] blktrace: add act and prio check helpers Chaitanya Kulkarni
2020-11-05 2:40 Chaitanya Kulkarni
2021-02-25 7:01 [RFC PATCH 00/39] blktrace: add block trace extension support Chaitanya Kulkarni
2021-02-25 7:01 ` [RFC PATCH 06/39] blktrace: add act and prio check helpers Chaitanya Kulkarni
2021-02-26 4:41 ` Damien Le Moal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.