* [PATCH] meson: don't require CONFIG_VTE for the GTK UI
@ 2020-08-25 22:23 Mark Cave-Ayland
2020-08-26 5:12 ` Gerd Hoffmann
2020-08-26 7:56 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Mark Cave-Ayland @ 2020-08-25 22:23 UTC (permalink / raw)
To: qemu-devel, pbonzini, kraxel
Prevously CONFIG_VTE was not required to build QEMU with GTK UI support as not
all platforms have VTE available (in particular Windows).
Remove this requirement from the meson build system to enable QEMU to be built
with GTK UI support for Windows once again.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
ui/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/meson.build b/ui/meson.build
index 018c5698bf..a81d5c259c 100644
--- a/ui/meson.build
+++ b/ui/meson.build
@@ -42,7 +42,7 @@ if config_host.has_key('CONFIG_CURSES')
ui_modules += {'curses' : curses_ss}
endif
-if config_host.has_key('CONFIG_GTK') and config_host.has_key('CONFIG_VTE')
+if config_host.has_key('CONFIG_GTK')
softmmu_ss.add(when: 'CONFIG_WIN32', if_true: files('win32-kbd-hook.c'))
gtk_ss = ss.source_set()
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] meson: don't require CONFIG_VTE for the GTK UI
2020-08-25 22:23 [PATCH] meson: don't require CONFIG_VTE for the GTK UI Mark Cave-Ayland
@ 2020-08-26 5:12 ` Gerd Hoffmann
2020-08-26 7:56 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2020-08-26 5:12 UTC (permalink / raw)
To: Mark Cave-Ayland; +Cc: pbonzini, qemu-devel
On Tue, Aug 25, 2020 at 11:23:10PM +0100, Mark Cave-Ayland wrote:
> Prevously CONFIG_VTE was not required to build QEMU with GTK UI support as not
> all platforms have VTE available (in particular Windows).
>
> Remove this requirement from the meson build system to enable QEMU to be built
> with GTK UI support for Windows once again.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] meson: don't require CONFIG_VTE for the GTK UI
2020-08-25 22:23 [PATCH] meson: don't require CONFIG_VTE for the GTK UI Mark Cave-Ayland
2020-08-26 5:12 ` Gerd Hoffmann
@ 2020-08-26 7:56 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-08-26 7:56 UTC (permalink / raw)
To: Mark Cave-Ayland; +Cc: qemu-devel, Hoffmann, Gerd
Queued, thanks.
Paolo
On Wed, Aug 26, 2020 at 12:23 AM Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
>
> Prevously CONFIG_VTE was not required to build QEMU with GTK UI support as not
> all platforms have VTE available (in particular Windows).
>
> Remove this requirement from the meson build system to enable QEMU to be built
> with GTK UI support for Windows once again.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> ui/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/meson.build b/ui/meson.build
> index 018c5698bf..a81d5c259c 100644
> --- a/ui/meson.build
> +++ b/ui/meson.build
> @@ -42,7 +42,7 @@ if config_host.has_key('CONFIG_CURSES')
> ui_modules += {'curses' : curses_ss}
> endif
>
> -if config_host.has_key('CONFIG_GTK') and config_host.has_key('CONFIG_VTE')
> +if config_host.has_key('CONFIG_GTK')
> softmmu_ss.add(when: 'CONFIG_WIN32', if_true: files('win32-kbd-hook.c'))
>
> gtk_ss = ss.source_set()
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-26 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 22:23 [PATCH] meson: don't require CONFIG_VTE for the GTK UI Mark Cave-Ayland
2020-08-26 5:12 ` Gerd Hoffmann
2020-08-26 7:56 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.