All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images
@ 2020-08-26 14:52 Alexander Kanavin
  2020-08-26 15:24 ` [poky] " Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-08-26 14:52 UTC (permalink / raw)
  To: poky; +Cc: Alexander Kanavin

The purpose of the group and what it should contain is no longer clear, and
generally adding userspace development items to images is best done
at the image/class level.

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
 meta-poky/conf/distro/poky.conf | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/meta-poky/conf/distro/poky.conf b/meta-poky/conf/distro/poky.conf
index 826f0d633a..e55641d87f 100644
--- a/meta-poky/conf/distro/poky.conf
+++ b/meta-poky/conf/distro/poky.conf
@@ -29,14 +29,6 @@ SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
 DISTRO_EXTRA_RDEPENDS += " ${POKY_DEFAULT_EXTRA_RDEPENDS}"
 DISTRO_EXTRA_RRECOMMENDS += " ${POKY_DEFAULT_EXTRA_RRECOMMENDS}"
 
-POKYQEMUDEPS = "${@bb.utils.contains("INCOMPATIBLE_LICENSE", "GPL-3.0", "", "packagegroup-core-device-devel",d)}"
-DISTRO_EXTRA_RDEPENDS_append_qemuarm = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemuarm64 = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemumips = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemuppc = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemux86 = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemux86-64 = " ${POKYQEMUDEPS}"
-
 TCLIBCAPPEND = ""
 
 PREMIRRORS ??= "\
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [poky] [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images
  2020-08-26 14:52 [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images Alexander Kanavin
@ 2020-08-26 15:24 ` Richard Purdie
  2020-08-26 15:46   ` Alexander Kanavin
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2020-08-26 15:24 UTC (permalink / raw)
  To: Alexander Kanavin, poky

On Wed, 2020-08-26 at 16:52 +0200, Alexander Kanavin wrote:
> The purpose of the group and what it should contain is no longer
> clear, and
> generally adding userspace development items to images is best done
> at the image/class level.
> 
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>  meta-poky/conf/distro/poky.conf | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/meta-poky/conf/distro/poky.conf b/meta-
> poky/conf/distro/poky.conf
> index 826f0d633a..e55641d87f 100644
> --- a/meta-poky/conf/distro/poky.conf
> +++ b/meta-poky/conf/distro/poky.conf
> @@ -29,14 +29,6 @@ SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
>  DISTRO_EXTRA_RDEPENDS += " ${POKY_DEFAULT_EXTRA_RDEPENDS}"
>  DISTRO_EXTRA_RRECOMMENDS += " ${POKY_DEFAULT_EXTRA_RRECOMMENDS}"
>  
> -POKYQEMUDEPS = "${@bb.utils.contains("INCOMPATIBLE_LICENSE", "GPL-
> 3.0", "", "packagegroup-core-device-devel",d)}"
> -DISTRO_EXTRA_RDEPENDS_append_qemuarm = " ${POKYQEMUDEPS}"
> -DISTRO_EXTRA_RDEPENDS_append_qemuarm64 = " ${POKYQEMUDEPS}"
> -DISTRO_EXTRA_RDEPENDS_append_qemumips = " ${POKYQEMUDEPS}"
> -DISTRO_EXTRA_RDEPENDS_append_qemuppc = " ${POKYQEMUDEPS}"
> -DISTRO_EXTRA_RDEPENDS_append_qemux86 = " ${POKYQEMUDEPS}"
> -DISTRO_EXTRA_RDEPENDS_append_qemux86-64 = " ${POKYQEMUDEPS}"
> -
>  TCLIBCAPPEND = ""

A test build is showing this isn't going to be without issues:

https://autobuilder.yoctoproject.org/typhoon/#/builders/57/builds/2343

(the rest is still building)

Cheers,

Richard


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [poky] [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images
  2020-08-26 15:24 ` [poky] " Richard Purdie
@ 2020-08-26 15:46   ` Alexander Kanavin
  2020-08-26 16:14     ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-08-26 15:46 UTC (permalink / raw)
  To: Richard Purdie; +Cc: poky

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

On Wed, 26 Aug 2020 at 17:24, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

>
> A test build is showing this isn't going to be without issues:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/57/builds/2343
>
> (the rest is still building)
>

The x32 test, and the multilib test both need binutils in core-image-sato -
probably should be tweaked in config.json, as neither test is added to
TEST_SUITES by default?

Alex

[-- Attachment #2: Type: text/html, Size: 928 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [poky] [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images
  2020-08-26 15:46   ` Alexander Kanavin
@ 2020-08-26 16:14     ` Richard Purdie
  2020-08-26 20:51       ` Ross Burton
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2020-08-26 16:14 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: poky

On Wed, 2020-08-26 at 17:46 +0200, Alexander Kanavin wrote:
> On Wed, 26 Aug 2020 at 17:24, Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > A test build is showing this isn't going to be without issues:
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/57/builds/2343
> > 
> > (the rest is still building)
> 
> The x32 test, and the multilib test both need binutils in core-image-
> sato - probably should be tweaked in config.json, as neither test is
> added to TEST_SUITES by default?

That feels extremely ugly but its one way to address it I guess :/

Cheers,

Richard


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [poky] [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images
  2020-08-26 16:14     ` Richard Purdie
@ 2020-08-26 20:51       ` Ross Burton
  2020-08-26 20:53         ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Ross Burton @ 2020-08-26 20:51 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Alexander Kanavin, poky

On Wed, 26 Aug 2020 at 17:14, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> > The x32 test, and the multilib test both need binutils in core-image-
> > sato - probably should be tweaked in config.json, as neither test is
> > added to TEST_SUITES by default?
>
> That feels extremely ugly but its one way to address it I guess :/

Would it be better to make the tests check for binutils being present,
and then ensuring that at least some of those tests are executed with
core-image-sato-sdk or similar?

Ross

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [poky] [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images
  2020-08-26 20:51       ` Ross Burton
@ 2020-08-26 20:53         ` Richard Purdie
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2020-08-26 20:53 UTC (permalink / raw)
  To: Ross Burton; +Cc: Alexander Kanavin, poky

On Wed, 2020-08-26 at 21:51 +0100, Ross Burton wrote:
> On Wed, 26 Aug 2020 at 17:14, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > > The x32 test, and the multilib test both need binutils in core-
> > > image-
> > > sato - probably should be tweaked in config.json, as neither test
> > > is
> > > added to TEST_SUITES by default?
> > 
> > That feels extremely ugly but its one way to address it I guess :/
> 
> Would it be better to make the tests check for binutils being
> present,
> and then ensuring that at least some of those tests are executed with
> core-image-sato-sdk or similar?

Alex sent a patch to autobuilder-helper so I replied there.

I'm wondering why we don't scp the file and then run readelf locally on
the server which avoids this problem?

Cheers,

Richard


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-08-26 20:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 14:52 [PATCH] poky.conf: do not install packagegroup-core-device-devel into qemu images Alexander Kanavin
2020-08-26 15:24 ` [poky] " Richard Purdie
2020-08-26 15:46   ` Alexander Kanavin
2020-08-26 16:14     ` Richard Purdie
2020-08-26 20:51       ` Ross Burton
2020-08-26 20:53         ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.