* [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests
@ 2020-08-26 15:54 Alexander Kanavin
2020-08-26 20:50 ` [yocto] " Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-08-26 15:54 UTC (permalink / raw)
To: yocto; +Cc: Alexander Kanavin
Previously it was pulled in implicitly via poky default config.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
config.json | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/config.json b/config.json
index b78cba7..25be864 100644
--- a/config.json
+++ b/config.json
@@ -452,6 +452,7 @@
"step2" : {
"SANITYTARGETS" : "core-image-sato:do_testimage",
"extravars" : [
+ "IMAGE_INSTALL_append = ' binutils'",
"TEST_SUITES_append = ' x32lib'"
]
}
@@ -501,7 +502,7 @@
"MULTILIBS = 'multilib:lib32'",
"DEFAULTTUNE_virtclass-multilib-lib32 = 'x86'",
"RPM_PREFER_ELF_ARCH = '1'",
- "IMAGE_INSTALL_append = ' lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
+ "IMAGE_INSTALL_append = ' binutils lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
]
},
"step4" : {
@@ -514,7 +515,7 @@
"MULTILIBS = 'multilib:lib32'",
"DEFAULTTUNE_virtclass-multilib-lib32 = 'x86'",
"RPM_PREFER_ELF_ARCH = '1'",
- "IMAGE_INSTALL_append = ' lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
+ "IMAGE_INSTALL_append = ' binutils lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
]
},
"step5" : {
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [yocto] [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests
2020-08-26 15:54 [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests Alexander Kanavin
@ 2020-08-26 20:50 ` Richard Purdie
2020-08-26 21:00 ` Alexander Kanavin
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2020-08-26 20:50 UTC (permalink / raw)
To: Alexander Kanavin, yocto
On Wed, 2020-08-26 at 17:54 +0200, Alexander Kanavin wrote:
> Previously it was pulled in implicitly via poky default config.
>
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
> config.json | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/config.json b/config.json
> index b78cba7..25be864 100644
> --- a/config.json
> +++ b/config.json
> @@ -452,6 +452,7 @@
> "step2" : {
> "SANITYTARGETS" : "core-image-sato:do_testimage",
> "extravars" : [
> + "IMAGE_INSTALL_append = ' binutils'",
> "TEST_SUITES_append = ' x32lib'"
> ]
> }
> @@ -501,7 +502,7 @@
> "MULTILIBS = 'multilib:lib32'",
> "DEFAULTTUNE_virtclass-multilib-lib32 = 'x86'",
> "RPM_PREFER_ELF_ARCH = '1'",
> - "IMAGE_INSTALL_append = ' lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
> + "IMAGE_INSTALL_append = ' binutils lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
> ]
> },
> "step4" : {
> @@ -514,7 +515,7 @@
> "MULTILIBS = 'multilib:lib32'",
> "DEFAULTTUNE_virtclass-multilib-lib32 = 'x86'",
> "RPM_PREFER_ELF_ARCH = '1'",
> - "IMAGE_INSTALL_append = ' lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
> + "IMAGE_INSTALL_append = ' binutils lib32-connman-gnome gdk-pixbuf-loader-jpeg lib32-gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-png lib32-gdk-pixbuf-loader-png pango-module-basic-fc lib32-pango-module-basic-fc'"
> ]
> },
> "step5" : {
I suspect we need binutils-symlinks instead of binutils?
Also, thinking about this more, why aren't these tests scp'ing the file
to the host system and running readelf there? That would remove the
need for the dependency?
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [yocto] [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests
2020-08-26 20:50 ` [yocto] " Richard Purdie
@ 2020-08-26 21:00 ` Alexander Kanavin
2020-08-26 21:03 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-08-26 21:00 UTC (permalink / raw)
To: Richard Purdie; +Cc: yocto
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Wed, 26 Aug 2020 at 22:50, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> I suspect we need binutils-symlinks instead of binutils?
>
binutils-symlinks is only an alias to the main package according to
binutils.inc:
RPROVIDES_${PN} += "${PN}-symlinks"
> Also, thinking about this more, why aren't these tests scp'ing the file
> to the host system and running readelf there? That would remove the
> need for the dependency?
>
I didn't write either of the tests, but yes - I can work on this tomorrow.
Alex
[-- Attachment #2: Type: text/html, Size: 1115 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [yocto] [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests
2020-08-26 21:00 ` Alexander Kanavin
@ 2020-08-26 21:03 ` Richard Purdie
2020-08-27 11:01 ` Alexander Kanavin
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2020-08-26 21:03 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: yocto
On Wed, 2020-08-26 at 23:00 +0200, Alexander Kanavin wrote:
> On Wed, 26 Aug 2020 at 22:50, Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > I suspect we need binutils-symlinks instead of binutils?
>
> binutils-symlinks is only an alias to the main package according to
> binutils.inc:
>
> RPROVIDES_${PN} += "${PN}-symlinks"
Fair enough, I suspect I'm getting it confused with gcc-symlinks.
> > Also, thinking about this more, why aren't these tests scp'ing the
> > file
> > to the host system and running readelf there? That would remove the
> > need for the dependency?
>
> I didn't write either of the tests, but yes - I can work on this
> tomorrow.
Right, I didn't write them either, they're rather old. I'm just
thinking whilst we've gotten this far we may as well fix this properly
and stop it being copy and pasted onward. I appreciate the help!
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [yocto] [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests
2020-08-26 21:03 ` Richard Purdie
@ 2020-08-27 11:01 ` Alexander Kanavin
2020-08-27 11:19 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-08-27 11:01 UTC (permalink / raw)
To: Richard Purdie; +Cc: yocto
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
On Wed, 26 Aug 2020 at 23:03, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> > I didn't write either of the tests, but yes - I can work on this
> > tomorrow.
>
> Right, I didn't write them either, they're rather old. I'm just
> thinking whilst we've gotten this far we may as well fix this properly
> and stop it being copy and pasted onward. I appreciate the help!
>
And done, patches sent :) Bonus fix: one of the multilib tests was
erroneously always skipped.
Alex
[-- Attachment #2: Type: text/html, Size: 853 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [yocto] [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests
2020-08-27 11:01 ` Alexander Kanavin
@ 2020-08-27 11:19 ` Richard Purdie
0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2020-08-27 11:19 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: yocto
On Thu, 2020-08-27 at 13:01 +0200, Alexander Kanavin wrote:
> On Wed, 26 Aug 2020 at 23:03, Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > > I didn't write either of the tests, but yes - I can work on this
> > > tomorrow.
> >
> > Right, I didn't write them either, they're rather old. I'm just
> > thinking whilst we've gotten this far we may as well fix this
> > properly
> > and stop it being copy and pasted onward. I appreciate the help!
>
> And done, patches sent :) Bonus fix: one of the multilib tests was
> erroneously always skipped.
Thanks, much appreciated!
I had a question on the skipped test. I think its only applicable to
one specific multilib test case...
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-27 11:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 15:54 [PATCH yocto-autobuilder-helper] config.json: add binutils to images where it's required by tests Alexander Kanavin
2020-08-26 20:50 ` [yocto] " Richard Purdie
2020-08-26 21:00 ` Alexander Kanavin
2020-08-26 21:03 ` Richard Purdie
2020-08-27 11:01 ` Alexander Kanavin
2020-08-27 11:19 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.