* [PATCH 0/5] qspi binding and DTS fixes
@ 2020-08-27 18:18 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Florian Fainelli, Kamal Dasu, maintainer:BROADCOM SPI DRIVER,
Mark Brown, Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi all,
This patch series fixes incorrectly defined compatible strings for the
Broadcom QSPI controller which resulted in the strings not being
ordered from most to least compatible.
We will need to apply some changes to the spi-bcm-qspi.c driver in
the future to assume no revision register exist, and these patches
are a preliminary step towards that goal.
Florian Fainelli (5):
dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
ARM: dts: bcm: HR2: Fixed QSPI compatible string
ARM: dts: NSP: Fixed QSPI compatible string
ARM: dts: BCM5301X: Fixed QSPI compatible string
arm64: dts: ns2: Fixed QSPI compatible string
.../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/5] qspi binding and DTS fixes
@ 2020-08-27 18:18 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Scott Branden, Kamal Dasu, Ray Jui,
Rafał Miłecki, open list, Rob Herring,
open list:SPI SUBSYSTEM, Yendapally Reddy Dhananjaya Reddy,
Mark Brown, maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
Hi all,
This patch series fixes incorrectly defined compatible strings for the
Broadcom QSPI controller which resulted in the strings not being
ordered from most to least compatible.
We will need to apply some changes to the spi-bcm-qspi.c driver in
the future to assume no revision register exist, and these patches
are a preliminary step towards that goal.
Florian Fainelli (5):
dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
ARM: dts: bcm: HR2: Fixed QSPI compatible string
ARM: dts: NSP: Fixed QSPI compatible string
ARM: dts: BCM5301X: Fixed QSPI compatible string
arm64: dts: ns2: Fixed QSPI compatible string
.../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
2020-08-27 18:18 ` Florian Fainelli
@ 2020-08-27 18:18 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Florian Fainelli, Kamal Dasu, maintainer:BROADCOM SPI DRIVER,
Mark Brown, Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The binding is currently incorrectly defining the compatible strings
from least specific to most specific instead of the converse. Re-order
them from most specific (left) to least specific (right) and fix the
examples as well.
Fixes: 5fc78f4c842a ("spi: Broadcom BRCMSTB, NSP, NS2 SoC bindings")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt
index f5e518d099f2..62d4ed2d7fd7 100644
--- a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt
+++ b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt
@@ -23,8 +23,8 @@ Required properties:
- compatible:
Must be one of :
- "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-qspi" : MSPI+BSPI on BRCMSTB SoCs
- "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-mspi" : Second Instance of MSPI
+ "brcm,spi-brcmstb-qspi", "brcm,spi-bcm-qspi" : MSPI+BSPI on BRCMSTB SoCs
+ "brcm,spi-brcmstb-mspi", "brcm,spi-bcm-qspi" : Second Instance of MSPI
BRCMSTB SoCs
"brcm,spi-bcm7425-qspi", "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-mspi" : Second Instance of MSPI
BRCMSTB SoCs
@@ -36,8 +36,8 @@ Required properties:
BRCMSTB SoCs
"brcm,spi-bcm7278-qspi", "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-mspi" : Second Instance of MSPI
BRCMSTB SoCs
- "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi" : MSPI+BSPI on Cygnus, NSP
- "brcm,spi-bcm-qspi", "brcm,spi-ns2-qspi" : NS2 SoCs
+ "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi" : MSPI+BSPI on Cygnus, NSP
+ "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi" : NS2 SoCs
- reg:
Define the bases and ranges of the associated I/O address spaces.
@@ -86,7 +86,7 @@ BRCMSTB SoC Example:
spi@f03e3400 {
#address-cells = <0x1>;
#size-cells = <0x0>;
- compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-brcmstb-qspi";
+ compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-bcm-qspi";
reg = <0xf03e0920 0x4 0xf03e3400 0x188 0xf03e3200 0x50>;
reg-names = "cs_reg", "mspi", "bspi";
interrupts = <0x6 0x5 0x4 0x3 0x2 0x1 0x0>;
@@ -149,7 +149,7 @@ BRCMSTB SoC Example:
#address-cells = <1>;
#size-cells = <0>;
clocks = <&upg_fixed>;
- compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-brcmstb-mspi";
+ compatible = "brcm,spi-brcmstb-mspi", "brcm,spi-bcm-qspi";
reg = <0xf0416000 0x180>;
reg-names = "mspi";
interrupts = <0x14>;
@@ -160,7 +160,7 @@ BRCMSTB SoC Example:
iProc SoC Example:
qspi: spi@18027200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x18027200 0x184>,
<0x18027000 0x124>,
<0x1811c408 0x004>,
@@ -191,7 +191,7 @@ iProc SoC Example:
NS2 SoC Example:
qspi: spi@66470200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-ns2-qspi";
+ compatible = "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi";
reg = <0x66470200 0x184>,
<0x66470000 0x124>,
<0x67017408 0x004>,
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
@ 2020-08-27 18:18 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Scott Branden, Kamal Dasu, Ray Jui,
Rafał Miłecki, open list, Rob Herring,
open list:SPI SUBSYSTEM, Yendapally Reddy Dhananjaya Reddy,
Mark Brown, maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
The binding is currently incorrectly defining the compatible strings
from least specific to most specific instead of the converse. Re-order
them from most specific (left) to least specific (right) and fix the
examples as well.
Fixes: 5fc78f4c842a ("spi: Broadcom BRCMSTB, NSP, NS2 SoC bindings")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt
index f5e518d099f2..62d4ed2d7fd7 100644
--- a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt
+++ b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt
@@ -23,8 +23,8 @@ Required properties:
- compatible:
Must be one of :
- "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-qspi" : MSPI+BSPI on BRCMSTB SoCs
- "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-mspi" : Second Instance of MSPI
+ "brcm,spi-brcmstb-qspi", "brcm,spi-bcm-qspi" : MSPI+BSPI on BRCMSTB SoCs
+ "brcm,spi-brcmstb-mspi", "brcm,spi-bcm-qspi" : Second Instance of MSPI
BRCMSTB SoCs
"brcm,spi-bcm7425-qspi", "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-mspi" : Second Instance of MSPI
BRCMSTB SoCs
@@ -36,8 +36,8 @@ Required properties:
BRCMSTB SoCs
"brcm,spi-bcm7278-qspi", "brcm,spi-bcm-qspi", "brcm,spi-brcmstb-mspi" : Second Instance of MSPI
BRCMSTB SoCs
- "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi" : MSPI+BSPI on Cygnus, NSP
- "brcm,spi-bcm-qspi", "brcm,spi-ns2-qspi" : NS2 SoCs
+ "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi" : MSPI+BSPI on Cygnus, NSP
+ "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi" : NS2 SoCs
- reg:
Define the bases and ranges of the associated I/O address spaces.
@@ -86,7 +86,7 @@ BRCMSTB SoC Example:
spi@f03e3400 {
#address-cells = <0x1>;
#size-cells = <0x0>;
- compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-brcmstb-qspi";
+ compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-bcm-qspi";
reg = <0xf03e0920 0x4 0xf03e3400 0x188 0xf03e3200 0x50>;
reg-names = "cs_reg", "mspi", "bspi";
interrupts = <0x6 0x5 0x4 0x3 0x2 0x1 0x0>;
@@ -149,7 +149,7 @@ BRCMSTB SoC Example:
#address-cells = <1>;
#size-cells = <0>;
clocks = <&upg_fixed>;
- compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-brcmstb-mspi";
+ compatible = "brcm,spi-brcmstb-mspi", "brcm,spi-bcm-qspi";
reg = <0xf0416000 0x180>;
reg-names = "mspi";
interrupts = <0x14>;
@@ -160,7 +160,7 @@ BRCMSTB SoC Example:
iProc SoC Example:
qspi: spi@18027200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x18027200 0x184>,
<0x18027000 0x124>,
<0x1811c408 0x004>,
@@ -191,7 +191,7 @@ iProc SoC Example:
NS2 SoC Example:
qspi: spi@66470200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-ns2-qspi";
+ compatible = "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi";
reg = <0x66470200 0x184>,
<0x66470000 0x124>,
<0x67017408 0x004>,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/5] ARM: dts: bcm: HR2: Fixed QSPI compatible string
2020-08-27 18:18 ` Florian Fainelli
@ 2020-08-27 18:18 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Florian Fainelli, Kamal Dasu, maintainer:BROADCOM SPI DRIVER,
Mark Brown, Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The string was incorrectly defined before from least to most specific,
swap the compatible strings accordingly.
Fixes: b9099ec754b5 ("ARM: dts: Add Broadcom Hurricane 2 DTS include file")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm-hr2.dtsi b/arch/arm/boot/dts/bcm-hr2.dtsi
index cbebed5f050e..e8df458aad39 100644
--- a/arch/arm/boot/dts/bcm-hr2.dtsi
+++ b/arch/arm/boot/dts/bcm-hr2.dtsi
@@ -217,7 +217,7 @@ rng: rng@33000 {
};
qspi: spi@27200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x027200 0x184>,
<0x027000 0x124>,
<0x11c408 0x004>,
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/5] ARM: dts: bcm: HR2: Fixed QSPI compatible string
@ 2020-08-27 18:18 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Scott Branden, Kamal Dasu, Ray Jui,
Rafał Miłecki, open list, Rob Herring,
open list:SPI SUBSYSTEM, Yendapally Reddy Dhananjaya Reddy,
Mark Brown, maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
The string was incorrectly defined before from least to most specific,
swap the compatible strings accordingly.
Fixes: b9099ec754b5 ("ARM: dts: Add Broadcom Hurricane 2 DTS include file")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm-hr2.dtsi b/arch/arm/boot/dts/bcm-hr2.dtsi
index cbebed5f050e..e8df458aad39 100644
--- a/arch/arm/boot/dts/bcm-hr2.dtsi
+++ b/arch/arm/boot/dts/bcm-hr2.dtsi
@@ -217,7 +217,7 @@ rng: rng@33000 {
};
qspi: spi@27200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x027200 0x184>,
<0x027000 0x124>,
<0x11c408 0x004>,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 3/5] ARM: dts: NSP: Fixed QSPI compatible string
2020-08-27 18:18 ` Florian Fainelli
@ 2020-08-27 18:18 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Florian Fainelli, Kamal Dasu, maintainer:BROADCOM SPI DRIVER,
Mark Brown, Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The string was incorrectly defined before from least to most
specific, swap the compatible strings accordingly.
Fixes: 329f98c1974e ("ARM: dts: NSP: Add QSPI nodes to NSPI and bcm958625k DTSes")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index 0346ea621f0f..c846fa3c244d 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -284,7 +284,7 @@ nand: nand@26000 {
};
qspi: spi@27200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x027200 0x184>,
<0x027000 0x124>,
<0x11c408 0x004>,
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 3/5] ARM: dts: NSP: Fixed QSPI compatible string
@ 2020-08-27 18:18 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Scott Branden, Kamal Dasu, Ray Jui,
Rafał Miłecki, open list, Rob Herring,
open list:SPI SUBSYSTEM, Yendapally Reddy Dhananjaya Reddy,
Mark Brown, maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
The string was incorrectly defined before from least to most
specific, swap the compatible strings accordingly.
Fixes: 329f98c1974e ("ARM: dts: NSP: Add QSPI nodes to NSPI and bcm958625k DTSes")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index 0346ea621f0f..c846fa3c244d 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -284,7 +284,7 @@ nand: nand@26000 {
};
qspi: spi@27200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x027200 0x184>,
<0x027000 0x124>,
<0x11c408 0x004>,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 4/5] ARM: dts: BCM5301X: Fixed QSPI compatible string
2020-08-27 18:18 ` Florian Fainelli
@ 2020-08-27 18:18 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Florian Fainelli, Kamal Dasu, maintainer:BROADCOM SPI DRIVER,
Mark Brown, Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The string was incorrectly defined before from least to most
specific, swap the compatible strings accordingly.
Fixes: 1c8f40650723 ("ARM: dts: BCM5301X: convert to iProc QSPI")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 2d9b4dd05830..0016720ce530 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -488,7 +488,7 @@ nand: nand@18028000 {
};
spi@18029200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x18029200 0x184>,
<0x18029000 0x124>,
<0x1811b408 0x004>,
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 4/5] ARM: dts: BCM5301X: Fixed QSPI compatible string
@ 2020-08-27 18:18 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Scott Branden, Kamal Dasu, Ray Jui,
Rafał Miłecki, open list, Rob Herring,
open list:SPI SUBSYSTEM, Yendapally Reddy Dhananjaya Reddy,
Mark Brown, maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
The string was incorrectly defined before from least to most
specific, swap the compatible strings accordingly.
Fixes: 1c8f40650723 ("ARM: dts: BCM5301X: convert to iProc QSPI")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 2d9b4dd05830..0016720ce530 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -488,7 +488,7 @@ nand: nand@18028000 {
};
spi@18029200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-nsp-qspi";
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
reg = <0x18029200 0x184>,
<0x18029000 0x124>,
<0x1811b408 0x004>,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 5/5] arm64: dts: ns2: Fixed QSPI compatible string
2020-08-27 18:18 ` Florian Fainelli
@ 2020-08-27 18:18 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Florian Fainelli, Kamal Dasu, maintainer:BROADCOM SPI DRIVER,
Mark Brown, Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The string was incorrectly defined before from least to most specific,
swap the compatible strings accordingly.
Fixes: ff73917d38a6 ("ARM64: dts: Add QSPI Device Tree node for NS2")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
index 15f7b0ed3836..39802066232e 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
@@ -745,7 +745,7 @@ nand: nand@66460000 {
};
qspi: spi@66470200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-ns2-qspi";
+ compatible = "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi";
reg = <0x66470200 0x184>,
<0x66470000 0x124>,
<0x67017408 0x004>,
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 5/5] arm64: dts: ns2: Fixed QSPI compatible string
@ 2020-08-27 18:18 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-27 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Scott Branden, Kamal Dasu, Ray Jui,
Rafał Miłecki, open list, Rob Herring,
open list:SPI SUBSYSTEM, Yendapally Reddy Dhananjaya Reddy,
Mark Brown, maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
The string was incorrectly defined before from least to most specific,
swap the compatible strings accordingly.
Fixes: ff73917d38a6 ("ARM64: dts: Add QSPI Device Tree node for NS2")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
index 15f7b0ed3836..39802066232e 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
@@ -745,7 +745,7 @@ nand: nand@66460000 {
};
qspi: spi@66470200 {
- compatible = "brcm,spi-bcm-qspi", "brcm,spi-ns2-qspi";
+ compatible = "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi";
reg = <0x66470200 0x184>,
<0x66470000 0x124>,
<0x67017408 0x004>,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
2020-08-27 18:18 ` Florian Fainelli
@ 2020-08-27 19:30 ` Scott Branden
-1 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2020-08-27 19:30 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel
Cc: Kamal Dasu, maintainer:BROADCOM SPI DRIVER, Mark Brown,
Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Patch series looks good.
Acked-by: Scott Branden <scott.branden@broadcom.com>
On 2020-08-27 11:18 a.m., Florian Fainelli wrote:
> Hi all,
>
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
>
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.
>
> Florian Fainelli (5):
> dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
> ARM: dts: bcm: HR2: Fixed QSPI compatible string
> ARM: dts: NSP: Fixed QSPI compatible string
> ARM: dts: BCM5301X: Fixed QSPI compatible string
> arm64: dts: ns2: Fixed QSPI compatible string
>
> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
> arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
> arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
@ 2020-08-27 19:30 ` Scott Branden
0 siblings, 0 replies; 24+ messages in thread
From: Scott Branden @ 2020-08-27 19:30 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Scott Branden, Kamal Dasu, Ray Jui, Rafał Miłecki,
open list, Rob Herring, open list:SPI SUBSYSTEM,
Yendapally Reddy Dhananjaya Reddy, Mark Brown,
maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
Patch series looks good.
Acked-by: Scott Branden <scott.branden@broadcom.com>
On 2020-08-27 11:18 a.m., Florian Fainelli wrote:
> Hi all,
>
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
>
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.
>
> Florian Fainelli (5):
> dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
> ARM: dts: bcm: HR2: Fixed QSPI compatible string
> ARM: dts: NSP: Fixed QSPI compatible string
> ARM: dts: BCM5301X: Fixed QSPI compatible string
> arm64: dts: ns2: Fixed QSPI compatible string
>
> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
> arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
> arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
2020-08-27 19:30 ` Scott Branden
@ 2020-08-28 15:27 ` Kamal Dasu
-1 siblings, 0 replies; 24+ messages in thread
From: Kamal Dasu @ 2020-08-28 15:27 UTC (permalink / raw)
To: Scott Branden
Cc: Florian Fainelli, linux-arm-kernel,
maintainer:BROADCOM SPI DRIVER, Mark Brown, Rob Herring, Ray Jui,
Scott Branden, Hauke Mehrtens, Rafał Miłecki,
Yendapally Reddy Dhananjaya Reddy, open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Looks good to me.
Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
On Thu, Aug 27, 2020 at 3:30 PM Scott Branden
<scott.branden@broadcom.com> wrote:
>
> Patch series looks good.
>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
>
> On 2020-08-27 11:18 a.m., Florian Fainelli wrote:
> > Hi all,
> >
> > This patch series fixes incorrectly defined compatible strings for the
> > Broadcom QSPI controller which resulted in the strings not being
> > ordered from most to least compatible.
> >
> > We will need to apply some changes to the spi-bcm-qspi.c driver in
> > the future to assume no revision register exist, and these patches
> > are a preliminary step towards that goal.
> >
> > Florian Fainelli (5):
> > dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
> > ARM: dts: bcm: HR2: Fixed QSPI compatible string
> > ARM: dts: NSP: Fixed QSPI compatible string
> > ARM: dts: BCM5301X: Fixed QSPI compatible string
> > arm64: dts: ns2: Fixed QSPI compatible string
> >
> > .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> > arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
> > arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
> > arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
> > arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
> > 5 files changed, 12 insertions(+), 12 deletions(-)
> >
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
@ 2020-08-28 15:27 ` Kamal Dasu
0 siblings, 0 replies; 24+ messages in thread
From: Kamal Dasu @ 2020-08-28 15:27 UTC (permalink / raw)
To: Scott Branden
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Scott Branden, Ray Jui, Mark Brown,
Rafał Miłecki, open list, open list:SPI SUBSYSTEM,
Yendapally Reddy Dhananjaya Reddy, Rob Herring,
maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens, linux-arm-kernel
Looks good to me.
Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
On Thu, Aug 27, 2020 at 3:30 PM Scott Branden
<scott.branden@broadcom.com> wrote:
>
> Patch series looks good.
>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
>
> On 2020-08-27 11:18 a.m., Florian Fainelli wrote:
> > Hi all,
> >
> > This patch series fixes incorrectly defined compatible strings for the
> > Broadcom QSPI controller which resulted in the strings not being
> > ordered from most to least compatible.
> >
> > We will need to apply some changes to the spi-bcm-qspi.c driver in
> > the future to assume no revision register exist, and these patches
> > are a preliminary step towards that goal.
> >
> > Florian Fainelli (5):
> > dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
> > ARM: dts: bcm: HR2: Fixed QSPI compatible string
> > ARM: dts: NSP: Fixed QSPI compatible string
> > ARM: dts: BCM5301X: Fixed QSPI compatible string
> > arm64: dts: ns2: Fixed QSPI compatible string
> >
> > .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> > arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
> > arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
> > arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
> > arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
> > 5 files changed, 12 insertions(+), 12 deletions(-)
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
2020-08-27 18:18 ` Florian Fainelli
@ 2020-08-31 18:37 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-31 18:37 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel, Rob Herring
Cc: Kamal Dasu, maintainer:BROADCOM SPI DRIVER, Mark Brown, Ray Jui,
Scott Branden, Hauke Mehrtens, Rafał Miłecki,
Yendapally Reddy Dhananjaya Reddy, open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 8/27/2020 11:18 AM, Florian Fainelli wrote:
> Hi all,
>
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
>
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.
Rob, can I get your tag for this patch series so it can be sent out? Thanks!
>
> Florian Fainelli (5):
> dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
> ARM: dts: bcm: HR2: Fixed QSPI compatible string
> ARM: dts: NSP: Fixed QSPI compatible string
> ARM: dts: BCM5301X: Fixed QSPI compatible string
> arm64: dts: ns2: Fixed QSPI compatible string
>
> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
> arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
> arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
--
Florian
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
@ 2020-08-31 18:37 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-08-31 18:37 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel, Rob Herring
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Scott Branden, Kamal Dasu, Ray Jui, Rafał Miłecki,
open list, open list:SPI SUBSYSTEM,
Yendapally Reddy Dhananjaya Reddy, Mark Brown,
maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
On 8/27/2020 11:18 AM, Florian Fainelli wrote:
> Hi all,
>
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
>
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.
Rob, can I get your tag for this patch series so it can be sent out? Thanks!
>
> Florian Fainelli (5):
> dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
> ARM: dts: bcm: HR2: Fixed QSPI compatible string
> ARM: dts: NSP: Fixed QSPI compatible string
> ARM: dts: BCM5301X: Fixed QSPI compatible string
> arm64: dts: ns2: Fixed QSPI compatible string
>
> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
> arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
> arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
2020-08-27 18:18 ` Florian Fainelli
@ 2020-09-09 20:41 ` Rob Herring
-1 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2020-09-09 20:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: Kamal Dasu, Yendapally Reddy Dhananjaya Reddy,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:SPI SUBSYSTEM, maintainer:BROADCOM SPI DRIVER,
linux-arm-kernel, Rafał Miłecki, open list,
Rob Herring, Mark Brown, Hauke Mehrtens, Ray Jui, Scott Branden
On Thu, 27 Aug 2020 11:18:38 -0700, Florian Fainelli wrote:
> The binding is currently incorrectly defining the compatible strings
> from least specific to most specific instead of the converse. Re-order
> them from most specific (left) to least specific (right) and fix the
> examples as well.
>
> Fixes: 5fc78f4c842a ("spi: Broadcom BRCMSTB, NSP, NS2 SoC bindings")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
@ 2020-09-09 20:41 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2020-09-09 20:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Scott Branden, Kamal Dasu, Hauke Mehrtens, Mark Brown,
Rafał Miłecki, open list, open list:SPI SUBSYSTEM,
Yendapally Reddy Dhananjaya Reddy, Rob Herring,
maintainer:BROADCOM SPI DRIVER, Ray Jui, linux-arm-kernel
On Thu, 27 Aug 2020 11:18:38 -0700, Florian Fainelli wrote:
> The binding is currently incorrectly defining the compatible strings
> from least specific to most specific instead of the converse. Re-order
> them from most specific (left) to least specific (right) and fix the
> examples as well.
>
> Fixes: 5fc78f4c842a ("spi: Broadcom BRCMSTB, NSP, NS2 SoC bindings")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
2020-09-09 20:41 ` Rob Herring
@ 2020-09-09 21:02 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-09-09 21:02 UTC (permalink / raw)
To: Rob Herring
Cc: Kamal Dasu, Yendapally Reddy Dhananjaya Reddy,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:SPI SUBSYSTEM, maintainer:BROADCOM SPI DRIVER,
linux-arm-kernel, Rafał Miłecki, open list,
Rob Herring, Mark Brown, Hauke Mehrtens, Ray Jui, Scott Branden
On 9/9/2020 1:41 PM, Rob Herring wrote:
> On Thu, 27 Aug 2020 11:18:38 -0700, Florian Fainelli wrote:
>> The binding is currently incorrectly defining the compatible strings
>> from least specific to most specific instead of the converse. Re-order
>> them from most specific (left) to least specific (right) and fix the
>> examples as well.
>>
>> Fixes: 5fc78f4c842a ("spi: Broadcom BRCMSTB, NSP, NS2 SoC bindings")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Thanks, and sorry about the nagging on IRC :)
--
Florian
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
@ 2020-09-09 21:02 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-09-09 21:02 UTC (permalink / raw)
To: Rob Herring
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Scott Branden, Kamal Dasu, Hauke Mehrtens, Mark Brown,
Rafał Miłecki, open list, open list:SPI SUBSYSTEM,
Yendapally Reddy Dhananjaya Reddy, Rob Herring,
maintainer:BROADCOM SPI DRIVER, Ray Jui, linux-arm-kernel
On 9/9/2020 1:41 PM, Rob Herring wrote:
> On Thu, 27 Aug 2020 11:18:38 -0700, Florian Fainelli wrote:
>> The binding is currently incorrectly defining the compatible strings
>> from least specific to most specific instead of the converse. Re-order
>> them from most specific (left) to least specific (right) and fix the
>> examples as well.
>>
>> Fixes: 5fc78f4c842a ("spi: Broadcom BRCMSTB, NSP, NS2 SoC bindings")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Thanks, and sorry about the nagging on IRC :)
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
2020-08-27 18:18 ` Florian Fainelli
@ 2020-09-09 21:14 ` Florian Fainelli
-1 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-09-09 21:14 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel
Cc: Kamal Dasu, maintainer:BROADCOM SPI DRIVER, Mark Brown,
Rob Herring, Ray Jui, Scott Branden, Hauke Mehrtens,
Rafał Miłecki, Yendapally Reddy Dhananjaya Reddy,
open list:SPI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 8/27/2020 11:18 AM, Florian Fainelli wrote:
> Hi all,
>
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
>
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.
Series applied to devicetree/fixes, sending the PR shortly.
--
Florian
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/5] qspi binding and DTS fixes
@ 2020-09-09 21:14 ` Florian Fainelli
0 siblings, 0 replies; 24+ messages in thread
From: Florian Fainelli @ 2020-09-09 21:14 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Scott Branden, Kamal Dasu, Ray Jui, Rafał Miłecki,
open list, Rob Herring, open list:SPI SUBSYSTEM,
Yendapally Reddy Dhananjaya Reddy, Mark Brown,
maintainer:BROADCOM SPI DRIVER, Hauke Mehrtens
On 8/27/2020 11:18 AM, Florian Fainelli wrote:
> Hi all,
>
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
>
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.
Series applied to devicetree/fixes, sending the PR shortly.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2020-09-09 21:16 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 18:18 [PATCH 0/5] qspi binding and DTS fixes Florian Fainelli
2020-08-27 18:18 ` Florian Fainelli
2020-08-27 18:18 ` [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering Florian Fainelli
2020-08-27 18:18 ` Florian Fainelli
2020-09-09 20:41 ` Rob Herring
2020-09-09 20:41 ` Rob Herring
2020-09-09 21:02 ` Florian Fainelli
2020-09-09 21:02 ` Florian Fainelli
2020-08-27 18:18 ` [PATCH 2/5] ARM: dts: bcm: HR2: Fixed QSPI compatible string Florian Fainelli
2020-08-27 18:18 ` Florian Fainelli
2020-08-27 18:18 ` [PATCH 3/5] ARM: dts: NSP: " Florian Fainelli
2020-08-27 18:18 ` Florian Fainelli
2020-08-27 18:18 ` [PATCH 4/5] ARM: dts: BCM5301X: " Florian Fainelli
2020-08-27 18:18 ` Florian Fainelli
2020-08-27 18:18 ` [PATCH 5/5] arm64: dts: ns2: " Florian Fainelli
2020-08-27 18:18 ` Florian Fainelli
2020-08-27 19:30 ` [PATCH 0/5] qspi binding and DTS fixes Scott Branden
2020-08-27 19:30 ` Scott Branden
2020-08-28 15:27 ` Kamal Dasu
2020-08-28 15:27 ` Kamal Dasu
2020-08-31 18:37 ` Florian Fainelli
2020-08-31 18:37 ` Florian Fainelli
2020-09-09 21:14 ` Florian Fainelli
2020-09-09 21:14 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.