All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
@ 2020-08-14  9:56 Diego Sueiro
  2020-08-14  9:56 ` Diego Sueiro
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Diego Sueiro @ 2020-08-14  9:56 UTC (permalink / raw)
  To: meta-virtualization; +Cc: christopher.w.clark, cardoe, Diego Sueiro

Changes in v2:
    - Fixed typo in recipes-extended/xen/README
    - Removed documentation changes from 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
    - Updated Upstream-Status in 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
    - Call find_cfgs function only once in recipes-extended/xen/xen-hypervisor.inc

Diego Sueiro (1):
  xen: Fix menuconfig and add support for config fragments and
    diffconfig

 recipes-extended/xen/README                        |  3 ++
 ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
 recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
 recipes-extended/xen/xen_4.14.bb                   |  1 +
 recipes-extended/xen/xen_git.bb                    |  1 +
 5 files changed, 73 insertions(+), 30 deletions(-)
 create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch

--
2.7.4

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
  2020-08-14  9:56 [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig Diego Sueiro
@ 2020-08-14  9:56 ` Diego Sueiro
  2020-08-17  1:34 ` Bruce Ashfield
  2020-08-27 20:30 ` Bruce Ashfield
  2 siblings, 0 replies; 8+ messages in thread
From: Diego Sueiro @ 2020-08-14  9:56 UTC (permalink / raw)
  To: meta-virtualization; +Cc: christopher.w.clark, cardoe, Diego Sueiro

This patch introduces the following changes:

1. When building in OE environment the linker path needs to be passed when
   buildind the Kconfig tool in order to get the menuconfig task properly
   working.

2. By inheriting cml1.bbclass we can drop some environment variables
   settings in xen-hypervisor.inc for the menuconfig task, and also be
   able to search for config fragmens and use the diffconfig task. Also,
   there is no need to have a custom do_menuconfig task anymore.

Change-Id: I8d61ec76d92de7d1613b79edf55b4868fe712334
Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
 recipes-extended/xen/README                        |  3 ++
 ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
 recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
 recipes-extended/xen/xen_4.14.bb                   |  1 +
 recipes-extended/xen/xen_git.bb                    |  1 +
 5 files changed, 73 insertions(+), 30 deletions(-)
 create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch

diff --git a/recipes-extended/xen/README b/recipes-extended/xen/README
index 34e7977..f286bb5 100644
--- a/recipes-extended/xen/README
+++ b/recipes-extended/xen/README
@@ -25,6 +25,9 @@ Select the config settings that you want and Save the file. If you save it to
 the default ".config" file when prompted by menuconfig, you can find it in the
 'xen' subdirectory of the build tree.

+Configuration fragments are also supported. To use them you need to list the
+.cfg files in the SRC_URI.
+
 security patches
 ----------------

diff --git a/recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch b/recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
new file mode 100644
index 0000000..49999c8
--- /dev/null
+++ b/recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
@@ -0,0 +1,49 @@
+Upstream-Status: Xen: Inappropriate [oe specific, cross compile issue]
+Upstream-Status: Kernel: Pending
+Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
+commit e6972e689a980ab28637e94e48c77eeace6abde5
+Author: Bruce Ashfield <bruce.ashfield@windriver.com>
+Date:   Mon Jul 2 23:10:28 2018 -0400
+
+    xen/kconfig,menuconfig,mconf-cfg: Allow specification of ncurses location
+
+    In some cross build environments such as the Yocto Project build
+    environment it provides an ncurses library that is compiled
+    differently than the host's version.  This causes display corruption
+    problems when the host's curses includes are used instead of the
+    includes from the provided compiler are overridden.  There is a second
+    case where there is no curses libraries at all on the host system and
+    menuconfig will just fail entirely.
+
+    The solution is simply to allow an override variable in
+    check-lxdialog.sh for environments such as the Yocto Project.  Adding
+    a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing
+    compiling and linking against the right headers and libraries.
+
+    Change-Id: Ibe8dfafc90655e3be2671dbbb0cb7f5631fc4d44
+    Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
+    cc: Michal Marek <mmarek@suse.cz>
+    cc: linux-kbuild@vger.kernel.org
+    Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
+
+diff --git a/xen/tools/kconfig/mconf-cfg.sh b/xen/tools/kconfig/mconf-cfg.sh
+old mode 100755
+new mode 100644
+index c812872..65a9b9e
+--- a/xen/tools/kconfig/mconf-cfg.sh
++++ b/xen/tools/kconfig/mconf-cfg.sh
+@@ -4,6 +4,14 @@
+ PKG="ncursesw"
+ PKG2="ncurses"
+
++if [ "$CROSS_CURSES_LIB" != "" ]; then
++    echo libs=\'$CROSS_CURSES_LIB\'
++    if [ x"$CROSS_CURSES_INC" != x ]; then
++      echo cflags=\'$CROSS_CURSES_INC\'
++    fi
++    exit 0
++fi
++
+ if [ -n "$(command -v pkg-config)" ]; then
+       if pkg-config --exists $PKG; then
+               echo cflags=\"$(pkg-config --cflags $PKG)\"
diff --git a/recipes-extended/xen/xen-hypervisor.inc b/recipes-extended/xen/xen-hypervisor.inc
index c386917..3bfee8e 100644
--- a/recipes-extended/xen/xen-hypervisor.inc
+++ b/recipes-extended/xen/xen-hypervisor.inc
@@ -9,7 +9,7 @@ DESCRIPTION = "The Xen hypervisor"
 # The Xen hypervisor has a narrower compatible platform range than the Xen tools
 COMPATIBLE_HOST = '(x86_64.*).*-linux|aarch64.*-linux|arm-.*-linux-gnueabi'

-inherit deploy python3native
+inherit deploy python3native cml1

 PACKAGES = " \
     ${PN} \
@@ -34,6 +34,18 @@ FILES_${PN}-efi = " \

 do_configure() {
     do_configure_common
+
+    # Handle the config fragments
+    cfgs="${@' '.join(find_cfgs(d))}"
+    if [ -n "${cfgs}" ]; then
+        # If .config is not present generate one in order
+        # to use the merge_config.sh
+        if [ ! -f "${S}/xen/.config" ] ; then
+            oe_runmake -C ${S}/xen defconfig
+        fi
+        ${S}/xen/tools/kconfig/merge_config.sh -m -O \
+            ${S}/xen ${S}/xen/.config "${cfgs}"
+    fi
 }

 do_compile() {
@@ -77,35 +89,12 @@ do_deploy[depends] += "xen-tools:do_populate_sysroot"
 do_deploy[depends] += "xen-tools:do_deploy"

 # Enable use of menuconfig directly from bitbake and also within the devshell
-OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOSTLDFLAGS TERMINFO"
-HOST_EXTRACFLAGS = "${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
-HOSTLDFLAGS = "${BUILD_LDFLAGS}"
-TERMINFO = "${STAGING_DATADIR_NATIVE}/terminfo"
 do_devshell[depends] += "ncurses-native:do_populate_sysroot"

-KCONFIG_CONFIG_COMMAND ??= "menuconfig"
-python do_menuconfig() {
-    import shutil
-
-    try:
-        mtime = os.path.getmtime("xen/.config")
-        shutil.copy("xen/.config", "xen/.config.orig")
-    except OSError:
-        mtime = 0
+# Pass the native library path for kconfig build when running the do_menuconfig
+# task
+CROSS_CURSES_LIB += "-L${STAGING_LIBDIR_NATIVE}"

-    oe_terminal("${SHELL} -c \"cd xen; XEN_CONFIG_EXPERT=y make %s; if [ \$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'),
-        d.getVar('PN') + ' Configuration', d)
-
-    try:
-        newmtime = os.path.getmtime("xen/.config")
-    except OSError:
-        newmtime = 0
-
-    if newmtime > mtime:
-        bb.note("Configuration changed, recompile will be forced")
-        bb.build.write_taint('do_compile', d)
-}
-do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"
-do_menuconfig[nostamp] = "1"
-do_menuconfig[dirs] = "${B}"
-addtask menuconfig after do_configure
+# Specify the root dir of the .config file for do_menuconfig and do_diffconfig
+# tasks
+KCONFIG_CONFIG_ROOTDIR = "${S}/xen"
diff --git a/recipes-extended/xen/xen_4.14.bb b/recipes-extended/xen/xen_4.14.bb
index 0413bee..91e8988 100644
--- a/recipes-extended/xen/xen_4.14.bb
+++ b/recipes-extended/xen/xen_4.14.bb
@@ -6,6 +6,7 @@ XEN_BRANCH ?= "stable-${XEN_REL}"
 SRC_URI = " \
     git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
     file://xen-arm64-implement-atomic-fetch-add.patch \
+    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
     "

 LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
diff --git a/recipes-extended/xen/xen_git.bb b/recipes-extended/xen/xen_git.bb
index 408bc3b..57791fc 100644
--- a/recipes-extended/xen/xen_git.bb
+++ b/recipes-extended/xen/xen_git.bb
@@ -6,6 +6,7 @@ XEN_BRANCH ?= "master"
 SRC_URI = " \
     git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
     file://xen-arm64-implement-atomic-fetch-add.patch \
+    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
     "

 LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
--
2.7.4

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
  2020-08-14  9:56 [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig Diego Sueiro
  2020-08-14  9:56 ` Diego Sueiro
@ 2020-08-17  1:34 ` Bruce Ashfield
  2020-08-17  7:55   ` Bertrand Marquis
       [not found]   ` <162BFF110C03FC4E.19371@lists.yoctoproject.org>
  2020-08-27 20:30 ` Bruce Ashfield
  2 siblings, 2 replies; 8+ messages in thread
From: Bruce Ashfield @ 2020-08-17  1:34 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-virtualization, christopher.w.clark, cardoe

In message: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
on 14/08/2020 Diego Sueiro wrote:

> Changes in v2:
>     - Fixed typo in recipes-extended/xen/README
>     - Removed documentation changes from 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>     - Updated Upstream-Status in 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>     - Call find_cfgs function only once in recipes-extended/xen/xen-hypervisor.inc


v2 looks good to me.

Christopher, do you agree ?

Bruce

> 
> Diego Sueiro (1):
>   xen: Fix menuconfig and add support for config fragments and
>     diffconfig
> 
>  recipes-extended/xen/README                        |  3 ++
>  ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
>  recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
>  recipes-extended/xen/xen_4.14.bb                   |  1 +
>  recipes-extended/xen/xen_git.bb                    |  1 +
>  5 files changed, 73 insertions(+), 30 deletions(-)
>  create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
> 
> --
> 2.7.4
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
  2020-08-17  1:34 ` Bruce Ashfield
@ 2020-08-17  7:55   ` Bertrand Marquis
       [not found]   ` <162BFF110C03FC4E.19371@lists.yoctoproject.org>
  1 sibling, 0 replies; 8+ messages in thread
From: Bertrand Marquis @ 2020-08-17  7:55 UTC (permalink / raw)
  To: Bruce Ashfield
  Cc: Diego Sueiro, meta-virtualization, Christopher Clark, Doug Goldstein, nd



> On 17 Aug 2020, at 02:34, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
> 
> In message: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
> on 14/08/2020 Diego Sueiro wrote:
> 
>> Changes in v2:
>>    - Fixed typo in recipes-extended/xen/README
>>    - Removed documentation changes from 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>    - Updated Upstream-Status in 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>    - Call find_cfgs function only once in recipes-extended/xen/xen-hypervisor.inc
> 
> 
> v2 looks good to me.
> 
> Christopher, do you agree ?

I tested it and it worked for me, including modifying the xen configuration.

So you can add my:

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

> 
> Bruce
> 
>> 
>> Diego Sueiro (1):
>>  xen: Fix menuconfig and add support for config fragments and
>>    diffconfig
>> 
>> recipes-extended/xen/README                        |  3 ++
>> ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
>> recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
>> recipes-extended/xen/xen_4.14.bb                   |  1 +
>> recipes-extended/xen/xen_git.bb                    |  1 +
>> 5 files changed, 73 insertions(+), 30 deletions(-)
>> create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>> 
>> --
>> 2.7.4
>> 
>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> 
>> 
> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
       [not found]   ` <162BFF110C03FC4E.19371@lists.yoctoproject.org>
@ 2020-08-27 14:10     ` Bertrand Marquis
  2020-08-27 14:39       ` Bruce Ashfield
  0 siblings, 1 reply; 8+ messages in thread
From: Bertrand Marquis @ 2020-08-27 14:10 UTC (permalink / raw)
  To: Bruce Ashfield
  Cc: Diego Sueiro, meta-virtualization, Christopher Clark, Doug Goldstein, nd

Gentle ping :-)

Bertrand

> On 17 Aug 2020, at 08:55, Bertrand Marquis via lists.yoctoproject.org <bertrand.marquis=arm.com@lists.yoctoproject.org> wrote:
> 
> 
> 
>> On 17 Aug 2020, at 02:34, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>> 
>> In message: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
>> on 14/08/2020 Diego Sueiro wrote:
>> 
>>> Changes in v2:
>>>   - Fixed typo in recipes-extended/xen/README
>>>   - Removed documentation changes from 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>>   - Updated Upstream-Status in 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>>   - Call find_cfgs function only once in recipes-extended/xen/xen-hypervisor.inc
>> 
>> 
>> v2 looks good to me.
>> 
>> Christopher, do you agree ?
> 
> I tested it and it worked for me, including modifying the xen configuration.
> 
> So you can add my:
> 
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> 
>> 
>> Bruce
>> 
>>> 
>>> Diego Sueiro (1):
>>> xen: Fix menuconfig and add support for config fragments and
>>>   diffconfig
>>> 
>>> recipes-extended/xen/README                        |  3 ++
>>> ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
>>> recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
>>> recipes-extended/xen/xen_4.14.bb                   |  1 +
>>> recipes-extended/xen/xen_git.bb                    |  1 +
>>> 5 files changed, 73 insertions(+), 30 deletions(-)
>>> create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>> 
>>> --
>>> 2.7.4
>>> 
>>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>> 
>>> 
>> 
>> 
> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
  2020-08-27 14:10     ` Bertrand Marquis
@ 2020-08-27 14:39       ` Bruce Ashfield
  2020-08-27 14:43         ` Bertrand Marquis
  0 siblings, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2020-08-27 14:39 UTC (permalink / raw)
  To: Bertrand Marquis
  Cc: Diego Sueiro, meta-virtualization, Christopher Clark, Doug Goldstein, nd

I was waiting on something from Christopher on this, but as it turns
out .. I was going to do a merge of the pending queue now that some
oe-core work is done.

So your timing is good. It should be in the tree by EOD.

Bruce

On Thu, Aug 27, 2020 at 10:10 AM Bertrand Marquis
<bertrand.marquis@arm.com> wrote:
>
> Gentle ping :-)
>
> Bertrand
>
> > On 17 Aug 2020, at 08:55, Bertrand Marquis via lists.yoctoproject.org <bertrand.marquis=arm.com@lists.yoctoproject.org> wrote:
> >
> >
> >
> >> On 17 Aug 2020, at 02:34, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
> >>
> >> In message: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
> >> on 14/08/2020 Diego Sueiro wrote:
> >>
> >>> Changes in v2:
> >>>   - Fixed typo in recipes-extended/xen/README
> >>>   - Removed documentation changes from 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
> >>>   - Updated Upstream-Status in 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
> >>>   - Call find_cfgs function only once in recipes-extended/xen/xen-hypervisor.inc
> >>
> >>
> >> v2 looks good to me.
> >>
> >> Christopher, do you agree ?
> >
> > I tested it and it worked for me, including modifying the xen configuration.
> >
> > So you can add my:
> >
> > Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> >
> >>
> >> Bruce
> >>
> >>>
> >>> Diego Sueiro (1):
> >>> xen: Fix menuconfig and add support for config fragments and
> >>>   diffconfig
> >>>
> >>> recipes-extended/xen/README                        |  3 ++
> >>> ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
> >>> recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
> >>> recipes-extended/xen/xen_4.14.bb                   |  1 +
> >>> recipes-extended/xen/xen_git.bb                    |  1 +
> >>> 5 files changed, 73 insertions(+), 30 deletions(-)
> >>> create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
> >>>
> >>> --
> >>> 2.7.4
> >>>
> >>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> >>
> >>>
> >>
> >>
> >
> >
>
> 



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
  2020-08-27 14:39       ` Bruce Ashfield
@ 2020-08-27 14:43         ` Bertrand Marquis
  0 siblings, 0 replies; 8+ messages in thread
From: Bertrand Marquis @ 2020-08-27 14:43 UTC (permalink / raw)
  To: Bruce Ashfield
  Cc: Diego Sueiro, meta-virtualization, Christopher Clark, Doug Goldstein, nd



> On 27 Aug 2020, at 15:39, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
> 
> I was waiting on something from Christopher on this, but as it turns
> out .. I was going to do a merge of the pending queue now that some
> oe-core work is done.
> 
> So your timing is good. It should be in the tree by EOD.
> 

I have a recurrent task to check for pending pushes on different mailing lists ;-)

Perfect thanks a lot :-)

Bertrand

> Bruce
> 
> On Thu, Aug 27, 2020 at 10:10 AM Bertrand Marquis
> <bertrand.marquis@arm.com> wrote:
>> 
>> Gentle ping :-)
>> 
>> Bertrand
>> 
>>> On 17 Aug 2020, at 08:55, Bertrand Marquis via lists.yoctoproject.org <bertrand.marquis=arm.com@lists.yoctoproject.org> wrote:
>>> 
>>> 
>>> 
>>>> On 17 Aug 2020, at 02:34, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>>>> 
>>>> In message: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
>>>> on 14/08/2020 Diego Sueiro wrote:
>>>> 
>>>>> Changes in v2:
>>>>>  - Fixed typo in recipes-extended/xen/README
>>>>>  - Removed documentation changes from 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>>>>  - Updated Upstream-Status in 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>>>>  - Call find_cfgs function only once in recipes-extended/xen/xen-hypervisor.inc
>>>> 
>>>> 
>>>> v2 looks good to me.
>>>> 
>>>> Christopher, do you agree ?
>>> 
>>> I tested it and it worked for me, including modifying the xen configuration.
>>> 
>>> So you can add my:
>>> 
>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>> 
>>>> 
>>>> Bruce
>>>> 
>>>>> 
>>>>> Diego Sueiro (1):
>>>>> xen: Fix menuconfig and add support for config fragments and
>>>>>  diffconfig
>>>>> 
>>>>> recipes-extended/xen/README                        |  3 ++
>>>>> ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
>>>>> recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
>>>>> recipes-extended/xen/xen_4.14.bb                   |  1 +
>>>>> recipes-extended/xen/xen_git.bb                    |  1 +
>>>>> 5 files changed, 73 insertions(+), 30 deletions(-)
>>>>> create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>>>>> 
>>>>> --
>>>>> 2.7.4
>>>>> 
>>>>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>>>> 
>>>>> 
>>>> 
>>>> 
>>> 
>>> 
>> 
>> 
> 
> 
> 
> -- 
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
  2020-08-14  9:56 [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig Diego Sueiro
  2020-08-14  9:56 ` Diego Sueiro
  2020-08-17  1:34 ` Bruce Ashfield
@ 2020-08-27 20:30 ` Bruce Ashfield
  2 siblings, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2020-08-27 20:30 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-virtualization, christopher.w.clark, cardoe

v2 is merged (which is now a 1 patch series, versus the original 2
patch series).

If I've got that wrong, let me know!

Bruce


In message: [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig
on 14/08/2020 Diego Sueiro wrote:

> Changes in v2:
>     - Fixed typo in recipes-extended/xen/README
>     - Removed documentation changes from 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>     - Updated Upstream-Status in 0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
>     - Call find_cfgs function only once in recipes-extended/xen/xen-hypervisor.inc
> 
> Diego Sueiro (1):
>   xen: Fix menuconfig and add support for config fragments and
>     diffconfig
> 
>  recipes-extended/xen/README                        |  3 ++
>  ...g-Allow-specification-of-ncurses-location.patch | 49 ++++++++++++++++++++++
>  recipes-extended/xen/xen-hypervisor.inc            | 49 +++++++++-------------
>  recipes-extended/xen/xen_4.14.bb                   |  1 +
>  recipes-extended/xen/xen_git.bb                    |  1 +
>  5 files changed, 73 insertions(+), 30 deletions(-)
>  create mode 100644 recipes-extended/xen/files/0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch
> 
> --
> 2.7.4
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-08-27 20:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14  9:56 [meta-virtualization][PATCH v2] xen: Fix menuconfig and add support for config fragments and diffconfig Diego Sueiro
2020-08-14  9:56 ` Diego Sueiro
2020-08-17  1:34 ` Bruce Ashfield
2020-08-17  7:55   ` Bertrand Marquis
     [not found]   ` <162BFF110C03FC4E.19371@lists.yoctoproject.org>
2020-08-27 14:10     ` Bertrand Marquis
2020-08-27 14:39       ` Bruce Ashfield
2020-08-27 14:43         ` Bertrand Marquis
2020-08-27 20:30 ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.