From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Vinod Koul <vkoul@kernel.org> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@siol.net> Subject: Re: [PATCH v1 2/2] drm: bridge: add support for lontium LT9611UXC bridge Date: Fri, 28 Aug 2020 17:33:00 +0300 [thread overview] Message-ID: <20200828143300.GA6310@pendragon.ideasonboard.com> (raw) In-Reply-To: <20200828141848.GX2639@vkoul-mobl> On Fri, Aug 28, 2020 at 07:48:48PM +0530, Vinod Koul wrote: > On 28-08-20, 15:04, Dmitry Baryshkov wrote: > > > +#define EDID_BLOCK_SIZE 128 > > +#define EDID_NUM_BLOCKS 2 > > tab or space either one, not both ;) > > > +static struct mipi_dsi_device *lt9611uxc_attach_dsi(struct lt9611uxc *lt9611uxc, > > + struct device_node *dsi_node) > > Please align this with open parenthesis of preceding line (checkpatch > with --strict option will check this) > > > +static int lt9611uxc_bridge_attach(struct drm_bridge *bridge, > > + enum drm_bridge_attach_flags flags) > > +{ > > + struct lt9611uxc *lt9611uxc = bridge_to_lt9611uxc(bridge); > > + int ret; > > + > > + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { > > + dev_err(lt9611uxc->dev, "Fix bridge driver to make connector optional!"); > > Can we support both modes as I have done in lt9611, that way once the > conversion is done we can drop the init part and support conversion. I was going to mention that :-) New drivers should support the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. > I have patch for msm driver to set DRM_BRIDGE_ATTACH_NO_CONNECTOR, you > can use that to test > > > +static int lt9611uxc_hdmi_hw_params(struct device *dev, void *data, > > + struct hdmi_codec_daifmt *fmt, > > + struct hdmi_codec_params *hparms) > > +{ > > + /* > > + * LT9611UXC will automatically detect rate and sample size, so no need > > + * to setup anything here. > > + */ > > + return 0; > > +} > > Do we need dummy function? -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Vinod Koul <vkoul@kernel.org> Cc: devicetree@vger.kernel.org, Jernej Skrabec <jernej.skrabec@siol.net>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>, dri-devel@lists.freedesktop.org, Andrzej Hajda <a.hajda@samsung.com>, Rob Herring <robh+dt@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Subject: Re: [PATCH v1 2/2] drm: bridge: add support for lontium LT9611UXC bridge Date: Fri, 28 Aug 2020 17:33:00 +0300 [thread overview] Message-ID: <20200828143300.GA6310@pendragon.ideasonboard.com> (raw) In-Reply-To: <20200828141848.GX2639@vkoul-mobl> On Fri, Aug 28, 2020 at 07:48:48PM +0530, Vinod Koul wrote: > On 28-08-20, 15:04, Dmitry Baryshkov wrote: > > > +#define EDID_BLOCK_SIZE 128 > > +#define EDID_NUM_BLOCKS 2 > > tab or space either one, not both ;) > > > +static struct mipi_dsi_device *lt9611uxc_attach_dsi(struct lt9611uxc *lt9611uxc, > > + struct device_node *dsi_node) > > Please align this with open parenthesis of preceding line (checkpatch > with --strict option will check this) > > > +static int lt9611uxc_bridge_attach(struct drm_bridge *bridge, > > + enum drm_bridge_attach_flags flags) > > +{ > > + struct lt9611uxc *lt9611uxc = bridge_to_lt9611uxc(bridge); > > + int ret; > > + > > + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { > > + dev_err(lt9611uxc->dev, "Fix bridge driver to make connector optional!"); > > Can we support both modes as I have done in lt9611, that way once the > conversion is done we can drop the init part and support conversion. I was going to mention that :-) New drivers should support the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. > I have patch for msm driver to set DRM_BRIDGE_ATTACH_NO_CONNECTOR, you > can use that to test > > > +static int lt9611uxc_hdmi_hw_params(struct device *dev, void *data, > > + struct hdmi_codec_daifmt *fmt, > > + struct hdmi_codec_params *hparms) > > +{ > > + /* > > + * LT9611UXC will automatically detect rate and sample size, so no need > > + * to setup anything here. > > + */ > > + return 0; > > +} > > Do we need dummy function? -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-28 14:33 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-28 12:04 [PATCH v1 0/2] Add LT9611UXC DSI to HDMI bridge support Dmitry Baryshkov 2020-08-28 12:04 ` Dmitry Baryshkov 2020-08-28 12:04 ` [PATCH v1 1/2] dt-bindings: display: bridge: Add documentation for LT9611UXC Dmitry Baryshkov 2020-08-28 12:04 ` Dmitry Baryshkov 2020-08-28 14:00 ` Vinod Koul 2020-08-28 14:00 ` Vinod Koul 2020-08-28 12:04 ` [PATCH v1 2/2] drm: bridge: add support for lontium LT9611UXC bridge Dmitry Baryshkov 2020-08-28 12:04 ` Dmitry Baryshkov 2020-08-28 13:49 ` kernel test robot 2020-08-28 13:49 ` kernel test robot 2020-08-28 13:49 ` kernel test robot 2020-08-28 14:18 ` Vinod Koul 2020-08-28 14:18 ` Vinod Koul 2020-08-28 14:33 ` Laurent Pinchart [this message] 2020-08-28 14:33 ` Laurent Pinchart 2020-08-28 15:04 ` Laurent Pinchart 2020-08-28 15:04 ` Laurent Pinchart 2020-08-28 15:01 ` Dmitry Baryshkov 2020-08-28 15:01 ` Dmitry Baryshkov 2020-08-28 15:06 ` Vinod Koul 2020-08-28 15:06 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200828143300.GA6310@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=linux-arm-msm@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.