* [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash
@ 2020-08-28 15:34 Jeff Guo
2020-08-31 5:50 ` [dpdk-dev] [PATCH v2] net/ice: fix the hash parser Jeff Guo
2020-09-02 3:36 ` [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash Peng, Yuan
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Guo @ 2020-08-28 15:34 UTC (permalink / raw)
To: qiming.yang, qi.z.zhang; +Cc: dev, jia.guo
GTPU TEID hash should only be enabled when ETH_RSS_GTPU is required.
Fixes: e7cc68c70736 ("net/ice: fix GTPU TEID hash")
Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
drivers/net/ice/ice_hash.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index c0271dff5..61054557e 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -1151,7 +1151,10 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
}
/* update hash field for gtpu eh/gtpu dwn/gtpu up. */
- if (hash_meta->pkt_hdr & ICE_FLOW_SEG_HDR_GTPU_EH) {
+ if (rss_type != ETH_RSS_GTPU) {
+ break;
+ } else if (hash_meta->pkt_hdr &
+ ICE_FLOW_SEG_HDR_GTPU_EH) {
hash_meta->hash_flds &=
~(BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID));
hash_meta->hash_flds |=
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] net/ice: fix the hash parser
2020-08-28 15:34 [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash Jeff Guo
@ 2020-08-31 5:50 ` Jeff Guo
2020-08-31 7:19 ` Zhang, Qi Z
2020-09-02 3:36 ` [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash Peng, Yuan
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Guo @ 2020-08-31 5:50 UTC (permalink / raw)
To: qiming.yang, qi.z.zhang; +Cc: dev, jia.guo
GTPU TEID hash should only be enabled when ETH_RSS_GTPU is required.
And the hash parser should not restrict the combined usage of protocol.
Fixes: e7cc68c70736 ("net/ice: fix GTPU TEID hash")
Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
drivers/net/ice/ice_hash.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index c0271dff5..45c69e6bf 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -1141,7 +1141,7 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
}
/* update hash field for nat-t esp. */
- if (rss_type == ETH_RSS_ESP &&
+ if (rss_type & ETH_RSS_ESP &&
(m->eth_rss_hint & ETH_RSS_NONFRAG_IPV4_UDP ||
m->eth_rss_hint & ETH_RSS_NONFRAG_IPV6_UDP)) {
hash_meta->hash_flds &=
@@ -1151,7 +1151,10 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
}
/* update hash field for gtpu eh/gtpu dwn/gtpu up. */
- if (hash_meta->pkt_hdr & ICE_FLOW_SEG_HDR_GTPU_EH) {
+ if (!(rss_type & ETH_RSS_GTPU)) {
+ break;
+ } else if (hash_meta->pkt_hdr &
+ ICE_FLOW_SEG_HDR_GTPU_EH) {
hash_meta->hash_flds &=
~(BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID));
hash_meta->hash_flds |=
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ice: fix the hash parser
2020-08-31 5:50 ` [dpdk-dev] [PATCH v2] net/ice: fix the hash parser Jeff Guo
@ 2020-08-31 7:19 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2020-08-31 7:19 UTC (permalink / raw)
To: Guo, Jia, Yang, Qiming; +Cc: dev
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Monday, August 31, 2020 1:51 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: [PATCH v2] net/ice: fix the hash parser
>
> GTPU TEID hash should only be enabled when ETH_RSS_GTPU is required.
> And the hash parser should not restrict the combined usage of protocol.
>
> Fixes: e7cc68c70736 ("net/ice: fix GTPU TEID hash")
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash
2020-08-28 15:34 [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash Jeff Guo
2020-08-31 5:50 ` [dpdk-dev] [PATCH v2] net/ice: fix the hash parser Jeff Guo
@ 2020-09-02 3:36 ` Peng, Yuan
1 sibling, 0 replies; 4+ messages in thread
From: Peng, Yuan @ 2020-09-02 3:36 UTC (permalink / raw)
To: Guo, Jia, Yang, Qiming, Zhang, Qi Z; +Cc: dev, Guo, Jia
Test-by Peng, Yuan <yuan.peng@intel.com>
-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Jeff Guo
Sent: Friday, August 28, 2020 11:34 PM
To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
Subject: [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash
GTPU TEID hash should only be enabled when ETH_RSS_GTPU is required.
Fixes: e7cc68c70736 ("net/ice: fix GTPU TEID hash")
Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
drivers/net/ice/ice_hash.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index c0271dff5..61054557e 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -1151,7 +1151,10 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
}
/* update hash field for gtpu eh/gtpu dwn/gtpu up. */
- if (hash_meta->pkt_hdr & ICE_FLOW_SEG_HDR_GTPU_EH) {
+ if (rss_type != ETH_RSS_GTPU) {
+ break;
+ } else if (hash_meta->pkt_hdr &
+ ICE_FLOW_SEG_HDR_GTPU_EH) {
hash_meta->hash_flds &=
~(BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID));
hash_meta->hash_flds |=
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-02 3:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 15:34 [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash Jeff Guo
2020-08-31 5:50 ` [dpdk-dev] [PATCH v2] net/ice: fix the hash parser Jeff Guo
2020-08-31 7:19 ` Zhang, Qi Z
2020-09-02 3:36 ` [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash Peng, Yuan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.