All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, xxm@rock-chips.com
Subject: [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER
Date: Fri, 28 Aug 2020 18:42:42 +0100	[thread overview]
Message-ID: <20200828174242.338068-1-alexandru.elisei@arm.com> (raw)

Building the Rockchip saradc driver can trigger the following error if the
driver is compiled into the kernel, but the IIO triggered buffer is not:

aarch64-linux-gnu-ld: drivers/iio/adc/rockchip_saradc.o: in function `rockchip_saradc_probe':
/path/to/linux/drivers/iio/adc/rockchip_saradc.c:427: undefined reference to `devm_iio_triggered_buffer_setup'

This is because commit 4e130dc7b413 ("iio: adc: rockchip_saradc: Add
support iio buffers") added support for industrial I/O triggered buffers,
but didn't update Kconfig to build the required file. Fix that.

Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 66d9cc073157..baa36a07a9cf 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -865,6 +865,7 @@ config ROCKCHIP_SARADC
 	tristate "Rockchip SARADC driver"
 	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
 	depends on RESET_CONTROLLER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the SARADC found in SoCs from
 	  Rockchip.
-- 
2.28.0


             reply	other threads:[~2020-08-28 17:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 17:42 Alexandru Elisei [this message]
2020-08-29 14:57 ` [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER Jonathan Cameron
2020-08-30  9:26   ` Alexandru Elisei
  -- strict thread matches above, loose matches on Subject: below --
2020-08-03  8:30 [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER Michael Walle
2020-08-03 11:59 ` Heiko Stuebner
2020-08-09 11:52   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828174242.338068-1-alexandru.elisei@arm.com \
    --to=alexandru.elisei@arm.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=xxm@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.