All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	xxm@rock-chips.com
Subject: Re: [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER
Date: Sat, 29 Aug 2020 15:57:03 +0100	[thread overview]
Message-ID: <20200829155703.19bf1c9f@archlinux> (raw)
In-Reply-To: <20200828174242.338068-1-alexandru.elisei@arm.com>

On Fri, 28 Aug 2020 18:42:42 +0100
Alexandru Elisei <alexandru.elisei@arm.com> wrote:

> Building the Rockchip saradc driver can trigger the following error if the
> driver is compiled into the kernel, but the IIO triggered buffer is not:
> 
> aarch64-linux-gnu-ld: drivers/iio/adc/rockchip_saradc.o: in function `rockchip_saradc_probe':
> /path/to/linux/drivers/iio/adc/rockchip_saradc.c:427: undefined reference to `devm_iio_triggered_buffer_setup'
> 
> This is because commit 4e130dc7b413 ("iio: adc: rockchip_saradc: Add
> support iio buffers") added support for industrial I/O triggered buffers,
> but didn't update Kconfig to build the required file. Fix that.
> 
> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>

Sorry, I've had a patch queued to fix this for a while, but had a
vacation just after merge window occurred that delayed me sending it out.

Will send a pull sometime this weekend.

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..baa36a07a9cf 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,7 @@ config ROCKCHIP_SARADC
>  	tristate "Rockchip SARADC driver"
>  	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
>  	depends on RESET_CONTROLLER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say yes here to build support for the SARADC found in SoCs from
>  	  Rockchip.


  reply	other threads:[~2020-08-29 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 17:42 [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER Alexandru Elisei
2020-08-29 14:57 ` Jonathan Cameron [this message]
2020-08-30  9:26   ` Alexandru Elisei
  -- strict thread matches above, loose matches on Subject: below --
2020-08-03  8:30 [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER Michael Walle
2020-08-03 11:59 ` Heiko Stuebner
2020-08-09 11:52   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200829155703.19bf1c9f@archlinux \
    --to=jic23@kernel.org \
    --cc=alexandru.elisei@arm.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=xxm@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.