* [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2020-08-29 17:41 ` Sumera Priyadarsini
0 siblings, 0 replies; 8+ messages in thread
From: Sumera Priyadarsini @ 2020-08-29 17:41 UTC (permalink / raw)
To: linus.walleij; +Cc: Julia.Lawall, linux-arm-kernel, linux-kernel
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.
Fix a potential memory leak in arm-integrator-lm.c by inserting
of_node_put() before a return statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
drivers/bus/arm-integrator-lm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 845b6c43fef8..2344d560b144 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -54,6 +54,7 @@ static int integrator_lm_populate(int num, struct device *dev)
ret = of_platform_default_populate(child, NULL, dev);
if (ret) {
dev_err(dev, "failed to populate module\n");
+ of_node_put(child);
return ret;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2020-08-29 17:41 ` Sumera Priyadarsini
0 siblings, 0 replies; 8+ messages in thread
From: Sumera Priyadarsini @ 2020-08-29 17:41 UTC (permalink / raw)
To: linus.walleij; +Cc: Julia.Lawall, linux-kernel, linux-arm-kernel
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.
Fix a potential memory leak in arm-integrator-lm.c by inserting
of_node_put() before a return statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
drivers/bus/arm-integrator-lm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 845b6c43fef8..2344d560b144 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -54,6 +54,7 @@ static int integrator_lm_populate(int num, struct device *dev)
ret = of_platform_default_populate(child, NULL, dev);
if (ret) {
dev_err(dev, "failed to populate module\n");
+ of_node_put(child);
return ret;
}
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
2020-08-29 17:41 ` Sumera Priyadarsini
@ 2020-09-12 10:10 ` Linus Walleij
-1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2020-09-12 10:10 UTC (permalink / raw)
To: Sumera Priyadarsini; +Cc: Julia Lawall, Linux ARM, linux-kernel
On Sat, Aug 29, 2020 at 7:42 PM Sumera Priyadarsini
<sylphrenadin@gmail.com> wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>
> Fix a potential memory leak in arm-integrator-lm.c by inserting
> of_node_put() before a return statement.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2020-09-12 10:10 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2020-09-12 10:10 UTC (permalink / raw)
To: Sumera Priyadarsini; +Cc: Julia Lawall, linux-kernel, Linux ARM
On Sat, Aug 29, 2020 at 7:42 PM Sumera Priyadarsini
<sylphrenadin@gmail.com> wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>
> Fix a potential memory leak in arm-integrator-lm.c by inserting
> of_node_put() before a return statement.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2021-01-15 17:22 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2021-01-15 17:22 UTC (permalink / raw)
To: soc, Linus Walleij, arm
Cc: Arnd Bergmann, linux-arm-kernel, Sumera Priyadarsini
From: Arnd Bergmann <arnd@arndb.de>
On Tue, 12 Jan 2021 10:25:49 +0100, Linus Walleij wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>
> Fix a potential memory leak in arm-integrator-lm.c by inserting
> of_node_put() before a return statement.
>
> [...]
Applied to arm/fixes, thanks!
[1/1] bus: arm-integrator-lm: Add of_node_put() before return statement
commit: 1740e6736922cc1a5d061cc4240d08eacfbbaa71
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2021-01-15 17:22 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2021-01-15 17:22 UTC (permalink / raw)
To: soc, Linus Walleij, arm
Cc: Sumera Priyadarsini, linux-arm-kernel, Arnd Bergmann
From: Arnd Bergmann <arnd@arndb.de>
On Tue, 12 Jan 2021 10:25:49 +0100, Linus Walleij wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>
> Fix a potential memory leak in arm-integrator-lm.c by inserting
> of_node_put() before a return statement.
>
> [...]
Applied to arm/fixes, thanks!
[1/1] bus: arm-integrator-lm: Add of_node_put() before return statement
commit: 1740e6736922cc1a5d061cc4240d08eacfbbaa71
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2021-01-12 9:25 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2021-01-12 9:25 UTC (permalink / raw)
To: arm, soc; +Cc: linux-arm-kernel, Sumera Priyadarsini, Linus Walleij
From: Sumera Priyadarsini <sylphrenadin@gmail.com>
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.
Fix a potential memory leak in arm-integrator-lm.c by inserting
of_node_put() before a return statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829174154.GA9319@Kaladin
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
SoC people: please apply this directly as a non-urgent fix,
I have no other patches for Versatile right now.
---
drivers/bus/arm-integrator-lm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 845b6c43fef8..2344d560b144 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -54,6 +54,7 @@ static int integrator_lm_populate(int num, struct device *dev)
ret = of_platform_default_populate(child, NULL, dev);
if (ret) {
dev_err(dev, "failed to populate module\n");
+ of_node_put(child);
return ret;
}
}
--
2.29.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2021-01-12 9:25 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2021-01-12 9:25 UTC (permalink / raw)
To: arm, soc; +Cc: Linus Walleij, Sumera Priyadarsini, linux-arm-kernel
From: Sumera Priyadarsini <sylphrenadin@gmail.com>
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.
Fix a potential memory leak in arm-integrator-lm.c by inserting
of_node_put() before a return statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829174154.GA9319@Kaladin
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
SoC people: please apply this directly as a non-urgent fix,
I have no other patches for Versatile right now.
---
drivers/bus/arm-integrator-lm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 845b6c43fef8..2344d560b144 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -54,6 +54,7 @@ static int integrator_lm_populate(int num, struct device *dev)
ret = of_platform_default_populate(child, NULL, dev);
if (ret) {
dev_err(dev, "failed to populate module\n");
+ of_node_put(child);
return ret;
}
}
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-01-15 17:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-29 17:41 [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement Sumera Priyadarsini
2020-08-29 17:41 ` Sumera Priyadarsini
2020-09-12 10:10 ` Linus Walleij
2020-09-12 10:10 ` Linus Walleij
2021-01-12 9:25 Linus Walleij
2021-01-12 9:25 ` Linus Walleij
2021-01-15 17:22 ` Arnd Bergmann
2021-01-15 17:22 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.