All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bus: qcom-ebi2: Add of_node_put() before return statement
@ 2020-08-29 17:49 Sumera Priyadarsini
  0 siblings, 0 replies; only message in thread
From: Sumera Priyadarsini @ 2020-08-29 17:49 UTC (permalink / raw)
  To: agross; +Cc: bjorn.andersson, Julia.Lawall, linux-arm-msm, linux-kernel

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in qcom-ebi2.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
 drivers/bus/qcom-ebi2.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
index 03ddcf426887..0b8f53a688b8 100644
--- a/drivers/bus/qcom-ebi2.c
+++ b/drivers/bus/qcom-ebi2.c
@@ -353,8 +353,10 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
 
 		/* Figure out the chipselect */
 		ret = of_property_read_u32(child, "reg", &csindex);
-		if (ret)
+		if (ret) {
+			of_node_put(child);
 			return ret;
+		}
 
 		if (csindex > 5) {
 			dev_err(dev,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-29 17:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-29 17:49 [PATCH] bus: qcom-ebi2: Add of_node_put() before return statement Sumera Priyadarsini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.