From: Vinod Koul <vkoul@kernel.org>
To: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
Cc: kishon@ti.com, robh+dt@kernel.org, andriy.shevchenko@intel.com,
eswara.kota@linux.intel.com,
vadivel.muruganx.ramuthevar@linux.intel.com,
lakshmi.bai.raja.subramanian@intel.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support
Date: Mon, 31 Aug 2020 14:49:36 +0530 [thread overview]
Message-ID: <20200831091936.GM2639@vkoul-mobl> (raw)
In-Reply-To: <20200821113747.2912-4-wan.ahmad.zainie.wan.mohamad@intel.com>
On 21-08-20, 19:37, Wan Ahmad Zainie wrote:
> +/* From ACS_eMMC51_16nFFC_RO1100_Userguide_v1p0.pdf p17 */
> +#define FREQSEL_200M_170M 0x0
> +#define FREQSEL_170M_140M 0x1
> +#define FREQSEL_140M_110M 0x2
> +#define FREQSEL_110M_80M 0x3
> +#define FREQSEL_80M_50M 0x4
> +
> +#define maskval(mask, val) (((val) << (ffs(mask) - 1)) & mask)
Kernel has a macro do this for you, please use FIELD_PREP instead of
your own macro
--
~Vinod
next prev parent reply other threads:[~2020-08-31 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 11:37 [PATCH v7 0/3] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-08-21 11:37 ` [PATCH v7 1/3] phy: intel: Rename phy-intel to phy-intel-lgm Wan Ahmad Zainie
2020-08-31 1:40 ` Ramuthevar, Vadivel MuruganX
2020-08-21 11:37 ` [PATCH v7 2/3] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings Wan Ahmad Zainie
2020-08-31 9:10 ` Vinod Koul
2020-09-01 4:58 ` Wan Mohamad, Wan Ahmad Zainie
2020-09-01 5:51 ` Vinod Koul
2020-09-09 0:39 ` Wan Mohamad, Wan Ahmad Zainie
2020-08-21 11:37 ` [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-08-21 12:56 ` Andy Shevchenko
2020-08-31 9:19 ` Vinod Koul [this message]
2020-09-01 4:49 ` Wan Mohamad, Wan Ahmad Zainie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831091936.GM2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=kishon@ti.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.