From: Vinod Koul <vkoul@kernel.org>
To: "Wan Mohamad,
Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>
Cc: "kishon@ti.com" <kishon@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
"eswara.kota@linux.intel.com" <eswara.kota@linux.intel.com>,
"vadivel.muruganx.ramuthevar@linux.intel.com"
<vadivel.muruganx.ramuthevar@linux.intel.com>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v7 2/3] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings
Date: Tue, 1 Sep 2020 11:21:35 +0530 [thread overview]
Message-ID: <20200901055135.GY2639@vkoul-mobl> (raw)
In-Reply-To: <DM6PR11MB37210C56315013E4995DE2A3DD2E0@DM6PR11MB3721.namprd11.prod.outlook.com>
On 01-09-20, 04:58, Wan Mohamad, Wan Ahmad Zainie wrote:
> > > @@ -0,0 +1,44 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > > +---
> > > +$id: "http://devicetree.org/schemas/phy/intel,keembay-emmc-
> > phy.yaml#"
> > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > > +
> > > +title: Intel Keem Bay eMMC PHY bindings
> >
> > This seems same as
> > Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml, why
> > not add a new compatible in lgm binding, or did I miss a difference?
>
> AFAIK, LGM make use of syscon node, whilst KMB does not.
> And LGM and KMB belongs to different SoC family. So, I prefer them to
> be in separate file.
>
> Having said that, with few changes in wordings in title and description,
> I think we can make it generic and can be used across few products.
The bindings seems quite similar. We can have two drivers loaded using
two compatible but binding description can be made same
--
~Vinod
next prev parent reply other threads:[~2020-09-01 5:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 11:37 [PATCH v7 0/3] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-08-21 11:37 ` [PATCH v7 1/3] phy: intel: Rename phy-intel to phy-intel-lgm Wan Ahmad Zainie
2020-08-31 1:40 ` Ramuthevar, Vadivel MuruganX
2020-08-21 11:37 ` [PATCH v7 2/3] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings Wan Ahmad Zainie
2020-08-31 9:10 ` Vinod Koul
2020-09-01 4:58 ` Wan Mohamad, Wan Ahmad Zainie
2020-09-01 5:51 ` Vinod Koul [this message]
2020-09-09 0:39 ` Wan Mohamad, Wan Ahmad Zainie
2020-08-21 11:37 ` [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-08-21 12:56 ` Andy Shevchenko
2020-08-31 9:19 ` Vinod Koul
2020-09-01 4:49 ` Wan Mohamad, Wan Ahmad Zainie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901055135.GY2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=kishon@ti.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.