All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] remoteproc: stm32: Fix pointer assignement
@ 2020-08-31 21:37 ` Mathieu Poirier
  0 siblings, 0 replies; 5+ messages in thread
From: Mathieu Poirier @ 2020-08-31 21:37 UTC (permalink / raw)
  To: ohad, bjorn.andersson, mcoquelin.stm32, alexandre.torgue
  Cc: linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel

Fix the assignment of the @state pointer - it is obviously wrong.

Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 drivers/remoteproc/stm32_rproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index f4da42fc0eeb..d2414cc1d90d 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata,
 		 * We couldn't get the coprocessor's state, assume
 		 * it is not running.
 		 */
-		state = M4_STATE_OFF;
+		*state = M4_STATE_OFF;
 		return 0;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] remoteproc: stm32: Fix pointer assignement
@ 2020-08-31 21:37 ` Mathieu Poirier
  0 siblings, 0 replies; 5+ messages in thread
From: Mathieu Poirier @ 2020-08-31 21:37 UTC (permalink / raw)
  To: ohad, bjorn.andersson, mcoquelin.stm32, alexandre.torgue
  Cc: linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel

Fix the assignment of the @state pointer - it is obviously wrong.

Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 drivers/remoteproc/stm32_rproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index f4da42fc0eeb..d2414cc1d90d 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata,
 		 * We couldn't get the coprocessor's state, assume
 		 * it is not running.
 		 */
-		state = M4_STATE_OFF;
+		*state = M4_STATE_OFF;
 		return 0;
 	}
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] remoteproc: stm32: Fix pointer assignement
  2020-08-31 21:37 ` Mathieu Poirier
@ 2020-09-01  7:23   ` Arnaud POULIQUEN
  -1 siblings, 0 replies; 5+ messages in thread
From: Arnaud POULIQUEN @ 2020-09-01  7:23 UTC (permalink / raw)
  To: Mathieu Poirier, ohad, bjorn.andersson, mcoquelin.stm32,
	Alexandre TORGUE
  Cc: linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel

Hi Mathieu,

On 8/31/20 11:37 PM, Mathieu Poirier wrote:
> Fix the assignment of the @state pointer - it is obviously wrong.
> 
> Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Thanks,
Arnaud
> ---
>  drivers/remoteproc/stm32_rproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index f4da42fc0eeb..d2414cc1d90d 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata,
>  		 * We couldn't get the coprocessor's state, assume
>  		 * it is not running.
>  		 */
> -		state = M4_STATE_OFF;
> +		*state = M4_STATE_OFF;
>  		return 0;
>  	}
>  
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] remoteproc: stm32: Fix pointer assignement
@ 2020-09-01  7:23   ` Arnaud POULIQUEN
  0 siblings, 0 replies; 5+ messages in thread
From: Arnaud POULIQUEN @ 2020-09-01  7:23 UTC (permalink / raw)
  To: Mathieu Poirier, ohad, bjorn.andersson, mcoquelin.stm32,
	Alexandre TORGUE
  Cc: linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel

Hi Mathieu,

On 8/31/20 11:37 PM, Mathieu Poirier wrote:
> Fix the assignment of the @state pointer - it is obviously wrong.
> 
> Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Thanks,
Arnaud
> ---
>  drivers/remoteproc/stm32_rproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index f4da42fc0eeb..d2414cc1d90d 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata,
>  		 * We couldn't get the coprocessor's state, assume
>  		 * it is not running.
>  		 */
> -		state = M4_STATE_OFF;
> +		*state = M4_STATE_OFF;
>  		return 0;
>  	}
>  
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] remoteproc: stm32: Fix pointer assignement
  2020-08-31 21:37 ` Mathieu Poirier
  (?)
  (?)
@ 2020-09-15  5:00 ` patchwork-bot+linux-remoteproc
  -1 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2020-09-15  5:00 UTC (permalink / raw)
  To: Mathieu Poirier; +Cc: linux-remoteproc

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next).

On Mon, 31 Aug 2020 15:37:58 -0600 you wrote:
> Fix the assignment of the @state pointer - it is obviously wrong.
> 
> Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  drivers/remoteproc/stm32_rproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Here is a summary with links:
  - remoteproc: stm32: Fix pointer assignement
    https://git.kernel.org/andersson/remoteproc/c/cb2d8d5b196c2e96e29343383c8c8d8db68b934e

You are awesome, thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-15  5:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31 21:37 [PATCH] remoteproc: stm32: Fix pointer assignement Mathieu Poirier
2020-08-31 21:37 ` Mathieu Poirier
2020-09-01  7:23 ` Arnaud POULIQUEN
2020-09-01  7:23   ` Arnaud POULIQUEN
2020-09-15  5:00 ` patchwork-bot+linux-remoteproc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.