From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
Douglas Anderson <dianders@chromium.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Date: Tue, 1 Sep 2020 14:08:06 +0530 [thread overview]
Message-ID: <20200901083806.a2wz7idmfce2aj3a@vireshk-i7> (raw)
In-Reply-To: <bc64e031-c42f-9ed2-c597-18a790a4d3bb@codeaurora.org>
On 01-09-20, 13:01, Rajendra Nayak wrote:
> So FWIU, dpu_unbind() gets called even when dpu_bind() fails for some reason.
Ahh, I see.
> I tried to address that earlier [1] which I realized did not land.
I don't think that patch was required, as you can call
dev_pm_opp_put_clkname() multiple times and it will return without any
errors/crash.
> But with these changes
> it will be even more broken unless we identify if we failed dpu_bind() before
> adding the OPP table, while adding it, or all went well with opps and handle things
> accordingly in dpu_unbind.
Maybe not as dev_pm_opp_of_remove_table() can be called multiple times
as well without any errors or crash.
> [1] https://lore.kernel.org/patchwork/patch/1275632/
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Nishanth Menon <nm@ti.com>,
freedreno@lists.freedesktop.org,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Douglas Anderson <dianders@chromium.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Date: Tue, 1 Sep 2020 14:08:06 +0530 [thread overview]
Message-ID: <20200901083806.a2wz7idmfce2aj3a@vireshk-i7> (raw)
In-Reply-To: <bc64e031-c42f-9ed2-c597-18a790a4d3bb@codeaurora.org>
On 01-09-20, 13:01, Rajendra Nayak wrote:
> So FWIU, dpu_unbind() gets called even when dpu_bind() fails for some reason.
Ahh, I see.
> I tried to address that earlier [1] which I realized did not land.
I don't think that patch was required, as you can call
dev_pm_opp_put_clkname() multiple times and it will return without any
errors/crash.
> But with these changes
> it will be even more broken unless we identify if we failed dpu_bind() before
> adding the OPP table, while adding it, or all went well with opps and handle things
> accordingly in dpu_unbind.
Maybe not as dev_pm_opp_of_remove_table() can be called multiple times
as well without any errors or crash.
> [1] https://lore.kernel.org/patchwork/patch/1275632/
--
viresh
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-01 8:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 6:07 [PATCH V2 0/8] opp: Unconditionally call dev_pm_opp_of_remove_table() Viresh Kumar
2020-08-28 6:07 ` Viresh Kumar
2020-08-28 6:07 ` Viresh Kumar
2020-08-28 6:07 ` [PATCH V2 1/8] cpufreq: imx6q: " Viresh Kumar
2020-08-28 6:07 ` Viresh Kumar
2020-08-28 6:07 ` [PATCH V2 2/8] drm/lima: " Viresh Kumar
2020-08-28 6:07 ` Viresh Kumar
2020-10-22 5:14 ` Viresh Kumar
2020-10-22 5:14 ` Viresh Kumar
2020-08-28 6:07 ` [PATCH V2 3/8] drm/msm: " Viresh Kumar
2020-08-28 6:07 ` Viresh Kumar
2020-09-01 7:31 ` Rajendra Nayak
2020-09-01 7:31 ` Rajendra Nayak
2020-09-01 8:38 ` Viresh Kumar [this message]
2020-09-01 8:38 ` Viresh Kumar
2020-09-01 9:45 ` Rajendra Nayak
2020-09-01 9:45 ` Rajendra Nayak
2020-09-01 9:50 ` Viresh Kumar
2020-09-01 9:50 ` Viresh Kumar
2020-10-05 6:26 ` Viresh Kumar
2020-10-05 6:26 ` Viresh Kumar
2020-10-21 7:24 ` Viresh Kumar
2020-10-21 7:24 ` Viresh Kumar
2020-10-21 16:58 ` Rob Clark
2020-10-21 16:58 ` Rob Clark
2020-10-22 5:12 ` Viresh Kumar
2020-10-22 5:12 ` Viresh Kumar
2020-08-28 6:07 ` [PATCH V2 4/8] mmc: sdhci-msm: " Viresh Kumar
2020-08-28 8:43 ` Ulf Hansson
2020-08-28 15:06 ` Doug Anderson
2020-08-31 6:23 ` Viresh Kumar
2020-08-31 10:44 ` Viresh Kumar
2020-08-31 10:57 ` Ulf Hansson
2020-09-09 11:07 ` Viresh Kumar
2020-09-09 12:48 ` Ulf Hansson
2020-08-28 6:07 ` [PATCH V2 5/8] spi: spi-geni-qcom: " Viresh Kumar
2020-08-28 6:07 ` [PATCH V2 6/8] spi: spi-qcom-qspi: " Viresh Kumar
2020-08-28 6:07 ` [PATCH V2 7/8] tty: serial: qcom_geni_serial: " Viresh Kumar
2020-08-28 6:07 ` [PATCH V2 8/8] qcom-geni-se: remove has_opp_table Viresh Kumar
2020-10-21 7:34 ` Viresh Kumar
2020-10-21 15:31 ` Doug Anderson
2020-08-31 11:09 ` [PATCH V2 0/8] opp: Unconditionally call dev_pm_opp_of_remove_table() Viresh Kumar
2020-08-31 11:09 ` Viresh Kumar
2020-08-31 11:09 ` Viresh Kumar
2020-09-09 11:08 ` Viresh Kumar
2020-09-09 11:08 ` Viresh Kumar
2020-09-09 11:08 ` Viresh Kumar
2020-09-09 15:28 ` Mark Brown
2020-09-09 15:28 ` Mark Brown
2020-09-09 15:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901083806.a2wz7idmfce2aj3a@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.