[chrome-os:chromeos-4.4 23/39] net/core/ethtool.c:648:5-34: Move constant to right.

[chrome-os:chromeos-4.4 23/39] net/core/ethtool.c:648:5-34: Move constant to right.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

CC: kbuild-all(a)lists.01.org
TO: cros-kernel-buildreports(a)googlegroups.com
TO: Guenter Roeck <groeck@google.com>

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4
head:   718be6ad0e1b9e4a35f04c66a844a0d0298d7e35
commit: 9dbdde22e919de21d4297fedc79bee9fc8538154 [23/39] UPSTREAM:net: ethtool: add new ETHTOOL_xLINKSETTINGS API
:::::: branch date: 2 days ago
:::::: commit date: 4 days ago
config: c6x-randconfig-c004-20200901 (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> net/core/ethtool.c:648:5-34: Move constant to right.
   net/core/ethtool.c:712:5-34: Move constant to right.
   net/core/ethtool.c:724:5-34: Move constant to right.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 17905 bytes --]

[PATCH] UPSTREAM:net: ethtool: fix compare_const_fl.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2454 bytes --]

CC: kbuild-all(a)lists.01.org
TO: cros-kernel-buildreports(a)googlegroups.com
TO: Guenter Roeck <groeck@google.com>

From: kernel test robot <lkp@intel.com>

net/core/ethtool.c:648:5-34: Move constant to right.
net/core/ethtool.c:712:5-34: Move constant to right.
net/core/ethtool.c:724:5-34: Move constant to right.

 Move constants to the right of binary operators.

Semantic patch information:
 Depends on personal taste in some cases.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

Fixes: 9dbdde22e919 ("UPSTREAM:net: ethtool: add new ETHTOOL_xLINKSETTINGS API")
CC: David Decotigny <decot@googlers.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4
head:   718be6ad0e1b9e4a35f04c66a844a0d0298d7e35
commit: 9dbdde22e919de21d4297fedc79bee9fc8538154 [23/39] UPSTREAM:net: ethtool: add new ETHTOOL_xLINKSETTINGS API
:::::: branch date: 2 days ago
:::::: commit date: 4 days ago

Please take the patch only if it's a positive warning. Thanks!

 ethtool.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -645,8 +645,8 @@ static int ethtool_get_link_ksettings(st
 			   sizeof(link_ksettings.base)))
 		return -EFAULT;
 
-	if (__ETHTOOL_LINK_MODE_MASK_NU32
-	    != link_ksettings.base.link_mode_masks_nwords) {
+	if (link_ksettings.base.link_mode_masks_nwords
+	    != __ETHTOOL_LINK_MODE_MASK_NU32) {
 		/* wrong link mode nbits requested */
 		memset(&link_ksettings, 0, sizeof(link_ksettings));
 		/* keep cmd field reset to 0 */
@@ -709,8 +709,8 @@ static int ethtool_set_link_ksettings(st
 			   sizeof(link_ksettings.base)))
 		return -EFAULT;
 
-	if (__ETHTOOL_LINK_MODE_MASK_NU32
-	    != link_ksettings.base.link_mode_masks_nwords)
+	if (link_ksettings.base.link_mode_masks_nwords
+	    != __ETHTOOL_LINK_MODE_MASK_NU32)
 		return -EINVAL;
 
 	/* copy the whole structure, now that we know it has expected
@@ -721,8 +721,8 @@ static int ethtool_set_link_ksettings(st
 		return err;
 
 	/* re-check nwords field, just in case */
-	if (__ETHTOOL_LINK_MODE_MASK_NU32
-	    != link_ksettings.base.link_mode_masks_nwords)
+	if (link_ksettings.base.link_mode_masks_nwords
+	    != __ETHTOOL_LINK_MODE_MASK_NU32)
 		return -EINVAL;
 
 	return dev->ethtool_ops->set_link_ksettings(dev, &link_ksettings);