All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
@ 2020-09-02 11:07 ` Nicolas Boichat
  0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Boichat @ 2020-09-02 11:07 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Nicolas Boichat, Matthias Brugger, Ohad Ben-Cohen, Pi-Hsun Shih,
	linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc

If rpmsg_register_device fails, it will call
mtk_rpmsg_release_device which already frees mdev.

Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---

Changes in v2:
 - Drop useless if and ret variable (Markus Elfring)

 drivers/rpmsg/mtk_rpmsg.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
index 83f2b8804ee989d..96a17ec2914011d 100644
--- a/drivers/rpmsg/mtk_rpmsg.c
+++ b/drivers/rpmsg/mtk_rpmsg.c
@@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
 	struct rpmsg_device *rpdev;
 	struct mtk_rpmsg_device *mdev;
 	struct platform_device *pdev = mtk_subdev->pdev;
-	int ret;
 
 	mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
 	if (!mdev)
@@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
 	rpdev->dev.parent = &pdev->dev;
 	rpdev->dev.release = mtk_rpmsg_release_device;
 
-	ret = rpmsg_register_device(rpdev);
-	if (ret) {
-		kfree(mdev);
-		return ret;
-	}
-
-	return 0;
+	return rpmsg_register_device(rpdev);
 }
 
 static void mtk_register_device_work_function(struct work_struct *register_work)
-- 
2.28.0.402.g5ffc5be6b7-goog


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
@ 2020-09-02 11:07 ` Nicolas Boichat
  0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Boichat @ 2020-09-02 11:07 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Ohad Ben-Cohen, Nicolas Boichat, linux-remoteproc, linux-kernel,
	linux-mediatek, Pi-Hsun Shih, Matthias Brugger, linux-arm-kernel

If rpmsg_register_device fails, it will call
mtk_rpmsg_release_device which already frees mdev.

Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---

Changes in v2:
 - Drop useless if and ret variable (Markus Elfring)

 drivers/rpmsg/mtk_rpmsg.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
index 83f2b8804ee989d..96a17ec2914011d 100644
--- a/drivers/rpmsg/mtk_rpmsg.c
+++ b/drivers/rpmsg/mtk_rpmsg.c
@@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
 	struct rpmsg_device *rpdev;
 	struct mtk_rpmsg_device *mdev;
 	struct platform_device *pdev = mtk_subdev->pdev;
-	int ret;
 
 	mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
 	if (!mdev)
@@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
 	rpdev->dev.parent = &pdev->dev;
 	rpdev->dev.release = mtk_rpmsg_release_device;
 
-	ret = rpmsg_register_device(rpdev);
-	if (ret) {
-		kfree(mdev);
-		return ret;
-	}
-
-	return 0;
+	return rpmsg_register_device(rpdev);
 }
 
 static void mtk_register_device_work_function(struct work_struct *register_work)
-- 
2.28.0.402.g5ffc5be6b7-goog


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
@ 2020-09-02 11:07 ` Nicolas Boichat
  0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Boichat @ 2020-09-02 11:07 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Ohad Ben-Cohen, Nicolas Boichat, linux-remoteproc, linux-kernel,
	linux-mediatek, Pi-Hsun Shih, Matthias Brugger, linux-arm-kernel

If rpmsg_register_device fails, it will call
mtk_rpmsg_release_device which already frees mdev.

Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---

Changes in v2:
 - Drop useless if and ret variable (Markus Elfring)

 drivers/rpmsg/mtk_rpmsg.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
index 83f2b8804ee989d..96a17ec2914011d 100644
--- a/drivers/rpmsg/mtk_rpmsg.c
+++ b/drivers/rpmsg/mtk_rpmsg.c
@@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
 	struct rpmsg_device *rpdev;
 	struct mtk_rpmsg_device *mdev;
 	struct platform_device *pdev = mtk_subdev->pdev;
-	int ret;
 
 	mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
 	if (!mdev)
@@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
 	rpdev->dev.parent = &pdev->dev;
 	rpdev->dev.release = mtk_rpmsg_release_device;
 
-	ret = rpmsg_register_device(rpdev);
-	if (ret) {
-		kfree(mdev);
-		return ret;
-	}
-
-	return 0;
+	return rpmsg_register_device(rpdev);
 }
 
 static void mtk_register_device_work_function(struct work_struct *register_work)
-- 
2.28.0.402.g5ffc5be6b7-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
  2020-09-02 11:07 ` Nicolas Boichat
  (?)
@ 2020-09-02 16:55   ` Mathieu Poirier
  -1 siblings, 0 replies; 9+ messages in thread
From: Mathieu Poirier @ 2020-09-02 16:55 UTC (permalink / raw)
  To: Nicolas Boichat
  Cc: Bjorn Andersson, Matthias Brugger, Ohad Ben-Cohen, Pi-Hsun Shih,
	linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc

On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote:
> If rpmsg_register_device fails, it will call
> mtk_rpmsg_release_device which already frees mdev.
> 
> Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")

The SHA should be 12 characters instead of 15.  With that:

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
> 
> Changes in v2:
>  - Drop useless if and ret variable (Markus Elfring)
> 
>  drivers/rpmsg/mtk_rpmsg.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
> index 83f2b8804ee989d..96a17ec2914011d 100644
> --- a/drivers/rpmsg/mtk_rpmsg.c
> +++ b/drivers/rpmsg/mtk_rpmsg.c
> @@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
>  	struct rpmsg_device *rpdev;
>  	struct mtk_rpmsg_device *mdev;
>  	struct platform_device *pdev = mtk_subdev->pdev;
> -	int ret;
>  
>  	mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
>  	if (!mdev)
> @@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
>  	rpdev->dev.parent = &pdev->dev;
>  	rpdev->dev.release = mtk_rpmsg_release_device;
>  
> -	ret = rpmsg_register_device(rpdev);
> -	if (ret) {
> -		kfree(mdev);
> -		return ret;
> -	}
> -
> -	return 0;
> +	return rpmsg_register_device(rpdev);
>  }
>  
>  static void mtk_register_device_work_function(struct work_struct *register_work)
> -- 
> 2.28.0.402.g5ffc5be6b7-goog
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
@ 2020-09-02 16:55   ` Mathieu Poirier
  0 siblings, 0 replies; 9+ messages in thread
From: Mathieu Poirier @ 2020-09-02 16:55 UTC (permalink / raw)
  To: Nicolas Boichat
  Cc: Ohad Ben-Cohen, linux-remoteproc, linux-kernel, Bjorn Andersson,
	linux-mediatek, Pi-Hsun Shih, Matthias Brugger, linux-arm-kernel

On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote:
> If rpmsg_register_device fails, it will call
> mtk_rpmsg_release_device which already frees mdev.
> 
> Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")

The SHA should be 12 characters instead of 15.  With that:

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
> 
> Changes in v2:
>  - Drop useless if and ret variable (Markus Elfring)
> 
>  drivers/rpmsg/mtk_rpmsg.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
> index 83f2b8804ee989d..96a17ec2914011d 100644
> --- a/drivers/rpmsg/mtk_rpmsg.c
> +++ b/drivers/rpmsg/mtk_rpmsg.c
> @@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
>  	struct rpmsg_device *rpdev;
>  	struct mtk_rpmsg_device *mdev;
>  	struct platform_device *pdev = mtk_subdev->pdev;
> -	int ret;
>  
>  	mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
>  	if (!mdev)
> @@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
>  	rpdev->dev.parent = &pdev->dev;
>  	rpdev->dev.release = mtk_rpmsg_release_device;
>  
> -	ret = rpmsg_register_device(rpdev);
> -	if (ret) {
> -		kfree(mdev);
> -		return ret;
> -	}
> -
> -	return 0;
> +	return rpmsg_register_device(rpdev);
>  }
>  
>  static void mtk_register_device_work_function(struct work_struct *register_work)
> -- 
> 2.28.0.402.g5ffc5be6b7-goog
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
@ 2020-09-02 16:55   ` Mathieu Poirier
  0 siblings, 0 replies; 9+ messages in thread
From: Mathieu Poirier @ 2020-09-02 16:55 UTC (permalink / raw)
  To: Nicolas Boichat
  Cc: Ohad Ben-Cohen, linux-remoteproc, linux-kernel, Bjorn Andersson,
	linux-mediatek, Pi-Hsun Shih, Matthias Brugger, linux-arm-kernel

On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote:
> If rpmsg_register_device fails, it will call
> mtk_rpmsg_release_device which already frees mdev.
> 
> Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")

The SHA should be 12 characters instead of 15.  With that:

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
> 
> Changes in v2:
>  - Drop useless if and ret variable (Markus Elfring)
> 
>  drivers/rpmsg/mtk_rpmsg.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
> index 83f2b8804ee989d..96a17ec2914011d 100644
> --- a/drivers/rpmsg/mtk_rpmsg.c
> +++ b/drivers/rpmsg/mtk_rpmsg.c
> @@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
>  	struct rpmsg_device *rpdev;
>  	struct mtk_rpmsg_device *mdev;
>  	struct platform_device *pdev = mtk_subdev->pdev;
> -	int ret;
>  
>  	mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
>  	if (!mdev)
> @@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
>  	rpdev->dev.parent = &pdev->dev;
>  	rpdev->dev.release = mtk_rpmsg_release_device;
>  
> -	ret = rpmsg_register_device(rpdev);
> -	if (ret) {
> -		kfree(mdev);
> -		return ret;
> -	}
> -
> -	return 0;
> +	return rpmsg_register_device(rpdev);
>  }
>  
>  static void mtk_register_device_work_function(struct work_struct *register_work)
> -- 
> 2.28.0.402.g5ffc5be6b7-goog
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
  2020-09-02 16:55   ` Mathieu Poirier
  (?)
@ 2020-09-03  0:08     ` Nicolas Boichat
  -1 siblings, 0 replies; 9+ messages in thread
From: Nicolas Boichat @ 2020-09-03  0:08 UTC (permalink / raw)
  To: Mathieu Poirier
  Cc: Bjorn Andersson, Matthias Brugger, Ohad Ben-Cohen, Pi-Hsun Shih,
	linux-arm Mailing List, lkml,
	moderated list:ARM/Mediatek SoC support,
	open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM

On Thu, Sep 3, 2020 at 12:55 AM Mathieu Poirier
<mathieu.poirier@linaro.org> wrote:
>
> On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote:
> > If rpmsg_register_device fails, it will call
> > mtk_rpmsg_release_device which already frees mdev.
> >
> > Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")
>
> The SHA should be 12 characters instead of 15.  With that:

Done in v3, thanks (and fixed my process for next time).

> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >
> > Changes in v2:
> >  - Drop useless if and ret variable (Markus Elfring)
> >
> >  drivers/rpmsg/mtk_rpmsg.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
> > index 83f2b8804ee989d..96a17ec2914011d 100644
> > --- a/drivers/rpmsg/mtk_rpmsg.c
> > +++ b/drivers/rpmsg/mtk_rpmsg.c
> > @@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
> >       struct rpmsg_device *rpdev;
> >       struct mtk_rpmsg_device *mdev;
> >       struct platform_device *pdev = mtk_subdev->pdev;
> > -     int ret;
> >
> >       mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
> >       if (!mdev)
> > @@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
> >       rpdev->dev.parent = &pdev->dev;
> >       rpdev->dev.release = mtk_rpmsg_release_device;
> >
> > -     ret = rpmsg_register_device(rpdev);
> > -     if (ret) {
> > -             kfree(mdev);
> > -             return ret;
> > -     }
> > -
> > -     return 0;
> > +     return rpmsg_register_device(rpdev);
> >  }
> >
> >  static void mtk_register_device_work_function(struct work_struct *register_work)
> > --
> > 2.28.0.402.g5ffc5be6b7-goog
> >

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
@ 2020-09-03  0:08     ` Nicolas Boichat
  0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Boichat @ 2020-09-03  0:08 UTC (permalink / raw)
  To: Mathieu Poirier
  Cc: Ohad Ben-Cohen,
	open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM, lkml,
	Bjorn Andersson, moderated list:ARM/Mediatek SoC support,
	Pi-Hsun Shih, Matthias Brugger, linux-arm Mailing List

On Thu, Sep 3, 2020 at 12:55 AM Mathieu Poirier
<mathieu.poirier@linaro.org> wrote:
>
> On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote:
> > If rpmsg_register_device fails, it will call
> > mtk_rpmsg_release_device which already frees mdev.
> >
> > Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")
>
> The SHA should be 12 characters instead of 15.  With that:

Done in v3, thanks (and fixed my process for next time).

> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >
> > Changes in v2:
> >  - Drop useless if and ret variable (Markus Elfring)
> >
> >  drivers/rpmsg/mtk_rpmsg.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
> > index 83f2b8804ee989d..96a17ec2914011d 100644
> > --- a/drivers/rpmsg/mtk_rpmsg.c
> > +++ b/drivers/rpmsg/mtk_rpmsg.c
> > @@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
> >       struct rpmsg_device *rpdev;
> >       struct mtk_rpmsg_device *mdev;
> >       struct platform_device *pdev = mtk_subdev->pdev;
> > -     int ret;
> >
> >       mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
> >       if (!mdev)
> > @@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
> >       rpdev->dev.parent = &pdev->dev;
> >       rpdev->dev.release = mtk_rpmsg_release_device;
> >
> > -     ret = rpmsg_register_device(rpdev);
> > -     if (ret) {
> > -             kfree(mdev);
> > -             return ret;
> > -     }
> > -
> > -     return 0;
> > +     return rpmsg_register_device(rpdev);
> >  }
> >
> >  static void mtk_register_device_work_function(struct work_struct *register_work)
> > --
> > 2.28.0.402.g5ffc5be6b7-goog
> >

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device
@ 2020-09-03  0:08     ` Nicolas Boichat
  0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Boichat @ 2020-09-03  0:08 UTC (permalink / raw)
  To: Mathieu Poirier
  Cc: Ohad Ben-Cohen,
	open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM, lkml,
	Bjorn Andersson, moderated list:ARM/Mediatek SoC support,
	Pi-Hsun Shih, Matthias Brugger, linux-arm Mailing List

On Thu, Sep 3, 2020 at 12:55 AM Mathieu Poirier
<mathieu.poirier@linaro.org> wrote:
>
> On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote:
> > If rpmsg_register_device fails, it will call
> > mtk_rpmsg_release_device which already frees mdev.
> >
> > Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")
>
> The SHA should be 12 characters instead of 15.  With that:

Done in v3, thanks (and fixed my process for next time).

> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >
> > Changes in v2:
> >  - Drop useless if and ret variable (Markus Elfring)
> >
> >  drivers/rpmsg/mtk_rpmsg.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
> > index 83f2b8804ee989d..96a17ec2914011d 100644
> > --- a/drivers/rpmsg/mtk_rpmsg.c
> > +++ b/drivers/rpmsg/mtk_rpmsg.c
> > @@ -200,7 +200,6 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
> >       struct rpmsg_device *rpdev;
> >       struct mtk_rpmsg_device *mdev;
> >       struct platform_device *pdev = mtk_subdev->pdev;
> > -     int ret;
> >
> >       mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
> >       if (!mdev)
> > @@ -219,13 +218,7 @@ static int mtk_rpmsg_register_device(struct mtk_rpmsg_rproc_subdev *mtk_subdev,
> >       rpdev->dev.parent = &pdev->dev;
> >       rpdev->dev.release = mtk_rpmsg_release_device;
> >
> > -     ret = rpmsg_register_device(rpdev);
> > -     if (ret) {
> > -             kfree(mdev);
> > -             return ret;
> > -     }
> > -
> > -     return 0;
> > +     return rpmsg_register_device(rpdev);
> >  }
> >
> >  static void mtk_register_device_work_function(struct work_struct *register_work)
> > --
> > 2.28.0.402.g5ffc5be6b7-goog
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-09-03  0:09 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 11:07 [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device Nicolas Boichat
2020-09-02 11:07 ` Nicolas Boichat
2020-09-02 11:07 ` Nicolas Boichat
2020-09-02 16:55 ` Mathieu Poirier
2020-09-02 16:55   ` Mathieu Poirier
2020-09-02 16:55   ` Mathieu Poirier
2020-09-03  0:08   ` Nicolas Boichat
2020-09-03  0:08     ` Nicolas Boichat
2020-09-03  0:08     ` Nicolas Boichat

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.