[RFC PATCH] xmm7xxx: Fix non compiling file

[RFC PATCH] xmm7xxx: Fix non compiling file

[poeschel]

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

From: Lars Poeschel <poeschel@lemonage.de>

I get a compilation error on plugins/xmm7xx.c:

  CC       plugins/xmm7xxx.o
../plugins/xmm7xxx.c:63:10: fatal error: dbus.h: No such file or directory
   63 | #include "dbus.h"
      |          ^~~~~~~~
compilation terminated.

The commit that introduced this for me is: d2fd1721.
I do out-of-tree builds.
The fix is to simply delete the failing include. Since no other file in
ofono uses such an include i consider this as a mistake.
---
 plugins/xmm7xxx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c
index bf90833d..5efdbe26 100644
--- a/plugins/xmm7xxx.c
+++ b/plugins/xmm7xxx.c
@@ -60,7 +60,6 @@
 #include "ofono.h"
 #include "gdbus.h"
 #include "util.h"
-#include "dbus.h"
 
 #define OFONO_COEX_INTERFACE OFONO_SERVICE ".intel.LteCoexistence"
 #define OFONO_COEX_AGENT_INTERFACE OFONO_SERVICE ".intel.LteCoexistenceAgent"
-- 
2.28.0

Re: [RFC PATCH] xmm7xxx: Fix non compiling file

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

Hi Lars,

On 9/3/20 4:43 AM, poeschel(a)lemonage.de wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
> 
> I get a compilation error on plugins/xmm7xx.c:
> 
>    CC       plugins/xmm7xxx.o
> ../plugins/xmm7xxx.c:63:10: fatal error: dbus.h: No such file or directory
>     63 | #include "dbus.h"
>        |          ^~~~~~~~
> compilation terminated.
> 
> The commit that introduced this for me is: d2fd1721.
> I do out-of-tree builds.
> The fix is to simply delete the failing include. Since no other file in
> ofono uses such an include i consider this as a mistake.
> ---
>   plugins/xmm7xxx.c | 1 -
>   1 file changed, 1 deletion(-)
> 

Applied after tweaking the commit messagee, thanks.

Regards,
-Denis