[igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Ayaz A Siddiqui]

DRM subsystem filter in intel_gpu_top was not working due to missing
PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
leads to fix this issue.

Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
---
 lib/igt_device_scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 345bae76d..3583c69c7 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
 	/* We take first one if more than one card matches filter */
 	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
 
-	__copy_dev_to_card(dev, card);
+	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);
 
 	return true;
 }
-- 
2.26.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top

[Ayaz A Siddiqui]

intel_gpu_top is selecting first discrete device as default drm subsystem.
In case of multi drm device if the first device is not intel gpu
then it will lead to an error while running intel_gpu_top.

Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
---
 lib/igt_device_scan.c | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 3583c69c7..3e183423c 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -426,6 +426,25 @@ static struct igt_device *igt_device_find(const char *subsystem,
 	return NULL;
 }
 
+static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
+{
+	const char *vendor_id;
+
+	if (!dev->vendor || !vendor)
+		return false;
+
+	/* First we compare vendor id, like 8086 */
+	if (!strcasecmp(dev->vendor, vendor))
+		return true;
+
+	/* Likely we have vendor string instead of id */
+	vendor_id = get_pci_vendor_id_by_name(vendor);
+	if (!vendor_id)
+		return false;
+
+	return !strcasecmp(dev->vendor, vendor_id);
+}
+
 static void
 __copy_dev_to_card(struct igt_device *dev, struct igt_device_card *card)
 {
@@ -455,7 +474,7 @@ void igt_device_find_first_i915_discrete_card(struct igt_device_card *card)
 
 	igt_list_for_each_entry(dev, &igt_devs.all, link) {
 
-		if (!is_pci_subsystem(dev))
+		if (!is_pci_subsystem(dev) || !is_vendor_matched(dev, "intel"))
 			continue;
 
 		if ((strncmp(dev->pci_slot_name, INTEGRATED_I915_GPU_PCI_ID, PCI_SLOT_NAME_SIZE)) != 0) {
@@ -889,25 +908,6 @@ static bool parse_filter(const char *fstr, struct filter *filter)
 	return false;
 }
 
-static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
-{
-	const char *vendor_id;
-
-	if (!dev->vendor || !vendor)
-		return false;
-
-	/* First we compare vendor id, like 8086 */
-	if (!strcasecmp(dev->vendor, vendor))
-		return true;
-
-	/* Likely we have vendor string instead of id */
-	vendor_id = get_pci_vendor_id_by_name(vendor);
-	if (!vendor_id)
-		return false;
-
-	return !strcasecmp(dev->vendor, vendor_id);
-}
-
 /* Filter which matches subsystem:/sys/... path.
  * Used as first filter in chain.
  */
-- 
2.26.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 0/2] Fix for device detection issues with intel gpu top

[Petri Latvala]

On Thu, Sep 03, 2020 at 04:31:08PM +0530, Ayaz A Siddiqui wrote:
> Intel_gpu_top device selection filters for drm subsystem were not working as
> expected. intel_gpu_top relies on PCI_SLOT_NAME to select correct PMU paths
> for dgpu, in case of drm subsystem this property is not present which leads
> to fall back to igpu if present otherwise it was throwing below error.
> 
> Failed to detect engines! (No such file or directory)
> (Kernel 4.16 or newer is required for i915 PMU support.)
> 
> The fix of this issue is to use parent of drm subsystem to get PCI_SLOT_NAME.
> 
> There was another issue in default GPU selection, search logic was relying
> on the first discrete drm device. In case of non-intel drm device is present
> prior to intel gpu then it was being selected which leads to error in pmu data.
> 
> The default search will now search for the first intel discrete gpu device
> 
> Ayaz A Siddiqui (2):
>   lib/igt_device_scan: Fix device selection filter
>   lib/igt_device_scan: Select intel as default vendor for intel_gpu_top
> 
>  lib/igt_device_scan.c | 42 +++++++++++++++++++++---------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)


Series is

Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Zbigniew Kempczyński]

On Thu, Sep 03, 2020 at 04:31:09PM +0530, Ayaz A Siddiqui wrote:
> DRM subsystem filter in intel_gpu_top was not working due to missing
> PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
> leads to fix this issue.
> 
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> ---
>  lib/igt_device_scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 345bae76d..3583c69c7 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
>  	/* We take first one if more than one card matches filter */
>  	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
>  
> -	__copy_dev_to_card(dev, card);
> +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);
>  
>  	return true;
>  }

The only doubt I got: - is that i915 driver behavior or all
drm cards do the same?

--
Zbigniew  
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top

[Zbigniew Kempczyński]

On Thu, Sep 03, 2020 at 04:31:10PM +0530, Ayaz A Siddiqui wrote:
> intel_gpu_top is selecting first discrete device as default drm subsystem.
> In case of multi drm device if the first device is not intel gpu
> then it will lead to an error while running intel_gpu_top.
> 
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> ---
>  lib/igt_device_scan.c | 40 ++++++++++++++++++++--------------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 3583c69c7..3e183423c 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -426,6 +426,25 @@ static struct igt_device *igt_device_find(const char *subsystem,
>  	return NULL;
>  }
>  
> +static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
> +{
> +	const char *vendor_id;
> +
> +	if (!dev->vendor || !vendor)
> +		return false;
> +
> +	/* First we compare vendor id, like 8086 */
> +	if (!strcasecmp(dev->vendor, vendor))
> +		return true;
> +
> +	/* Likely we have vendor string instead of id */
> +	vendor_id = get_pci_vendor_id_by_name(vendor);
> +	if (!vendor_id)
> +		return false;
> +
> +	return !strcasecmp(dev->vendor, vendor_id);
> +}
> +
>  static void
>  __copy_dev_to_card(struct igt_device *dev, struct igt_device_card *card)
>  {
> @@ -455,7 +474,7 @@ void igt_device_find_first_i915_discrete_card(struct igt_device_card *card)
>  
>  	igt_list_for_each_entry(dev, &igt_devs.all, link) {
>  
> -		if (!is_pci_subsystem(dev))
> +		if (!is_pci_subsystem(dev) || !is_vendor_matched(dev, "intel"))
>  			continue;
>  
>  		if ((strncmp(dev->pci_slot_name, INTEGRATED_I915_GPU_PCI_ID, PCI_SLOT_NAME_SIZE)) != 0) {
> @@ -889,25 +908,6 @@ static bool parse_filter(const char *fstr, struct filter *filter)
>  	return false;
>  }
>  
> -static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
> -{
> -	const char *vendor_id;
> -
> -	if (!dev->vendor || !vendor)
> -		return false;
> -
> -	/* First we compare vendor id, like 8086 */
> -	if (!strcasecmp(dev->vendor, vendor))
> -		return true;
> -
> -	/* Likely we have vendor string instead of id */
> -	vendor_id = get_pci_vendor_id_by_name(vendor);
> -	if (!vendor_id)
> -		return false;
> -
> -	return !strcasecmp(dev->vendor, vendor_id);
> -}
> -
>  /* Filter which matches subsystem:/sys/... path.
>   * Used as first filter in chain.
>   */
> -- 

You could just add function prototype but I won't complain. 
igt_device_find_first_i915_discrete_card() is used in intel_gpu_top so it has
only meaning for card selection preference. IMO looks ok.

Reviewed-by: Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for Fix for device detection issues with intel gpu top

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 15501 bytes --]

== Series Details ==

Series: Fix for device detection issues with intel gpu top
URL   : https://patchwork.freedesktop.org/series/81286/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8957_full -> IGTPW_4949_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4949_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4949_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4949_full:

### IGT changes ###

#### Possible regressions ####

  * igt@perf@polling:
    - shard-kbl:          [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@perf@polling.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@perf@polling.html

  
Known issues
------------

  Here are the changes found in IGTPW_4949_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@preservation-s3@bcs0:
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html

  * igt@gem_exec_whisper@basic-forked:
    - shard-apl:          [PASS][5] -> [TIMEOUT][6] ([i915#1635] / [i915#1958]) +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl1/igt@gem_exec_whisper@basic-forked.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl4/igt@gem_exec_whisper@basic-forked.html
    - shard-glk:          [PASS][7] -> [TIMEOUT][8] ([i915#1958]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk3/igt@gem_exec_whisper@basic-forked.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk3/igt@gem_exec_whisper@basic-forked.html

  * igt@gem_exec_whisper@basic-queues:
    - shard-kbl:          [PASS][9] -> [TIMEOUT][10] ([i915#1958]) +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl7/igt@gem_exec_whisper@basic-queues.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl4/igt@gem_exec_whisper@basic-queues.html

  * igt@i915_module_load@reload:
    - shard-tglb:         [PASS][11] -> [DMESG-WARN][12] ([i915#1982] / [k.org#205379])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb5/igt@i915_module_load@reload.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb3/igt@i915_module_load@reload.html

  * igt@kms_big_fb@linear-64bpp-rotate-180:
    - shard-glk:          [PASS][13] -> [DMESG-FAIL][14] ([i915#118] / [i915#95])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk4/igt@kms_big_fb@linear-64bpp-rotate-180.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html

  * igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1:
    - shard-kbl:          [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl7/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html

  * igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
    - shard-glk:          [PASS][17] -> [FAIL][18] ([i915#79])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
    - shard-tglb:         [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-glk:          [PASS][21] -> [FAIL][22] ([i915#1036])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_psr@psr2_primary_render:
    - shard-iclb:         [PASS][23] -> [SKIP][24] ([fdo#109441])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb2/igt@kms_psr@psr2_primary_render.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@kms_psr@psr2_primary_render.html

  * igt@kms_vblank@pipe-c-wait-busy-hang:
    - shard-apl:          [PASS][25] -> [DMESG-WARN][26] ([i915#1635] / [i915#1982]) +3 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl7/igt@kms_vblank@pipe-c-wait-busy-hang.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl3/igt@kms_vblank@pipe-c-wait-busy-hang.html

  * igt@sysfs_timeslice_duration@timeout@vecs0:
    - shard-iclb:         [PASS][27] -> [FAIL][28] ([i915#1755])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb4/igt@sysfs_timeslice_duration@timeout@vecs0.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb1/igt@sysfs_timeslice_duration@timeout@vecs0.html
    - shard-glk:          [PASS][29] -> [FAIL][30] ([i915#1755])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk1/igt@sysfs_timeslice_duration@timeout@vecs0.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@sysfs_timeslice_duration@timeout@vecs0.html
    - shard-tglb:         [PASS][31] -> [FAIL][32] ([i915#1755])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb7/igt@sysfs_timeslice_duration@timeout@vecs0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb2/igt@sysfs_timeslice_duration@timeout@vecs0.html

  
#### Possible fixes ####

  * igt@gem_exec_reloc@basic-many-active@vecs0:
    - shard-glk:          [FAIL][33] ([i915#2389]) -> [PASS][34] +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk7/igt@gem_exec_reloc@basic-many-active@vecs0.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk4/igt@gem_exec_reloc@basic-many-active@vecs0.html

  * igt@gem_exec_whisper@basic-contexts-forked:
    - shard-apl:          [TIMEOUT][35] ([i915#1635] / [i915#1958]) -> [PASS][36] +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl7/igt@gem_exec_whisper@basic-contexts-forked.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl8/igt@gem_exec_whisper@basic-contexts-forked.html

  * igt@gem_exec_whisper@basic-forked:
    - shard-iclb:         [TIMEOUT][37] ([i915#1958]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb4/igt@gem_exec_whisper@basic-forked.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb3/igt@gem_exec_whisper@basic-forked.html

  * igt@gem_exec_whisper@basic-queues-all:
    - shard-glk:          [TIMEOUT][39] ([i915#1958]) -> [PASS][40] +3 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk9/igt@gem_exec_whisper@basic-queues-all.html

  * igt@gem_exec_whisper@basic-queues-forked:
    - shard-glk:          [DMESG-WARN][41] ([i915#118] / [i915#95]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk7/igt@gem_exec_whisper@basic-queues-forked.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@gem_exec_whisper@basic-queues-forked.html

  * igt@gem_exec_whisper@basic-queues-forked-all:
    - shard-kbl:          [TIMEOUT][43] ([i915#1958]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@gem_exec_whisper@basic-queues-forked-all.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gem_exec_whisper@basic-queues-forked-all.html

  * igt@gem_sync@basic-store-all:
    - shard-iclb:         [FAIL][45] ([i915#2356]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb8/igt@gem_sync@basic-store-all.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@gem_sync@basic-store-all.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-kbl:          [DMESG-WARN][47] ([i915#1436] / [i915#716]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@gen9_exec_parse@allowed-all.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gen9_exec_parse@allowed-all.html

  * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
    - shard-glk:          [FAIL][49] ([i915#72]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk5/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk7/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +5 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
    - shard-apl:          [DMESG-WARN][53] ([i915#1635] / [i915#1982]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-kbl:          [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render:
    - shard-tglb:         [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][59] ([fdo#109441]) -> [PASS][60] +1 similar issue
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][61] ([i915#1635] / [i915#31]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl1/igt@kms_setmode@basic.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl8/igt@kms_setmode@basic.html

  * igt@perf_pmu@module-unload:
    - shard-iclb:         [DMESG-WARN][63] ([i915#1982]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb3/igt@perf_pmu@module-unload.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@perf_pmu@module-unload.html

  
#### Warnings ####

  * igt@kms_content_protection@lic:
    - shard-apl:          [TIMEOUT][65] ([i915#1319] / [i915#1635] / [i915#1958]) -> [FAIL][66] ([fdo#110321] / [i915#1635])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl6/igt@kms_content_protection@lic.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl6/igt@kms_content_protection@lic.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-tglb:         [DMESG-WARN][67] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][68] ([i915#2411])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-suspend.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
  [i915#1036]: https://gitlab.freedesktop.org/drm/intel/issues/1036
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2356]: https://gitlab.freedesktop.org/drm/intel/issues/2356
  [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
  [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
  [k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379


Participating hosts (10 -> 8)
------------------------------

  Missing    (2): pig-skl-6260u pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5777 -> IGTPW_4949
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_8957: c3355f060f0d6b1c45f456c4cdb995edfd496603 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4949: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html
  IGT_5777: c240b5c00d58860e376b012cc3c883c17ae63f37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html

[-- Attachment #1.2: Type: text/html, Size: 18814 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for Fix for device detection issues with intel gpu top

[Siddiqui, Ayaz A]

[-- Attachment #1.1: Type: text/plain, Size: 15855 bytes --]



From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Friday, September 4, 2020 1:21 AM
To: Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: ✗ Fi.CI.IGT: failure for Fix for device detection issues with intel gpu top

Patch Details
Series:

Fix for device detection issues with intel gpu top

URL:

https://patchwork.freedesktop.org/series/81286/

State:

failure

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html

CI Bug Log - changes from CI_DRM_8957_full -> IGTPW_4949_full
Summary

FAILURE

Serious unknown changes coming with IGTPW_4949_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4949_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html

Possible new issues

Here are the unknown changes that may have been introduced in IGTPW_4949_full:

IGT changes
Possible regressions

  *   igt@perf@polling:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@perf@polling.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@perf@polling.html>
This regression seems to me false positive as the change is related to intel_gpu_tool
-Ayaz
Known issues

Here are the changes found in IGTPW_4949_full that come from known issues:

IGT changes
Issues hit

  *   igt@gem_ctx_isolation@preservation-s3@bcs0:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) +3 similar issues

  *   igt@gem_exec_whisper@basic-forked:

     *   shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl1/igt@gem_exec_whisper@basic-forked.html> -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl4/igt@gem_exec_whisper@basic-forked.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) +2 similar issues
     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk3/igt@gem_exec_whisper@basic-forked.html> -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk3/igt@gem_exec_whisper@basic-forked.html> (i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) +1 similar issue

  *   igt@gem_exec_whisper@basic-queues:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl7/igt@gem_exec_whisper@basic-queues.html> -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl4/igt@gem_exec_whisper@basic-queues.html> (i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) +3 similar issues

  *   igt@i915_module_load@reload:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb5/igt@i915_module_load@reload.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb3/igt@i915_module_load@reload.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982> / k.org#205379<https://bugzilla.kernel.org/show_bug.cgi?id=205379>)

  *   igt@kms_big_fb@linear-64bpp-rotate-180:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk4/igt@kms_big_fb@linear-64bpp-rotate-180.html> -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html> (i915#118<https://gitlab.freedesktop.org/drm/intel/issues/118> / i915#95<https://gitlab.freedesktop.org/drm/intel/issues/95>)

  *   igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl7/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)

  *   igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html> (i915#79<https://gitlab.freedesktop.org/drm/intel/issues/79>)

  *   igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)

  *   igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html> (i915#1036<https://gitlab.freedesktop.org/drm/intel/issues/1036>)

  *   igt@kms_psr@psr2_primary_render:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb2/igt@kms_psr@psr2_primary_render.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@kms_psr@psr2_primary_render.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>)

  *   igt@kms_vblank@pipe-c-wait-busy-hang:

     *   shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl7/igt@kms_vblank@pipe-c-wait-busy-hang.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl3/igt@kms_vblank@pipe-c-wait-busy-hang.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) +3 similar issues

  *   igt@sysfs_timeslice_duration@timeout@vecs0:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb4/igt@sysfs_timeslice_duration@timeout@vecs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb1/igt@sysfs_timeslice_duration@timeout@vecs0.html> (i915#1755<https://gitlab.freedesktop.org/drm/intel/issues/1755>)
     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk1/igt@sysfs_timeslice_duration@timeout@vecs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@sysfs_timeslice_duration@timeout@vecs0.html> (i915#1755<https://gitlab.freedesktop.org/drm/intel/issues/1755>)
     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb7/igt@sysfs_timeslice_duration@timeout@vecs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb2/igt@sysfs_timeslice_duration@timeout@vecs0.html> (i915#1755<https://gitlab.freedesktop.org/drm/intel/issues/1755>)

Possible fixes

  *   igt@gem_exec_reloc@basic-many-active@vecs0:

     *   shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk7/igt@gem_exec_reloc@basic-many-active@vecs0.html> (i915#2389<https://gitlab.freedesktop.org/drm/intel/issues/2389>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk4/igt@gem_exec_reloc@basic-many-active@vecs0.html> +2 similar issues

  *   igt@gem_exec_whisper@basic-contexts-forked:

     *   shard-apl: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl7/igt@gem_exec_whisper@basic-contexts-forked.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl8/igt@gem_exec_whisper@basic-contexts-forked.html> +1 similar issue

  *   igt@gem_exec_whisper@basic-forked:

     *   shard-iclb: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb4/igt@gem_exec_whisper@basic-forked.html> (i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb3/igt@gem_exec_whisper@basic-forked.html>

  *   igt@gem_exec_whisper@basic-queues-all:

     *   shard-glk: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html> (i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk9/igt@gem_exec_whisper@basic-queues-all.html> +3 similar issues

  *   igt@gem_exec_whisper@basic-queues-forked:

     *   shard-glk: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk7/igt@gem_exec_whisper@basic-queues-forked.html> (i915#118<https://gitlab.freedesktop.org/drm/intel/issues/118> / i915#95<https://gitlab.freedesktop.org/drm/intel/issues/95>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@gem_exec_whisper@basic-queues-forked.html>

  *   igt@gem_exec_whisper@basic-queues-forked-all:

     *   shard-kbl: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@gem_exec_whisper@basic-queues-forked-all.html> (i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gem_exec_whisper@basic-queues-forked-all.html>

  *   igt@gem_sync@basic-store-all:

     *   shard-iclb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb8/igt@gem_sync@basic-store-all.html> (i915#2356<https://gitlab.freedesktop.org/drm/intel/issues/2356>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@gem_sync@basic-store-all.html>

  *   igt@gen9_exec_parse@allowed-all:

     *   shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@gen9_exec_parse@allowed-all.html> (i915#1436<https://gitlab.freedesktop.org/drm/intel/issues/1436> / i915#716<https://gitlab.freedesktop.org/drm/intel/issues/716>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gen9_exec_parse@allowed-all.html>

  *   igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:

     *   shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk5/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html> (i915#72<https://gitlab.freedesktop.org/drm/intel/issues/72>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk7/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html>

  *   igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:

     *   shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html> +5 similar issues

  *   igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:

     *   shard-apl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html>

  *   igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:

     *   shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html> +1 similar issue

  *   igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render:

     *   shard-tglb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html>

  *   igt@kms_psr@psr2_cursor_render:

     *   shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb7/igt@kms_psr@psr2_cursor_render.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb2/igt@kms_psr@psr2_cursor_render.html> +1 similar issue

  *   igt@kms_setmode@basic:

     *   shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl1/igt@kms_setmode@basic.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#31<https://gitlab.freedesktop.org/drm/intel/issues/31>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl8/igt@kms_setmode@basic.html>

  *   igt@perf_pmu@module-unload:

     *   shard-iclb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb3/igt@perf_pmu@module-unload.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@perf_pmu@module-unload.html>

Warnings

  *   igt@kms_content_protection@lic:

     *   shard-apl: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl6/igt@kms_content_protection@lic.html> (i915#1319<https://gitlab.freedesktop.org/drm/intel/issues/1319> / i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#1958<https://gitlab.freedesktop.org/drm/intel/issues/1958>) -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl6/igt@kms_content_protection@lic.html> (fdo#110321<https://bugs.freedesktop.org/show_bug.cgi?id=110321> / i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635>)

  *   igt@kms_frontbuffer_tracking@fbc-suspend:

     *   shard-tglb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-suspend.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982> / i915#2411<https://gitlab.freedesktop.org/drm/intel/issues/2411>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-suspend.html> (i915#2411<https://gitlab.freedesktop.org/drm/intel/issues/2411>)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (10 -> 8)

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes

  *   CI: CI-20190529 -> None
  *   IGT: IGT_5777 -> IGTPW_4949
  *   Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_8957: c3355f060f0d6b1c45f456c4cdb995edfd496603 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4949: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html
IGT_5777: c240b5c00d58860e376b012cc3c883c17ae63f37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

[-- Attachment #1.2: Type: text/html, Size: 41219 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Siddiqui, Ayaz A]

> -----Original Message-----
> From: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Sent: Thursday, September 3, 2020 5:24 PM
> To: Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device
> selection filter
> 
> On Thu, Sep 03, 2020 at 04:31:09PM +0530, Ayaz A Siddiqui wrote:
> > DRM subsystem filter in intel_gpu_top was not working due to missing
> > PCI_SLOT_NAME property. Using the parent device in case of drm
> > subsystem leads to fix this issue.
> >
> > Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> > ---
> >  lib/igt_device_scan.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c index
> > 345bae76d..3583c69c7 100644
> > --- a/lib/igt_device_scan.c
> > +++ b/lib/igt_device_scan.c
> > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter,
> struct igt_device_card *card)
> >  	/* We take first one if more than one card matches filter */
> >  	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
> >
> > -	__copy_dev_to_card(dev, card);
> > +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent,
> card);
> >
> >  	return true;
> >  }
> 
> The only doubt I got: - is that i915 driver behavior or all drm cards do the
> same?
I haven't check and In case of other drm card we may not have pmu also.
Regards
-Ayaz
 
> 
> --
> Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for Fix for device detection issues with intel gpu top

[Petri Latvala]

On Fri, Sep 04, 2020 at 06:03:06AM +0000, Siddiqui, Ayaz A wrote:
> 
> 
> From: Patchwork <patchwork@emeril.freedesktop.org>
> Sent: Friday, September 4, 2020 1:21 AM
> To: Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: ✗ Fi.CI.IGT: failure for Fix for device detection issues with intel gpu top
> 
> Patch Details
> Series:
> 
> Fix for device detection issues with intel gpu top
> 
> URL:
> 
> https://patchwork.freedesktop.org/series/81286/
> 
> State:
> 
> failure
> 
> Details:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html
> 
> CI Bug Log - changes from CI_DRM_8957_full -> IGTPW_4949_full
> Summary
> 
> FAILURE
> 
> Serious unknown changes coming with IGTPW_4949_full absolutely need to be
> verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in IGTPW_4949_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> 
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html
> 
> Possible new issues
> 
> Here are the unknown changes that may have been introduced in IGTPW_4949_full:
> 
> IGT changes
> Possible regressions
> 
>   *   igt@perf@polling:
> 
>      *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@perf@polling.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@perf@polling.html>
> This regression seems to me false positive as the change is related to intel_gpu_tool
> -Ayaz


Yep. Lakshmi, see above.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Fix for device detection issues with intel gpu top

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 15101 bytes --]

== Series Details ==

Series: Fix for device detection issues with intel gpu top
URL   : https://patchwork.freedesktop.org/series/81286/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8957_full -> IGTPW_4949_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html

Known issues
------------

  Here are the changes found in IGTPW_4949_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@preservation-s3@bcs0:
    - shard-kbl:          [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html

  * igt@gem_exec_whisper@basic-forked:
    - shard-apl:          [PASS][3] -> [TIMEOUT][4] ([i915#1635] / [i915#1958]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl1/igt@gem_exec_whisper@basic-forked.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl4/igt@gem_exec_whisper@basic-forked.html
    - shard-glk:          [PASS][5] -> [TIMEOUT][6] ([i915#1958]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk3/igt@gem_exec_whisper@basic-forked.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk3/igt@gem_exec_whisper@basic-forked.html

  * igt@gem_exec_whisper@basic-queues:
    - shard-kbl:          [PASS][7] -> [TIMEOUT][8] ([i915#1958]) +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl7/igt@gem_exec_whisper@basic-queues.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl4/igt@gem_exec_whisper@basic-queues.html

  * igt@i915_module_load@reload:
    - shard-tglb:         [PASS][9] -> [DMESG-WARN][10] ([i915#1982] / [k.org#205379])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb5/igt@i915_module_load@reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb3/igt@i915_module_load@reload.html

  * igt@kms_big_fb@linear-64bpp-rotate-180:
    - shard-glk:          [PASS][11] -> [DMESG-FAIL][12] ([i915#118] / [i915#95])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk4/igt@kms_big_fb@linear-64bpp-rotate-180.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html

  * igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1:
    - shard-kbl:          [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl7/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html

  * igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
    - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#79])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
    - shard-tglb:         [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#1036])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_psr@psr2_primary_render:
    - shard-iclb:         [PASS][21] -> [SKIP][22] ([fdo#109441])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb2/igt@kms_psr@psr2_primary_render.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@kms_psr@psr2_primary_render.html

  * igt@kms_vblank@pipe-c-wait-busy-hang:
    - shard-apl:          [PASS][23] -> [DMESG-WARN][24] ([i915#1635] / [i915#1982]) +3 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl7/igt@kms_vblank@pipe-c-wait-busy-hang.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl3/igt@kms_vblank@pipe-c-wait-busy-hang.html

  * igt@perf@polling:
    - shard-kbl:          [PASS][25] -> [INCOMPLETE][26] ([CI#80])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@perf@polling.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@perf@polling.html

  * igt@sysfs_timeslice_duration@timeout@vecs0:
    - shard-iclb:         [PASS][27] -> [FAIL][28] ([i915#1755])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb4/igt@sysfs_timeslice_duration@timeout@vecs0.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb1/igt@sysfs_timeslice_duration@timeout@vecs0.html
    - shard-glk:          [PASS][29] -> [FAIL][30] ([i915#1755])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk1/igt@sysfs_timeslice_duration@timeout@vecs0.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@sysfs_timeslice_duration@timeout@vecs0.html
    - shard-tglb:         [PASS][31] -> [FAIL][32] ([i915#1755])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb7/igt@sysfs_timeslice_duration@timeout@vecs0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb2/igt@sysfs_timeslice_duration@timeout@vecs0.html

  
#### Possible fixes ####

  * igt@gem_exec_reloc@basic-many-active@vecs0:
    - shard-glk:          [FAIL][33] ([i915#2389]) -> [PASS][34] +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk7/igt@gem_exec_reloc@basic-many-active@vecs0.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk4/igt@gem_exec_reloc@basic-many-active@vecs0.html

  * igt@gem_exec_whisper@basic-contexts-forked:
    - shard-apl:          [TIMEOUT][35] ([i915#1635] / [i915#1958]) -> [PASS][36] +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl7/igt@gem_exec_whisper@basic-contexts-forked.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl8/igt@gem_exec_whisper@basic-contexts-forked.html

  * igt@gem_exec_whisper@basic-forked:
    - shard-iclb:         [TIMEOUT][37] ([i915#1958]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb4/igt@gem_exec_whisper@basic-forked.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb3/igt@gem_exec_whisper@basic-forked.html

  * igt@gem_exec_whisper@basic-queues-all:
    - shard-glk:          [TIMEOUT][39] ([i915#1958]) -> [PASS][40] +3 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk9/igt@gem_exec_whisper@basic-queues-all.html

  * igt@gem_exec_whisper@basic-queues-forked:
    - shard-glk:          [DMESG-WARN][41] ([i915#118] / [i915#95]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk7/igt@gem_exec_whisper@basic-queues-forked.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk8/igt@gem_exec_whisper@basic-queues-forked.html

  * igt@gem_exec_whisper@basic-queues-forked-all:
    - shard-kbl:          [TIMEOUT][43] ([i915#1958]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@gem_exec_whisper@basic-queues-forked-all.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gem_exec_whisper@basic-queues-forked-all.html

  * igt@gem_sync@basic-store-all:
    - shard-iclb:         [FAIL][45] ([i915#2356]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb8/igt@gem_sync@basic-store-all.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@gem_sync@basic-store-all.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-kbl:          [DMESG-WARN][47] ([i915#1436] / [i915#716]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@gen9_exec_parse@allowed-all.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@gen9_exec_parse@allowed-all.html

  * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
    - shard-glk:          [FAIL][49] ([i915#72]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-glk5/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-glk7/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +5 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
    - shard-apl:          [DMESG-WARN][53] ([i915#1635] / [i915#1982]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-kbl:          [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render:
    - shard-tglb:         [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][59] ([fdo#109441]) -> [PASS][60] +1 similar issue
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][61] ([i915#1635] / [i915#31]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl1/igt@kms_setmode@basic.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl8/igt@kms_setmode@basic.html

  * igt@perf_pmu@module-unload:
    - shard-iclb:         [DMESG-WARN][63] ([i915#1982]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-iclb3/igt@perf_pmu@module-unload.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-iclb6/igt@perf_pmu@module-unload.html

  
#### Warnings ####

  * igt@kms_content_protection@lic:
    - shard-apl:          [TIMEOUT][65] ([i915#1319] / [i915#1635] / [i915#1958]) -> [FAIL][66] ([fdo#110321] / [i915#1635])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-apl6/igt@kms_content_protection@lic.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-apl6/igt@kms_content_protection@lic.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-tglb:         [DMESG-WARN][67] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][68] ([i915#2411])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-suspend.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
  [i915#1036]: https://gitlab.freedesktop.org/drm/intel/issues/1036
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2356]: https://gitlab.freedesktop.org/drm/intel/issues/2356
  [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
  [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
  [k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379


Participating hosts (10 -> 8)
------------------------------

  Missing    (2): pig-skl-6260u pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5777 -> IGTPW_4949
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_8957: c3355f060f0d6b1c45f456c4cdb995edfd496603 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4949: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html
  IGT_5777: c240b5c00d58860e376b012cc3c883c17ae63f37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html

[-- Attachment #1.2: Type: text/html, Size: 18406 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for Fix for device detection issues with intel gpu top

[Vudum, Lakshminarayana]

Re-reported.

-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Friday, September 4, 2020 1:55 AM
To: Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] ✗ Fi.CI.IGT: failure for Fix for device detection issues with intel gpu top

On Fri, Sep 04, 2020 at 06:03:06AM +0000, Siddiqui, Ayaz A wrote:
> 
> 
> From: Patchwork <patchwork@emeril.freedesktop.org>
> Sent: Friday, September 4, 2020 1:21 AM
> To: Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: ✗ Fi.CI.IGT: failure for Fix for device detection issues with 
> intel gpu top
> 
> Patch Details
> Series:
> 
> Fix for device detection issues with intel gpu top
> 
> URL:
> 
> https://patchwork.freedesktop.org/series/81286/
> 
> State:
> 
> failure
> 
> Details:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html
> 
> CI Bug Log - changes from CI_DRM_8957_full -> IGTPW_4949_full Summary
> 
> FAILURE
> 
> Serious unknown changes coming with IGTPW_4949_full absolutely need to 
> be verified manually.
> 
> If you think the reported changes have nothing to do with the changes 
> introduced in IGTPW_4949_full, please notify your bug team to allow 
> them to document this new failure mode, which will reduce false positives in CI.
> 
> External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/index.html
> 
> Possible new issues
> 
> Here are the unknown changes that may have been introduced in IGTPW_4949_full:
> 
> IGT changes
> Possible regressions
> 
>   *   igt@perf@polling:
> 
>      *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8957/shard-kbl4/igt@perf@polling.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4949/shard-kbl1/igt@perf@polling.html>
> This regression seems to me false positive as the change is related to 
> intel_gpu_tool -Ayaz


Yep. Lakshmi, see above.


--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Petri Latvala]

On Fri, Sep 04, 2020 at 07:31:46AM +0000, Siddiqui, Ayaz A wrote:
> 
> 
> > -----Original Message-----
> > From: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > Sent: Thursday, September 3, 2020 5:24 PM
> > To: Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
> > Cc: igt-dev@lists.freedesktop.org
> > Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device
> > selection filter
> > 
> > On Thu, Sep 03, 2020 at 04:31:09PM +0530, Ayaz A Siddiqui wrote:
> > > DRM subsystem filter in intel_gpu_top was not working due to missing
> > > PCI_SLOT_NAME property. Using the parent device in case of drm
> > > subsystem leads to fix this issue.
> > >
> > > Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> > > ---
> > >  lib/igt_device_scan.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c index
> > > 345bae76d..3583c69c7 100644
> > > --- a/lib/igt_device_scan.c
> > > +++ b/lib/igt_device_scan.c
> > > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter,
> > struct igt_device_card *card)
> > >  	/* We take first one if more than one card matches filter */
> > >  	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
> > >
> > > -	__copy_dev_to_card(dev, card);
> > > +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent,
> > card);
> > >
> > >  	return true;
> > >  }
> > 
> > The only doubt I got: - is that i915 driver behavior or all drm cards do the
> > same?
> I haven't check and In case of other drm card we may not have pmu also.

For intel_gpu_top we naturally don't worry about other devices but
this change affects everyone. Please check and verify this.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Dixit, Ashutosh]

On Thu, 03 Sep 2020 04:01:09 -0700, Ayaz A Siddiqui wrote:
>
> DRM subsystem filter in intel_gpu_top was not working due to missing
> PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
> leads to fix this issue.
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> ---
>  lib/igt_device_scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 345bae76d..3583c69c7 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
>	/* We take first one if more than one card matches filter */
>	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
>
> -	__copy_dev_to_card(dev, card);
> +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);

Also I am wondering if this is required for only drm system then should
this line be:

        __copy_dev_to_card(is_drm_subsystem(dev) ? dev->parent : dev, card)

Also does lsgpu (the only other caller of igt_device_card_match()) work
with this change?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Dixit, Ashutosh]

On Thu, 03 Sep 2020 04:54:09 -0700, Zbigniew Kempczyński wrote:
>
> On Thu, Sep 03, 2020 at 04:31:09PM +0530, Ayaz A Siddiqui wrote:
> > DRM subsystem filter in intel_gpu_top was not working due to missing
> > PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
> > leads to fix this issue.
> >
> > Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> > ---
> >  lib/igt_device_scan.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> > index 345bae76d..3583c69c7 100644
> > --- a/lib/igt_device_scan.c
> > +++ b/lib/igt_device_scan.c
> > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
> >	/* We take first one if more than one card matches filter */
> >	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
> >
> > -	__copy_dev_to_card(dev, card);
> > +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);
> >
> >	return true;
> >  }
>
> The only doubt I got: - is that i915 driver behavior or all drm cards do
> the same?

I am not entirely sure but I will be very surprised if this is i915 driver
behavior. I'd think this is a property of the drm subsystem.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Zbigniew Kempczyński]

On Mon, Sep 28, 2020 at 01:53:35PM -0700, Dixit, Ashutosh wrote:
> On Thu, 03 Sep 2020 04:01:09 -0700, Ayaz A Siddiqui wrote:
> >
> > DRM subsystem filter in intel_gpu_top was not working due to missing
> > PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
> > leads to fix this issue.
> >
> > Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> > ---
> >  lib/igt_device_scan.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> > index 345bae76d..3583c69c7 100644
> > --- a/lib/igt_device_scan.c
> > +++ b/lib/igt_device_scan.c
> > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
> >	/* We take first one if more than one card matches filter */
> >	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
> >
> > -	__copy_dev_to_card(dev, card);
> > +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);
> 
> Also I am wondering if this is required for only drm system then should
> this line be:
> 
>         __copy_dev_to_card(is_drm_subsystem(dev) ? dev->parent : dev, card)
> 
> Also does lsgpu (the only other caller of igt_device_card_match()) work
> with this change?

It is better than with previous patch but after playing with there's
still something I'm not happy with. It is - you're using drm:/path/...
filter to select exact drm device but you got its parent. Returned
card structure will contain "pci" as subsystem string instead of "drm".
This can be confusing but solves the problem accessing to pci slot name
with drm: filter only.

--
Zbigniew

> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Zbigniew Kempczyński]

On Mon, Sep 28, 2020 at 02:13:26PM -0700, Dixit, Ashutosh wrote:
> On Thu, 03 Sep 2020 04:54:09 -0700, Zbigniew Kempczyński wrote:
> >
> > On Thu, Sep 03, 2020 at 04:31:09PM +0530, Ayaz A Siddiqui wrote:
> > > DRM subsystem filter in intel_gpu_top was not working due to missing
> > > PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
> > > leads to fix this issue.
> > >
> > > Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> > > ---
> > >  lib/igt_device_scan.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> > > index 345bae76d..3583c69c7 100644
> > > --- a/lib/igt_device_scan.c
> > > +++ b/lib/igt_device_scan.c
> > > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
> > >	/* We take first one if more than one card matches filter */
> > >	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
> > >
> > > -	__copy_dev_to_card(dev, card);
> > > +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);
> > >
> > >	return true;
> > >  }
> >
> > The only doubt I got: - is that i915 driver behavior or all drm cards do
> > the same?
> 
> I am not entirely sure but I will be very surprised if this is i915 driver
> behavior. I'd think this is a property of the drm subsystem.

Likely you're right, I've check on another vendor and it looks same. 
But is_pci_subsystem(dev) can be wrong on !pci devices. Perhaps it not 
the case now but for other filter for platform devices it likely be
wrong.

--
Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev