* [PATCH] configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
@ 2020-09-03 0:02 Chris Packham
2020-09-03 12:16 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Chris Packham @ 2020-09-03 0:02 UTC (permalink / raw)
To: u-boot
Setting CONFIG_ENV_ADDR to something other than 0 stops gd->env_addr
from being allocated dynamically. When the environment is in SPI we need
it to be allocated as we can't use a direct memory mapped address.
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
configs/T2080RDB_SPIFLASH_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/T2080RDB_SPIFLASH_defconfig b/configs/T2080RDB_SPIFLASH_defconfig
index 62cbab1f0734..ba4ac1010502 100644
--- a/configs/T2080RDB_SPIFLASH_defconfig
+++ b/configs/T2080RDB_SPIFLASH_defconfig
@@ -50,7 +50,6 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9
CONFIG_OF_CONTROL=y
CONFIG_ENV_OVERWRITE=y
CONFIG_ENV_IS_IN_SPI_FLASH=y
-CONFIG_ENV_ADDR=0xFFFC9000
CONFIG_DM=y
CONFIG_FSL_CAAM=y
CONFIG_DM_I2C=y
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
2020-09-03 0:02 [PATCH] configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH Chris Packham
@ 2020-09-03 12:16 ` Tom Rini
2020-09-04 6:01 ` Chris Packham
0 siblings, 1 reply; 4+ messages in thread
From: Tom Rini @ 2020-09-03 12:16 UTC (permalink / raw)
To: u-boot
On Thu, Sep 03, 2020 at 12:02:06PM +1200, Chris Packham wrote:
> Setting CONFIG_ENV_ADDR to something other than 0 stops gd->env_addr
> from being allocated dynamically. When the environment is in SPI we need
> it to be allocated as we can't use a direct memory mapped address.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
>
> configs/T2080RDB_SPIFLASH_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configs/T2080RDB_SPIFLASH_defconfig b/configs/T2080RDB_SPIFLASH_defconfig
> index 62cbab1f0734..ba4ac1010502 100644
> --- a/configs/T2080RDB_SPIFLASH_defconfig
> +++ b/configs/T2080RDB_SPIFLASH_defconfig
> @@ -50,7 +50,6 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9
> CONFIG_OF_CONTROL=y
> CONFIG_ENV_OVERWRITE=y
> CONFIG_ENV_IS_IN_SPI_FLASH=y
> -CONFIG_ENV_ADDR=0xFFFC9000
> CONFIG_DM=y
> CONFIG_FSL_CAAM=y
> CONFIG_DM_I2C=y
Thanks for figuring that out. There's a handful of _SPIFLASH defconfigs
that do the exact same thing, from the same conversion (I probably did
it) to defconfig. It's likely that they're all wrong, yes?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200903/13608e79/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
2020-09-03 12:16 ` Tom Rini
@ 2020-09-04 6:01 ` Chris Packham
2020-09-04 11:49 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Chris Packham @ 2020-09-04 6:01 UTC (permalink / raw)
To: u-boot
On Fri, 4 Sep 2020, 12:16 AM Tom Rini, <trini@konsulko.com> wrote:
> On Thu, Sep 03, 2020 at 12:02:06PM +1200, Chris Packham wrote:
>
> > Setting CONFIG_ENV_ADDR to something other than 0 stops gd->env_addr
> > from being allocated dynamically. When the environment is in SPI we need
> > it to be allocated as we can't use a direct memory mapped address.
> >
> > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> > ---
> >
> > configs/T2080RDB_SPIFLASH_defconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/configs/T2080RDB_SPIFLASH_defconfig
> b/configs/T2080RDB_SPIFLASH_defconfig
> > index 62cbab1f0734..ba4ac1010502 100644
> > --- a/configs/T2080RDB_SPIFLASH_defconfig
> > +++ b/configs/T2080RDB_SPIFLASH_defconfig
> > @@ -50,7 +50,6 @@
> CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9
> > CONFIG_OF_CONTROL=y
> > CONFIG_ENV_OVERWRITE=y
> > CONFIG_ENV_IS_IN_SPI_FLASH=y
> > -CONFIG_ENV_ADDR=0xFFFC9000
> > CONFIG_DM=y
> > CONFIG_FSL_CAAM=y
> > CONFIG_DM_I2C=y
>
> Thanks for figuring that out. There's a handful of _SPIFLASH defconfigs
> that do the exact same thing, from the same conversion (I probably did
> it) to defconfig. It's likely that they're all wrong, yes?
>
More than likely yes. I've only got a T2080RDB to test with but I can whip
up a patch to make the same change to the other affected defconfigs.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
2020-09-04 6:01 ` Chris Packham
@ 2020-09-04 11:49 ` Tom Rini
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2020-09-04 11:49 UTC (permalink / raw)
To: u-boot
On Fri, Sep 04, 2020 at 06:01:44PM +1200, Chris Packham wrote:
> On Fri, 4 Sep 2020, 12:16 AM Tom Rini, <trini@konsulko.com> wrote:
>
> > On Thu, Sep 03, 2020 at 12:02:06PM +1200, Chris Packham wrote:
> >
> > > Setting CONFIG_ENV_ADDR to something other than 0 stops gd->env_addr
> > > from being allocated dynamically. When the environment is in SPI we need
> > > it to be allocated as we can't use a direct memory mapped address.
> > >
> > > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> > > ---
> > >
> > > configs/T2080RDB_SPIFLASH_defconfig | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/configs/T2080RDB_SPIFLASH_defconfig
> > b/configs/T2080RDB_SPIFLASH_defconfig
> > > index 62cbab1f0734..ba4ac1010502 100644
> > > --- a/configs/T2080RDB_SPIFLASH_defconfig
> > > +++ b/configs/T2080RDB_SPIFLASH_defconfig
> > > @@ -50,7 +50,6 @@
> > CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9
> > > CONFIG_OF_CONTROL=y
> > > CONFIG_ENV_OVERWRITE=y
> > > CONFIG_ENV_IS_IN_SPI_FLASH=y
> > > -CONFIG_ENV_ADDR=0xFFFC9000
> > > CONFIG_DM=y
> > > CONFIG_FSL_CAAM=y
> > > CONFIG_DM_I2C=y
> >
> > Thanks for figuring that out. There's a handful of _SPIFLASH defconfigs
> > that do the exact same thing, from the same conversion (I probably did
> > it) to defconfig. It's likely that they're all wrong, yes?
> >
>
> More than likely yes. I've only got a T2080RDB to test with but I can whip
> up a patch to make the same change to the other affected defconfigs.
Please do, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200904/7a0f7fb4/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-04 11:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 0:02 [PATCH] configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH Chris Packham
2020-09-03 12:16 ` Tom Rini
2020-09-04 6:01 ` Chris Packham
2020-09-04 11:49 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.