* [v2 2/2] media: platform: vpdma.c: fix comparison to bool
@ 2020-09-03 13:13 Daniel W. S. Almeida
0 siblings, 0 replies; only message in thread
From: Daniel W. S. Almeida @ 2020-09-03 13:13 UTC (permalink / raw)
To: Benoit Parrot
Cc: Daniel W. S. Almeida, Mauro Carvalho Chehab, linux-media, linux-kernel
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Fix the following coccinelle report:
drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
Comparison to bool
Found using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
drivers/media/platform/ti-vpe/vpdma.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
index 2e5148ae7a0f..5893917ce50d 100644
--- a/drivers/media/platform/ti-vpe/vpdma.c
+++ b/drivers/media/platform/ti-vpe/vpdma.c
@@ -942,14 +942,13 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
unsigned long flags;
spin_lock_irqsave(&vpdma->lock, flags);
- for (i = 0; i < VPDMA_MAX_NUM_LIST &&
- vpdma->hwlist_used[i] == true; i++)
- ;
-
- if (i < VPDMA_MAX_NUM_LIST) {
+ for (i = 0; i < VPDMA_MAX_NUM_LIST; i++) {
+ if (vpdma->hwlist_used[i])
+ continue;
list_num = i;
vpdma->hwlist_used[i] = true;
vpdma->hwlist_priv[i] = priv;
+ break;
}
spin_unlock_irqrestore(&vpdma->lock, flags);
--
2.28.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-03 13:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 13:13 [v2 2/2] media: platform: vpdma.c: fix comparison to bool Daniel W. S. Almeida
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.