* [PATCH v2] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset
@ 2020-09-03 14:54 ` Corentin Labbe
0 siblings, 0 replies; 4+ messages in thread
From: Corentin Labbe @ 2020-09-03 14:54 UTC (permalink / raw)
To: davem, herbert, mripard, robh+dt, robh, wens
Cc: devicetree, linux-arm-kernel, linux-crypto, linux-kernel,
linux-sunxi, m.cerveny, Corentin Labbe
When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset.
Furthermore, there are no need to use items to list only one compatible
in compatible list.
Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
Change since v1:
- use an enum for adding allwinner,sun8i-a33-crypto to "reset list"
.../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
index fc823572bcff..279f4a2e1dd7 100644
--- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
+++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
@@ -23,8 +23,7 @@ properties:
- items:
- const: allwinner,sun7i-a20-crypto
- const: allwinner,sun4i-a10-crypto
- - items:
- - const: allwinner,sun8i-a33-crypto
+ - const: allwinner,sun8i-a33-crypto
reg:
maxItems: 1
@@ -59,7 +58,9 @@ if:
properties:
compatible:
contains:
- const: allwinner,sun6i-a31-crypto
+ enum:
+ - const: allwinner,sun6i-a31-crypto
+ - const: allwinner,sun8i-a33-crypto
then:
required:
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] dt-bindings: crypto: Specify that allwinner, sun8i-a33-crypto needs reset
@ 2020-09-03 14:54 ` Corentin Labbe
0 siblings, 0 replies; 4+ messages in thread
From: Corentin Labbe @ 2020-09-03 14:54 UTC (permalink / raw)
To: davem, herbert, mripard, robh+dt, robh, wens
Cc: devicetree, linux-kernel, linux-sunxi, Corentin Labbe,
linux-crypto, m.cerveny, linux-arm-kernel
When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset.
Furthermore, there are no need to use items to list only one compatible
in compatible list.
Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
Change since v1:
- use an enum for adding allwinner,sun8i-a33-crypto to "reset list"
.../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
index fc823572bcff..279f4a2e1dd7 100644
--- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
+++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
@@ -23,8 +23,7 @@ properties:
- items:
- const: allwinner,sun7i-a20-crypto
- const: allwinner,sun4i-a10-crypto
- - items:
- - const: allwinner,sun8i-a33-crypto
+ - const: allwinner,sun8i-a33-crypto
reg:
maxItems: 1
@@ -59,7 +58,9 @@ if:
properties:
compatible:
contains:
- const: allwinner,sun6i-a31-crypto
+ enum:
+ - const: allwinner,sun6i-a31-crypto
+ - const: allwinner,sun8i-a33-crypto
then:
required:
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset
2020-09-03 14:54 ` [PATCH v2] dt-bindings: crypto: Specify that allwinner, sun8i-a33-crypto " Corentin Labbe
@ 2020-09-04 9:15 ` Maxime Ripard
-1 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2020-09-04 9:15 UTC (permalink / raw)
To: Corentin Labbe
Cc: davem, herbert, robh+dt, robh, wens, devicetree,
linux-arm-kernel, linux-crypto, linux-kernel, linux-sunxi,
m.cerveny
[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]
On Thu, Sep 03, 2020 at 04:54:45PM +0200, Corentin Labbe wrote:
> When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset.
> Furthermore, there are no need to use items to list only one compatible
> in compatible list.
>
> Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> Change since v1:
> - use an enum for adding allwinner,sun8i-a33-crypto to "reset list"
>
> .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> index fc823572bcff..279f4a2e1dd7 100644
> --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> @@ -23,8 +23,7 @@ properties:
> - items:
> - const: allwinner,sun7i-a20-crypto
> - const: allwinner,sun4i-a10-crypto
> - - items:
> - - const: allwinner,sun8i-a33-crypto
> + - const: allwinner,sun8i-a33-crypto
>
> reg:
> maxItems: 1
> @@ -59,7 +58,9 @@ if:
> properties:
> compatible:
> contains:
> - const: allwinner,sun6i-a31-crypto
> + enum:
> + - const: allwinner,sun6i-a31-crypto
> + - const: allwinner,sun8i-a33-crypto
That's not the proper syntax for an enum, this would be
> + enum:
> + - allwinner,sun6i-a31-crypto
> + - allwinner,sun8i-a33-crypto
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset
@ 2020-09-04 9:15 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2020-09-04 9:15 UTC (permalink / raw)
To: Corentin Labbe
Cc: robh, herbert, devicetree, linux-sunxi, linux-kernel, wens,
robh+dt, linux-crypto, m.cerveny, davem, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1715 bytes --]
On Thu, Sep 03, 2020 at 04:54:45PM +0200, Corentin Labbe wrote:
> When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset.
> Furthermore, there are no need to use items to list only one compatible
> in compatible list.
>
> Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> Change since v1:
> - use an enum for adding allwinner,sun8i-a33-crypto to "reset list"
>
> .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> index fc823572bcff..279f4a2e1dd7 100644
> --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> @@ -23,8 +23,7 @@ properties:
> - items:
> - const: allwinner,sun7i-a20-crypto
> - const: allwinner,sun4i-a10-crypto
> - - items:
> - - const: allwinner,sun8i-a33-crypto
> + - const: allwinner,sun8i-a33-crypto
>
> reg:
> maxItems: 1
> @@ -59,7 +58,9 @@ if:
> properties:
> compatible:
> contains:
> - const: allwinner,sun6i-a31-crypto
> + enum:
> + - const: allwinner,sun6i-a31-crypto
> + - const: allwinner,sun8i-a33-crypto
That's not the proper syntax for an enum, this would be
> + enum:
> + - allwinner,sun6i-a31-crypto
> + - allwinner,sun8i-a33-crypto
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-04 9:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 14:54 [PATCH v2] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset Corentin Labbe
2020-09-03 14:54 ` [PATCH v2] dt-bindings: crypto: Specify that allwinner, sun8i-a33-crypto " Corentin Labbe
2020-09-04 9:15 ` [PATCH v2] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto " Maxime Ripard
2020-09-04 9:15 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.