From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Krzysztof Opasiak <k.opasiak@samsung.com>, Kukjin Kim <kgene@kernel.org>, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfc@lists.01.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Marek Szyprowski <m.szyprowski@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, Chanwoo Choi <cw00.choi@samsung.com>, Inki Dae <inki.dae@samsung.com> Subject: Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Date: Thu, 3 Sep 2020 10:32:55 -0600 [thread overview] Message-ID: <20200903163255.GA2903619@bogus> (raw) In-Reply-To: <20200829142948.32365-1-krzk@kernel.org> On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > This is conversion only so it includes properties with invalid prefixes > (s3fwrn5,en-gpios) which should be addressed later. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------- > .../devicetree/bindings/net/nfc/s3fwrn5.yaml | 59 +++++++++++++++++++ Please rename to samsung,s3fwrn5-i2c.yaml. > MAINTAINERS | 1 + > 3 files changed, 60 insertions(+), 25 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > deleted file mode 100644 > index f02f6fb7f81c..000000000000 > --- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > +++ /dev/null > @@ -1,25 +0,0 @@ > -* Samsung S3FWRN5 NCI NFC Controller > - > -Required properties: > -- compatible: Should be "samsung,s3fwrn5-i2c". > -- reg: address on the bus > -- interrupts: GPIO interrupt to which the chip is connected > -- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the chip > -- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and > - sleep/wakeup control > - > -Example: > - > -&hsi2c_4 { > - s3fwrn5@27 { > - compatible = "samsung,s3fwrn5-i2c"; > - > - reg = <0x27>; > - > - interrupt-parent = <&gpa1>; > - interrupts = <3 0 0>; > - > - s3fwrn5,en-gpios = <&gpf1 4 0>; > - s3fwrn5,fw-gpios = <&gpj0 2 0>; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > new file mode 100644 > index 000000000000..c22451dea350 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nfc/s3fwrn5.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S3FWRN5 NCI NFC Controller > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> > + - Krzysztof Opasiak <k.opasiak@samsung.com> > + > +properties: > + compatible: > + const: samsung,s3fwrn5-i2c > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + s3fwrn5,en-gpios: > + maxItems: 1 > + description: > + Output GPIO pin used for enabling/disabling the chip > + > + s3fwrn5,fw-gpios: > + maxItems: 1 > + description: > + Output GPIO pin used to enter firmware mode and sleep/wakeup control > + > +required: > + - compatible > + - interrupts > + - reg > + - s3fwrn5,en-gpios > + - s3fwrn5,fw-gpios additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c4 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + s3fwrn5@27 { > + compatible = "samsung,s3fwrn5-i2c"; > + reg = <0x27>; > + > + interrupt-parent = <&gpa1>; > + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; > + > + s3fwrn5,en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>; > + s3fwrn5,fw-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index ac79fdbdf8d0..91b3d5c349d8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15273,6 +15273,7 @@ M: Robert Baldyga <r.baldyga@samsung.com> > M: Krzysztof Opasiak <k.opasiak@samsung.com> > L: linux-nfc@lists.01.org (moderated for non-subscribers) > S: Supported > +F: Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > F: drivers/nfc/s3fwrn5 > > SAMSUNG S5C73M3 CAMERA DRIVER > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-nfc@lists.01.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Kukjin Kim <kgene@kernel.org>, Krzysztof Opasiak <k.opasiak@samsung.com>, Jakub Kicinski <kuba@kernel.org>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Date: Thu, 3 Sep 2020 10:32:55 -0600 [thread overview] Message-ID: <20200903163255.GA2903619@bogus> (raw) In-Reply-To: <20200829142948.32365-1-krzk@kernel.org> On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > This is conversion only so it includes properties with invalid prefixes > (s3fwrn5,en-gpios) which should be addressed later. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------- > .../devicetree/bindings/net/nfc/s3fwrn5.yaml | 59 +++++++++++++++++++ Please rename to samsung,s3fwrn5-i2c.yaml. > MAINTAINERS | 1 + > 3 files changed, 60 insertions(+), 25 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > deleted file mode 100644 > index f02f6fb7f81c..000000000000 > --- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > +++ /dev/null > @@ -1,25 +0,0 @@ > -* Samsung S3FWRN5 NCI NFC Controller > - > -Required properties: > -- compatible: Should be "samsung,s3fwrn5-i2c". > -- reg: address on the bus > -- interrupts: GPIO interrupt to which the chip is connected > -- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the chip > -- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and > - sleep/wakeup control > - > -Example: > - > -&hsi2c_4 { > - s3fwrn5@27 { > - compatible = "samsung,s3fwrn5-i2c"; > - > - reg = <0x27>; > - > - interrupt-parent = <&gpa1>; > - interrupts = <3 0 0>; > - > - s3fwrn5,en-gpios = <&gpf1 4 0>; > - s3fwrn5,fw-gpios = <&gpj0 2 0>; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > new file mode 100644 > index 000000000000..c22451dea350 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nfc/s3fwrn5.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S3FWRN5 NCI NFC Controller > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> > + - Krzysztof Opasiak <k.opasiak@samsung.com> > + > +properties: > + compatible: > + const: samsung,s3fwrn5-i2c > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + s3fwrn5,en-gpios: > + maxItems: 1 > + description: > + Output GPIO pin used for enabling/disabling the chip > + > + s3fwrn5,fw-gpios: > + maxItems: 1 > + description: > + Output GPIO pin used to enter firmware mode and sleep/wakeup control > + > +required: > + - compatible > + - interrupts > + - reg > + - s3fwrn5,en-gpios > + - s3fwrn5,fw-gpios additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c4 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + s3fwrn5@27 { > + compatible = "samsung,s3fwrn5-i2c"; > + reg = <0x27>; > + > + interrupt-parent = <&gpa1>; > + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; > + > + s3fwrn5,en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>; > + s3fwrn5,fw-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index ac79fdbdf8d0..91b3d5c349d8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15273,6 +15273,7 @@ M: Robert Baldyga <r.baldyga@samsung.com> > M: Krzysztof Opasiak <k.opasiak@samsung.com> > L: linux-nfc@lists.01.org (moderated for non-subscribers) > S: Supported > +F: Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > F: drivers/nfc/s3fwrn5 > > SAMSUNG S5C73M3 CAMERA DRIVER > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-03 16:33 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-29 14:29 [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski 2020-08-29 14:29 ` Krzysztof Kozlowski 2020-08-29 14:29 ` [PATCH 2/4] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs Krzysztof Kozlowski 2020-08-29 14:29 ` Krzysztof Kozlowski 2020-08-29 14:29 ` [RFT 3/4] " Krzysztof Kozlowski 2020-08-29 14:29 ` Krzysztof Kozlowski 2020-08-31 13:16 ` Marek Szyprowski 2020-08-31 13:16 ` Marek Szyprowski 2020-08-29 14:29 ` [PATCH 4/4] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2 Krzysztof Kozlowski 2020-08-29 14:29 ` Krzysztof Kozlowski 2020-08-31 13:16 ` Marek Szyprowski 2020-08-31 13:16 ` Marek Szyprowski 2020-08-31 13:51 ` Krzysztof Kozlowski 2020-08-31 13:51 ` Krzysztof Kozlowski 2020-09-03 16:32 ` Rob Herring [this message] 2020-09-03 16:32 ` [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Rob Herring 2020-09-06 14:38 ` Krzysztof Kozlowski 2020-09-06 14:38 ` Krzysztof Kozlowski 2020-09-06 14:38 ` Krzysztof Kozlowski 2020-09-06 14:38 ` [linux-nfc] " Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200903163255.GA2903619@bogus \ --to=robh@kernel.org \ --cc=b.zolnierkie@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=inki.dae@samsung.com \ --cc=k.opasiak@samsung.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfc@lists.01.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=netdev@vger.kernel.org \ --cc=snawrocki@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.