From: Thierry Reding <thierry.reding@gmail.com> To: Joerg Roedel <joro@8bytes.org> Cc: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] iommu: Implement of_iommu_get_resv_regions() Date: Fri, 4 Sep 2020 14:59:58 +0200 [thread overview] Message-ID: <20200904130000.691933-2-thierry.reding@gmail.com> (raw) In-Reply-To: <20200904130000.691933-1-thierry.reding@gmail.com> From: Thierry Reding <treding@nvidia.com> This is an implementation that IOMMU drivers can use to obtain reserved memory regions from a device tree node. It uses the reserved-memory DT bindings to find the regions associated with a given device. These regions will be used to create 1:1 mappings in the IOMMU domain that the devices will be attached to. Cc: Frank Rowand <frowand.list@gmail.com> Cc: devicetree@vger.kernel.org Signed-off-by: Thierry Reding <treding@nvidia.com> --- Hi Rob, you had previously reviewed this patch, but I haven't included that here because there's a new property now that you might not be okay with. Thierry Changes in v2: - use "active" property to determine whether direct mapping are needed drivers/iommu/of_iommu.c | 49 ++++++++++++++++++++++++++++++++++++++++ include/linux/of_iommu.h | 8 +++++++ 2 files changed, 57 insertions(+) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index e505b9130a1c..3341d27fbbba 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -11,6 +11,7 @@ #include <linux/module.h> #include <linux/msi.h> #include <linux/of.h> +#include <linux/of_address.h> #include <linux/of_iommu.h> #include <linux/of_pci.h> #include <linux/pci.h> @@ -245,3 +246,51 @@ const struct iommu_ops *of_iommu_configure(struct device *dev, return ops; } + +/** + * of_iommu_get_resv_regions - reserved region driver helper for device tree + * @dev: device for which to get reserved regions + * @list: reserved region list + * + * IOMMU drivers can use this to implement their .get_resv_regions() callback + * for memory regions attached to a device tree node. See the reserved-memory + * device tree bindings on how to use these: + * + * Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt + */ +void of_iommu_get_resv_regions(struct device *dev, struct list_head *list) +{ + struct of_phandle_iterator it; + int err; + + of_for_each_phandle(&it, err, dev->of_node, "memory-region", NULL, 0) { + struct iommu_resv_region *region; + struct resource res; + + /* + * Active memory regions are expected to be accessed by + * hardware during boot and must therefore have an identity + * mapping created prior to the driver taking control of the + * hardware. This ensures that non-quiescent hardware doesn't + * cause IOMMU faults during boot. + */ + if (!of_property_read_bool(it.node, "active")) + continue; + + err = of_address_to_resource(it.node, 0, &res); + if (err < 0) { + dev_err(dev, "failed to parse memory region %pOF: %d\n", + it.node, err); + continue; + } + + region = iommu_alloc_resv_region(res.start, resource_size(&res), + IOMMU_READ | IOMMU_WRITE, + IOMMU_RESV_DIRECT_RELAXABLE); + if (!region) + continue; + + list_add_tail(®ion->list, list); + } +} +EXPORT_SYMBOL(of_iommu_get_resv_regions); diff --git a/include/linux/of_iommu.h b/include/linux/of_iommu.h index 16f4b3e87f20..8412437acaac 100644 --- a/include/linux/of_iommu.h +++ b/include/linux/of_iommu.h @@ -16,6 +16,9 @@ extern const struct iommu_ops *of_iommu_configure(struct device *dev, struct device_node *master_np, const u32 *id); +extern void of_iommu_get_resv_regions(struct device *dev, + struct list_head *list); + #else static inline int of_get_dma_window(struct device_node *dn, const char *prefix, @@ -32,6 +35,11 @@ static inline const struct iommu_ops *of_iommu_configure(struct device *dev, return NULL; } +static inline void of_iommu_get_resv_regions(struct device *dev, + struct list_head *list) +{ +} + #endif /* CONFIG_OF_IOMMU */ #endif /* __OF_IOMMU_H */ -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com> To: Joerg Roedel <joro@8bytes.org> Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>, Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Rob Herring <robh+dt@kernel.org>, Will Deacon <will@kernel.org> Subject: [PATCH v2 2/4] iommu: Implement of_iommu_get_resv_regions() Date: Fri, 4 Sep 2020 14:59:58 +0200 [thread overview] Message-ID: <20200904130000.691933-2-thierry.reding@gmail.com> (raw) In-Reply-To: <20200904130000.691933-1-thierry.reding@gmail.com> From: Thierry Reding <treding@nvidia.com> This is an implementation that IOMMU drivers can use to obtain reserved memory regions from a device tree node. It uses the reserved-memory DT bindings to find the regions associated with a given device. These regions will be used to create 1:1 mappings in the IOMMU domain that the devices will be attached to. Cc: Frank Rowand <frowand.list@gmail.com> Cc: devicetree@vger.kernel.org Signed-off-by: Thierry Reding <treding@nvidia.com> --- Hi Rob, you had previously reviewed this patch, but I haven't included that here because there's a new property now that you might not be okay with. Thierry Changes in v2: - use "active" property to determine whether direct mapping are needed drivers/iommu/of_iommu.c | 49 ++++++++++++++++++++++++++++++++++++++++ include/linux/of_iommu.h | 8 +++++++ 2 files changed, 57 insertions(+) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index e505b9130a1c..3341d27fbbba 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -11,6 +11,7 @@ #include <linux/module.h> #include <linux/msi.h> #include <linux/of.h> +#include <linux/of_address.h> #include <linux/of_iommu.h> #include <linux/of_pci.h> #include <linux/pci.h> @@ -245,3 +246,51 @@ const struct iommu_ops *of_iommu_configure(struct device *dev, return ops; } + +/** + * of_iommu_get_resv_regions - reserved region driver helper for device tree + * @dev: device for which to get reserved regions + * @list: reserved region list + * + * IOMMU drivers can use this to implement their .get_resv_regions() callback + * for memory regions attached to a device tree node. See the reserved-memory + * device tree bindings on how to use these: + * + * Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt + */ +void of_iommu_get_resv_regions(struct device *dev, struct list_head *list) +{ + struct of_phandle_iterator it; + int err; + + of_for_each_phandle(&it, err, dev->of_node, "memory-region", NULL, 0) { + struct iommu_resv_region *region; + struct resource res; + + /* + * Active memory regions are expected to be accessed by + * hardware during boot and must therefore have an identity + * mapping created prior to the driver taking control of the + * hardware. This ensures that non-quiescent hardware doesn't + * cause IOMMU faults during boot. + */ + if (!of_property_read_bool(it.node, "active")) + continue; + + err = of_address_to_resource(it.node, 0, &res); + if (err < 0) { + dev_err(dev, "failed to parse memory region %pOF: %d\n", + it.node, err); + continue; + } + + region = iommu_alloc_resv_region(res.start, resource_size(&res), + IOMMU_READ | IOMMU_WRITE, + IOMMU_RESV_DIRECT_RELAXABLE); + if (!region) + continue; + + list_add_tail(®ion->list, list); + } +} +EXPORT_SYMBOL(of_iommu_get_resv_regions); diff --git a/include/linux/of_iommu.h b/include/linux/of_iommu.h index 16f4b3e87f20..8412437acaac 100644 --- a/include/linux/of_iommu.h +++ b/include/linux/of_iommu.h @@ -16,6 +16,9 @@ extern const struct iommu_ops *of_iommu_configure(struct device *dev, struct device_node *master_np, const u32 *id); +extern void of_iommu_get_resv_regions(struct device *dev, + struct list_head *list); + #else static inline int of_get_dma_window(struct device_node *dn, const char *prefix, @@ -32,6 +35,11 @@ static inline const struct iommu_ops *of_iommu_configure(struct device *dev, return NULL; } +static inline void of_iommu_get_resv_regions(struct device *dev, + struct list_head *list) +{ +} + #endif /* CONFIG_OF_IOMMU */ #endif /* __OF_IOMMU_H */ -- 2.28.0 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-04 13:01 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-04 12:59 [PATCH v2 1/4] dt-bindings: reserved-memory: Document "active" property Thierry Reding 2020-09-04 12:59 ` Thierry Reding 2020-09-04 12:59 ` Thierry Reding [this message] 2020-09-04 12:59 ` [PATCH v2 2/4] iommu: Implement of_iommu_get_resv_regions() Thierry Reding 2020-09-04 12:59 ` [PATCH v2 3/4] iommu: dma: Use of_iommu_get_resv_regions() Thierry Reding 2020-09-04 12:59 ` Thierry Reding 2020-09-04 13:00 ` [RFC 4/4] iommu/tegra-smmu: Add support for reserved regions Thierry Reding 2020-09-04 13:00 ` Thierry Reding 2020-09-14 22:08 ` [PATCH v2 1/4] dt-bindings: reserved-memory: Document "active" property Rob Herring 2020-09-14 22:08 ` Rob Herring 2020-09-15 12:36 ` Thierry Reding 2020-09-15 12:36 ` Thierry Reding 2020-09-24 11:27 ` Thierry Reding 2020-09-24 11:27 ` Thierry Reding 2020-11-05 16:43 ` Thierry Reding 2020-11-05 16:43 ` Thierry Reding 2020-11-05 17:47 ` Robin Murphy 2020-11-05 17:47 ` Robin Murphy 2020-11-06 15:25 ` Thierry Reding 2020-11-06 15:25 ` Thierry Reding 2020-11-10 19:33 ` Thierry Reding 2020-11-10 19:33 ` Thierry Reding 2020-12-17 15:00 ` Thierry Reding 2020-12-17 15:00 ` Thierry Reding 2020-12-18 22:15 ` Rob Herring 2020-12-18 22:15 ` Rob Herring 2020-12-19 0:49 ` Thierry Reding 2020-12-19 0:49 ` Thierry Reding 2020-09-24 13:23 ` Dmitry Osipenko 2020-09-24 13:23 ` Dmitry Osipenko 2020-09-24 14:01 ` Thierry Reding 2020-09-24 14:01 ` Thierry Reding 2020-09-24 16:23 ` Dmitry Osipenko 2020-09-24 16:23 ` Dmitry Osipenko 2020-09-25 12:39 ` Robin Murphy 2020-09-25 12:39 ` Robin Murphy 2020-09-25 13:21 ` Dmitry Osipenko 2020-09-25 13:21 ` Dmitry Osipenko 2020-11-05 16:23 ` Thierry Reding 2020-11-05 16:23 ` Thierry Reding 2020-09-25 13:52 ` Dmitry Osipenko 2020-09-25 13:52 ` Dmitry Osipenko 2020-11-05 15:57 ` Thierry Reding 2020-11-05 15:57 ` Thierry Reding 2020-11-05 15:49 ` Thierry Reding 2020-11-05 15:49 ` Thierry Reding 2021-01-12 19:00 ` Dmitry Osipenko 2021-01-12 19:00 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200904130000.691933-2-thierry.reding@gmail.com \ --to=thierry.reding@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.