* [PATCH v1 RESEND] ARM64: dts: imx8mp: correct sdma1 clk setting
@ 2020-09-01 10:21 ` Robin Gong
0 siblings, 0 replies; 4+ messages in thread
From: Robin Gong @ 2020-09-01 10:21 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, festevam, Anson.Huang
Cc: kernel, linux-imx, devicetree, linux-arm-kernel, linux-kernel
Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
1:1.
Fixes: 6d9b8d20431f ("arm64: dts: freescale: Add i.MX8MP dtsi support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index cad2dd7..6038f66 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -702,7 +702,7 @@
reg = <0x30bd0000 0x10000>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MP_CLK_SDMA1_ROOT>,
- <&clk IMX8MP_CLK_SDMA1_ROOT>;
+ <&clk IMX8MP_CLK_AHB>;
clock-names = "ipg", "ahb";
#dma-cells = <3>;
fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 RESEND] ARM64: dts: imx8mp: correct sdma1 clk setting
@ 2020-09-01 10:21 ` Robin Gong
0 siblings, 0 replies; 4+ messages in thread
From: Robin Gong @ 2020-09-01 10:21 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, festevam, Anson.Huang
Cc: linux-arm-kernel, devicetree, linux-imx, kernel, linux-kernel
Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
1:1.
Fixes: 6d9b8d20431f ("arm64: dts: freescale: Add i.MX8MP dtsi support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index cad2dd7..6038f66 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -702,7 +702,7 @@
reg = <0x30bd0000 0x10000>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MP_CLK_SDMA1_ROOT>,
- <&clk IMX8MP_CLK_SDMA1_ROOT>;
+ <&clk IMX8MP_CLK_AHB>;
clock-names = "ipg", "ahb";
#dma-cells = <3>;
fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 RESEND] ARM64: dts: imx8mp: correct sdma1 clk setting
2020-09-01 10:21 ` Robin Gong
@ 2020-09-05 7:01 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-09-05 7:01 UTC (permalink / raw)
To: Robin Gong
Cc: robh+dt, s.hauer, festevam, Anson.Huang, kernel, linux-imx,
devicetree, linux-arm-kernel, linux-kernel
On Tue, Sep 01, 2020 at 06:21:49PM +0800, Robin Gong wrote:
> Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
> 1:1.
>
> Fixes: 6d9b8d20431f ("arm64: dts: freescale: Add i.MX8MP dtsi support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 RESEND] ARM64: dts: imx8mp: correct sdma1 clk setting
@ 2020-09-05 7:01 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-09-05 7:01 UTC (permalink / raw)
To: Robin Gong
Cc: devicetree, Anson.Huang, s.hauer, linux-kernel, robh+dt,
linux-imx, kernel, festevam, linux-arm-kernel
On Tue, Sep 01, 2020 at 06:21:49PM +0800, Robin Gong wrote:
> Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
> 1:1.
>
> Fixes: 6d9b8d20431f ("arm64: dts: freescale: Add i.MX8MP dtsi support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-05 7:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01 10:21 [PATCH v1 RESEND] ARM64: dts: imx8mp: correct sdma1 clk setting Robin Gong
2020-09-01 10:21 ` Robin Gong
2020-09-05 7:01 ` Shawn Guo
2020-09-05 7:01 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.