From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@nvidia.com,
bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit
Date: Sun, 6 Sep 2020 14:32:03 -0700 [thread overview]
Message-ID: <20200906143203.011eb7ea@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <4f8ec4f0-6311-3b18-c7c4-a3a49b8d94b4@cumulusnetworks.com>
On Mon, 7 Sep 2020 00:14:51 +0300 Nikolay Aleksandrov wrote:
> On 9/7/20 12:01 AM, Jakub Kicinski wrote:
> > On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote:
> >> We need to be able to retransmit group-specific and group-and-source
> >> specific queries. The new timer takes care of those.
> >
> > What guarantees that timer will not use pg after free? Do timer
> > callbacks hold the RCU read lock?
>
> See the last patch, it guarantees no entry timer will be used when it's freed.
Ack.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net, roopa@nvidia.com
Subject: Re: [Bridge] [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit
Date: Sun, 6 Sep 2020 14:32:03 -0700 [thread overview]
Message-ID: <20200906143203.011eb7ea@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <4f8ec4f0-6311-3b18-c7c4-a3a49b8d94b4@cumulusnetworks.com>
On Mon, 7 Sep 2020 00:14:51 +0300 Nikolay Aleksandrov wrote:
> On 9/7/20 12:01 AM, Jakub Kicinski wrote:
> > On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote:
> >> We need to be able to retransmit group-specific and group-and-source
> >> specific queries. The new timer takes care of those.
> >
> > What guarantees that timer will not use pg after free? Do timer
> > callbacks hold the RCU read lock?
>
> See the last patch, it guarantees no entry timer will be used when it's freed.
Ack.
next prev parent reply other threads:[~2020-09-06 21:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 8:23 [PATCH net-next v3 00/15] net: bridge: mcast: initial IGMPv3/MLDv2 support (part 1) Nikolay Aleksandrov
2020-09-05 8:23 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:23 ` [PATCH net-next v3 01/15] net: bridge: mdb: arrange internal structs so fast-path fields are close Nikolay Aleksandrov
2020-09-05 8:23 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:23 ` [PATCH net-next v3 02/15] net: bridge: mcast: add support for group source list Nikolay Aleksandrov
2020-09-05 8:23 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:23 ` [PATCH net-next v3 03/15] net: bridge: mcast: add support for src list and filter mode dumping Nikolay Aleksandrov
2020-09-05 8:23 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:23 ` [PATCH net-next v3 04/15] net: bridge: mcast: add support for group-and-source specific queries Nikolay Aleksandrov
2020-09-05 8:23 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-06 20:56 ` Jakub Kicinski
2020-09-06 20:56 ` [Bridge] " Jakub Kicinski
2020-09-06 21:29 ` Nikolay Aleksandrov
2020-09-06 21:29 ` [Bridge] " Nikolay Aleksandrov
2020-09-06 21:31 ` Nikolay Aleksandrov
2020-09-06 21:31 ` [Bridge] " Nikolay Aleksandrov
2020-09-06 21:33 ` Jakub Kicinski
2020-09-06 21:33 ` [Bridge] " Jakub Kicinski
2020-09-05 8:24 ` [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-06 21:01 ` Jakub Kicinski
2020-09-06 21:01 ` [Bridge] " Jakub Kicinski
2020-09-06 21:14 ` Nikolay Aleksandrov
2020-09-06 21:14 ` [Bridge] " Nikolay Aleksandrov
2020-09-06 21:32 ` Jakub Kicinski [this message]
2020-09-06 21:32 ` Jakub Kicinski
2020-09-05 8:24 ` [PATCH net-next v3 07/15] net: bridge: mdb: push notifications in __br_mdb_add/del Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 08/15] net: bridge: mdb: use mdb and port entries in notifications Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 09/15] net: bridge: mcast: delete expired port groups without srcs Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 10/15] net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES report Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 11/15] net: bridge: mcast: support for IGMPV3/MLDv2 MODE_IS_INCLUDE/EXCLUDE report Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 12/15] net: bridge: mcast: support for IGMPV3/MLDv2 CHANGE_TO_INCLUDE/EXCLUDE report Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 13/15] net: bridge: mcast: support for IGMPV3/MLDv2 BLOCK_OLD_SOURCES report Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 14/15] net: bridge: mcast: improve IGMPv3/MLDv2 query processing Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
2020-09-05 8:24 ` [PATCH net-next v3 15/15] net: bridge: mcast: destroy all entries via gc Nikolay Aleksandrov
2020-09-05 8:24 ` [Bridge] " Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906143203.011eb7ea@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.