[igt-dev] [PATCH i-g-t] i915/gem_pwrite: Added test description for test case

* [igt-dev] [PATCH i-g-t] i915/gem_pwrite: Added test description for test case
@ 2020-09-07  8:14 apoorva1.singh
  2020-09-07  8:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2020-09-07 11:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: apoorva1.singh @ 2020-09-07  8:14 UTC (permalink / raw)
  To: igt-dev, arjun.melkaveri

From: Apoorva Singh <apoorva1.singh@intel.com>

Added test description to all the available subtests.

Cc: Melkaveri, Arjun <arjun.melkaveri@intel.com>
Signed-off-by: Apoorva Singh <apoorva1.singh@intel.com>
---
 tests/i915/gem_pwrite.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/tests/i915/gem_pwrite.c b/tests/i915/gem_pwrite.c
index e491263f..83befe12 100644
--- a/tests/i915/gem_pwrite.c
+++ b/tests/i915/gem_pwrite.c
@@ -42,6 +42,8 @@
 #include "igt.h"
 #include "igt_rand.h"
 
+IGT_TEST_DESCRIPTION("Sanity and performance testing of PWRITE IOCTL.");
+
 #define MiB(x) ((x) * 1024 * 1024)
 
 typedef void *(*mmap_fn_t)(int, uint32_t, uint64_t, uint64_t, unsigned int);
@@ -322,6 +324,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
 		src = malloc(object_size);
 	}
 
+	igt_describe("Test the performance of writing into gem object");
 	igt_subtest("bench") {
 		for (count = 1; count <= 1<<17; count <<= 1) {
 			struct timeval start, end;
@@ -337,10 +340,14 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
 		}
 	}
 
+	igt_describe("Verify writing into gem object from address space mapped "
+	       "(using different mapping methods) to itself works fine");
 	igt_subtest("self")
 		pwrite_self(fd);
 
 	for (c = cache; c->level != -1; c++) {
+		igt_describe_f("Test the performance of writing into gem object with "
+		       "%s caching mode", c->name);
 		igt_subtest(c->name) {
 			gem_set_caching(fd, dst, c->level);
 
@@ -364,6 +371,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
 		gem_close(fd, dst);
 	}
 
+	igt_describe("Validation of random data written at random offset of the gem object");
 	igt_subtest_f("basic-random")
 		test_random(fd);
 
@@ -379,18 +387,36 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
 			{ NULL },
 		}, *m;
 		for (m = modes; m->name; m++) {
+			igt_describe_f("Validation of writes into small buffer object with "
+			       "CPU domain set for read-write. Writes are done going %s",
+			        strcmp(m->name, "fbr") ? m->name : "forward-backword-random");
 			igt_subtest_f("small-cpu-%s", m->name)
 				test_big_cpu(fd, 0, m->flags);
+			igt_describe_f("Validation of writes into small buffer object with "
+			       "GTT domain set for read-write. Writes are done going %s.",
+			        strcmp(m->name, "fbr") ? m->name : "forward-backword-random");
 			igt_subtest_f("small-gtt-%s", m->name)
 				test_big_gtt(fd, 0, m->flags);
 
+			igt_describe_f("Validation of writes into big buffer object with "
+			       "CPU domain set for read-write. Writes are done going %s.",
+			        strcmp(m->name, "fbr") ? m->name : "forward-backword-random");
 			igt_subtest_f("big-cpu-%s", m->name)
 				test_big_cpu(fd, 1, m->flags);
+			igt_describe_f("Validation of writes into big buffer object with "
+			       "GTT domain set for read-write. Writes are done going %s.",
+			        strcmp(m->name, "fbr") ? m->name : "forward-backword-random");
 			igt_subtest_f("big-gtt-%s", m->name)
 				test_big_gtt(fd, 1, m->flags);
 
+			igt_describe_f("Validation of writes into huge buffer object with "
+			       "CPU domain set for read-write. Writes are done going %s.",
+			        strcmp(m->name, "fbr") ? m->name : "forward-backword-random");
 			igt_subtest_f("huge-cpu-%s", m->name)
 				test_big_cpu(fd, 2, m->flags);
+			igt_describe_f("Validation of writes into huge buffer object with "
+			       "GTT domin set for read-write. Writes are done going %s.",
+			        strcmp(m->name, "fbr") ? m->name : "forward-backword-random");
 			igt_subtest_f("huge-gtt-%s", m->name)
 				test_big_gtt(fd, 2, m->flags);
 		}
-- 
2.28.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 3+ messages in thread