From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Jiaxin Yu <jiaxin.yu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ALSA development <alsa-devel@alsa-project.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, howie.huang@mediatek.com,
eason.yen@mediatek.com, shane.chien@mediatek.com,
bicycle.tsai@mediatek.com
Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document
Date: Mon, 7 Sep 2020 18:50:59 +0100 [thread overview]
Message-ID: <20200907175059.GD4907@sirena.org.uk> (raw)
In-Reply-To: <CA+Px+wWMH6iUzFq0g4BFC5qA993r9UBobmNAyS2ie+xDwci-yg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Mon, Sep 07, 2020 at 09:37:12PM +0800, Tzung-Bi Shih wrote:
> On Thu, Aug 20, 2020 at 3:40 AM Mark Brown <broonie@kernel.org> wrote:
> > That's for binding the MFD subdevice to an OF node, you don't need to do
> > that for a device like this - you can just use the of_node of the parent
> > to get at the properties.
> There is an issue we overlooked. In sound/soc/codecs/mt6359.c,
> After removing the line at (1), mt6359_parse_dt() cannot read the DT properties.
> Here are a few options we can come out with.
> 1. adds back the compatible string in the DTS
> 2. gets of_node of parent in mt6359.c, and iterates all children nodes
> to get the desired properties
Do this, but instead of iterating all the child nodes just look for the
named CODEC node that you define in the bindings if you don't want to
put the properties in the root MFD node.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
howie.huang@mediatek.com, Takashi Iwai <tiwai@suse.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
shane.chien@mediatek.com, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, eason.yen@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
bicycle.tsai@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document
Date: Mon, 7 Sep 2020 18:50:59 +0100 [thread overview]
Message-ID: <20200907175059.GD4907@sirena.org.uk> (raw)
In-Reply-To: <CA+Px+wWMH6iUzFq0g4BFC5qA993r9UBobmNAyS2ie+xDwci-yg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Mon, Sep 07, 2020 at 09:37:12PM +0800, Tzung-Bi Shih wrote:
> On Thu, Aug 20, 2020 at 3:40 AM Mark Brown <broonie@kernel.org> wrote:
> > That's for binding the MFD subdevice to an OF node, you don't need to do
> > that for a device like this - you can just use the of_node of the parent
> > to get at the properties.
> There is an issue we overlooked. In sound/soc/codecs/mt6359.c,
> After removing the line at (1), mt6359_parse_dt() cannot read the DT properties.
> Here are a few options we can come out with.
> 1. adds back the compatible string in the DTS
> 2. gets of_node of parent in mt6359.c, and iterates all children nodes
> to get the desired properties
Do this, but instead of iterating all the child nodes just look for the
named CODEC node that you define in the bindings if you don't want to
put the properties in the root MFD node.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
howie.huang@mediatek.com, Takashi Iwai <tiwai@suse.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
shane.chien@mediatek.com, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, eason.yen@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
bicycle.tsai@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document
Date: Mon, 7 Sep 2020 18:50:59 +0100 [thread overview]
Message-ID: <20200907175059.GD4907@sirena.org.uk> (raw)
In-Reply-To: <CA+Px+wWMH6iUzFq0g4BFC5qA993r9UBobmNAyS2ie+xDwci-yg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 857 bytes --]
On Mon, Sep 07, 2020 at 09:37:12PM +0800, Tzung-Bi Shih wrote:
> On Thu, Aug 20, 2020 at 3:40 AM Mark Brown <broonie@kernel.org> wrote:
> > That's for binding the MFD subdevice to an OF node, you don't need to do
> > that for a device like this - you can just use the of_node of the parent
> > to get at the properties.
> There is an issue we overlooked. In sound/soc/codecs/mt6359.c,
> After removing the line at (1), mt6359_parse_dt() cannot read the DT properties.
> Here are a few options we can come out with.
> 1. adds back the compatible string in the DTS
> 2. gets of_node of parent in mt6359.c, and iterates all children nodes
> to get the desired properties
Do this, but instead of iterating all the child nodes just look for the
named CODEC node that you define in the bindings if you don't want to
put the properties in the root MFD node.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
howie.huang@mediatek.com, Takashi Iwai <tiwai@suse.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
shane.chien@mediatek.com, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, eason.yen@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
bicycle.tsai@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document
Date: Mon, 7 Sep 2020 18:50:59 +0100 [thread overview]
Message-ID: <20200907175059.GD4907@sirena.org.uk> (raw)
In-Reply-To: <CA+Px+wWMH6iUzFq0g4BFC5qA993r9UBobmNAyS2ie+xDwci-yg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 857 bytes --]
On Mon, Sep 07, 2020 at 09:37:12PM +0800, Tzung-Bi Shih wrote:
> On Thu, Aug 20, 2020 at 3:40 AM Mark Brown <broonie@kernel.org> wrote:
> > That's for binding the MFD subdevice to an OF node, you don't need to do
> > that for a device like this - you can just use the of_node of the parent
> > to get at the properties.
> There is an issue we overlooked. In sound/soc/codecs/mt6359.c,
> After removing the line at (1), mt6359_parse_dt() cannot read the DT properties.
> Here are a few options we can come out with.
> 1. adds back the compatible string in the DTS
> 2. gets of_node of parent in mt6359.c, and iterates all children nodes
> to get the desired properties
Do this, but instead of iterating all the child nodes just look for the
named CODEC node that you define in the bindings if you don't want to
put the properties in the root MFD node.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-07 17:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 6:07 [PATCH v5 0/2] Add mediatek codec mt6359 driver Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 6:07 ` [PATCH v5 1/2] ASoC: mediatek: mt6359: add codec driver Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 7:32 ` Tzung-Bi Shih
2020-08-17 7:32 ` Tzung-Bi Shih
2020-08-17 7:32 ` Tzung-Bi Shih
2020-08-17 7:32 ` Tzung-Bi Shih
2020-08-17 6:07 ` [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 6:07 ` Jiaxin Yu
2020-08-17 7:29 ` Tzung-Bi Shih
2020-08-17 7:29 ` Tzung-Bi Shih
2020-08-17 7:29 ` Tzung-Bi Shih
2020-08-17 7:29 ` Tzung-Bi Shih
2020-08-17 8:11 ` Tzung-Bi Shih
2020-08-17 8:11 ` Tzung-Bi Shih
2020-08-17 8:11 ` Tzung-Bi Shih
2020-08-17 8:11 ` Tzung-Bi Shih
2020-08-19 10:37 ` Mark Brown
2020-08-19 10:37 ` Mark Brown
2020-08-19 10:37 ` Mark Brown
2020-08-19 10:37 ` Mark Brown
2020-08-19 15:42 ` Tzung-Bi Shih
2020-08-19 15:42 ` Tzung-Bi Shih
2020-08-19 15:42 ` Tzung-Bi Shih
2020-08-19 15:42 ` Tzung-Bi Shih
2020-08-19 19:40 ` Mark Brown
2020-08-19 19:40 ` Mark Brown
2020-08-19 19:40 ` Mark Brown
2020-08-19 19:40 ` Mark Brown
2020-09-07 13:37 ` Tzung-Bi Shih
2020-09-07 13:37 ` Tzung-Bi Shih
2020-09-07 13:37 ` Tzung-Bi Shih
2020-09-07 13:37 ` Tzung-Bi Shih
2020-09-07 17:50 ` Mark Brown [this message]
2020-09-07 17:50 ` Mark Brown
2020-09-07 17:50 ` Mark Brown
2020-09-07 17:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907175059.GD4907@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bicycle.tsai@mediatek.com \
--cc=eason.yen@mediatek.com \
--cc=howie.huang@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.